[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822812#comment-17822812 ] ASF GitHub Bot commented on HDFS-17333: --- KeeProMise commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1974786724 > I made a slight change to the title to avoid including symbols, then merged it. Thanks for your contribution, @KeeProMise! @tasanuma Thanks for your review and merge it! > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822807#comment-17822807 ] ASF GitHub Bot commented on HDFS-17333: --- tasanuma commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1974785792 I made a slight change to the title to avoid including symbols, then merged it. Thanks for your contribution, @KeeProMise! > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822806#comment-17822806 ] ASF GitHub Bot commented on HDFS-17333: --- tasanuma merged PR #6430: URL: https://github.com/apache/hadoop/pull/6430 > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822781#comment-17822781 ] ASF GitHub Bot commented on HDFS-17333: --- KeeProMise commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1974701918 > @KeeProMise Sorry for being very late. This is a nice feature and the PR looks pretty good to me. > > It's been a long time since Jenkins last ran, so I've triggered it to run again. If there are no issues, I'll merge this PR. https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-6430/4/pipeline Hi, thank you for reviewing this PR. I don't think the issues in unit testing and spotbugs are related to my code. Could you please help me review it again. > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[
https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822780#comment-17822780
]
ASF GitHub Bot commented on HDFS-17333:
---
hadoop-yetus commented on PR #6430:
URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1974699701
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 32s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 1s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 31s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 31m 40s | | trunk passed |
| +1 :green_heart: | compile | 17m 1s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 15m 37s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | checkstyle | 4m 12s | | trunk passed |
| +1 :green_heart: | mvnsite | 4m 18s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 19s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 3m 31s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| -1 :x: | spotbugs | 2m 30s |
[/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/5/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html)
| hadoop-common-project/hadoop-common in trunk has 1 extant spotbugs
warnings. |
| -1 :x: | spotbugs | 2m 38s |
[/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/5/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html)
| hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs
warnings. |
| +1 :green_heart: | shadedclient | 36m 24s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 53s | | the patch passed |
| +1 :green_heart: | compile | 17m 34s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 17m 34s | | the patch passed |
| +1 :green_heart: | compile | 16m 39s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | javac | 16m 39s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 37s | | the patch passed |
| +1 :green_heart: | mvnsite | 4m 11s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 5s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 3m 29s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 10m 2s | | the patch passed |
| +1 :green_heart: | shadedclient | 40m 18s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 19m 50s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 2m 40s | | hadoop-hdfs-client in the patch
passed. |
| -1 :x: | unit | 229m 39s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 1m 5s | | The patch does not
generate ASF License warnings. |
| | | 498m 2s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.server.datanode.TestLargeBlockReport |
| | hadoop.hdfs.protocol.TestBlockListAsLongs |
| | hadoop.hdfs.tools.TestDFSAdmin |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hadoop.a
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[
https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822719#comment-17822719
]
ASF GitHub Bot commented on HDFS-17333:
---
hadoop-yetus commented on PR #6430:
URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1974015178
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 35m 33s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 34s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 34m 23s | | trunk passed |
| +1 :green_heart: | compile | 16m 33s | | trunk passed |
| +1 :green_heart: | checkstyle | 4m 44s | | trunk passed |
| +1 :green_heart: | mvnsite | 4m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 46s | | trunk passed |
| -1 :x: | spotbugs | 2m 50s |
[/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/4/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html)
| hadoop-common-project/hadoop-common in trunk has 1 extant spotbugs
warnings. |
| -1 :x: | spotbugs | 2m 50s |
[/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/4/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html)
| hadoop-hdfs-project/hadoop-hdfs-client in trunk has 1 extant spotbugs
warnings. |
| +1 :green_heart: | shadedclient | 37m 4s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 7s | | the patch passed |
| +1 :green_heart: | compile | 16m 22s | | the patch passed |
| +1 :green_heart: | javac | 16m 22s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 34s | | the patch passed |
| +1 :green_heart: | mvnsite | 4m 21s | | the patch passed |
| +1 :green_heart: | xmllint | 0m 0s | | No new issues. |
| +1 :green_heart: | javadoc | 3m 31s | | the patch passed |
| +1 :green_heart: | spotbugs | 9m 51s | | the patch passed |
| +1 :green_heart: | shadedclient | 38m 27s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 20m 3s |
[/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt)
| hadoop-common in the patch passed. |
| +1 :green_heart: | unit | 2m 42s | | hadoop-hdfs-client in the patch
passed. |
| -1 :x: | unit | 228m 51s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 1m 9s | | The patch does not
generate ASF License warnings. |
| | | 495m 3s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests |
hadoop.crypto.TestCryptoStreamsWithOpensslSm4CtrCryptoCodec |
| | hadoop.service.launcher.TestServiceInterruptHandling |
| | hadoop.crypto.TestCryptoCodec |
| | hadoop.hdfs.server.datanode.TestLargeBlockReport |
| | hadoop.hdfs.protocol.TestBlockListAsLongs |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.44 ServerAPI=1.44 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6430 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
| uname | Linux 0d3228f82605 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9
15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-suppo
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822589#comment-17822589 ] ASF GitHub Bot commented on HDFS-17333: --- tasanuma commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1973277467 @KeeProMise Sorry for being very late. This is a nice feature and the PR looks pretty good to me. It's been a long time since Jenkins last ran, so I've triggered it to run again. If there are no issues, I'll merge this PR. https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-6430/4/pipeline > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821221#comment-17821221 ] ASF GitHub Bot commented on HDFS-17333: --- KeeProMise commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1966509264 Hi @tasanuma @Hexiaoqiao @zhangshuyan0, @slfan1989 Please kindly review this PR as well if you have bandwidth, Thanks. > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812276#comment-17812276 ] ASF GitHub Bot commented on HDFS-17333: --- KeeProMise commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1916683372 Hi @tasanuma @Hexiaoqiao @zhangshuyan0, Please kindly review this PR as well if you have bandwidth, Thanks. > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808906#comment-17808906 ] ASF GitHub Bot commented on HDFS-17333: --- KeeProMise commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1902086242 Can anyone help review it? Thanks. > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[ https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806492#comment-17806492 ] ASF GitHub Bot commented on HDFS-17333: --- KeeProMise commented on PR #6430: URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1891003400 @Hexiaoqiao hi, could you please help to review, thanks a lot! > DFSClient support lazy resolve host->ip. > > > Key: HDFS-17333 > URL: https://issues.apache.org/jira/browse/HDFS-17333 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Jian Zhang >Assignee: Jian Zhang >Priority: Major > Labels: pull-request-available > Attachments: HDFS-17333.001.patch > > > Currently, when dfsclient is started, it will resolve all hosts of all > namservices: > at DFSUtilClient#getAddresses(conf, null, addressKey) > at AbstractNNFailoverProxyProvider#getProxyAddresses(URI uri, > String addressKey) > If the current environment where the dfsClient is located causes resolution > of host->ip to be very slow, the existing logic will undoubtedly take a long > time when there are too many nameservices. > Now, each dfsclient only needs the IPs of all namenodes of a certain > nameservice at most. A better situation is that if the namenode selected by > dfsclient for the first time can provide the required services normally, then > the client only needs to know the IP of this namenode. Therefore, it is not > necessary to resolve all namenodes of all nameservices in the configuration > file, when dfsclient is started. > This patch supports lazy resolution of host->ip, which will only be resolved > when the host needs to be accessed. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[
https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805308#comment-17805308
]
ASF GitHub Bot commented on HDFS-17333:
---
hadoop-yetus commented on PR #6430:
URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1885834973
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 21s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 23s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 21m 18s | | trunk passed |
| +1 :green_heart: | compile | 9m 16s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 8m 37s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | checkstyle | 2m 15s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 1s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 2m 22s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 4m 43s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 45s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 35s | | the patch passed |
| +1 :green_heart: | compile | 8m 1s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 8m 1s | | the patch passed |
| +1 :green_heart: | compile | 7m 29s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | javac | 7m 29s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 57s | | the patch passed |
| +1 :green_heart: | mvnsite | 2m 17s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 46s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 2m 14s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 4m 56s | | the patch passed |
| +1 :green_heart: | shadedclient | 20m 47s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 16m 34s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 2m 0s | | hadoop-hdfs-client in the patch
passed. |
| +1 :green_heart: | unit | 184m 36s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 38s | | The patch does not
generate ASF License warnings. |
| | | 345m 43s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6430 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
| uname | Linux d05670ad082e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 0bd0e84010f6489ccc17351d793014ce0b444c1b |
| Default Java | Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/3/testReport/ |
| Max. process+thread count | 4653 (vs. ulimit of 5500) |
| modules | C: hadoop-common-p
[jira] [Commented] (HDFS-17333) DFSClient support lazy resolve host->ip.
[
https://issues.apache.org/jira/browse/HDFS-17333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805299#comment-17805299
]
ASF GitHub Bot commented on HDFS-17333:
---
hadoop-yetus commented on PR #6430:
URL: https://github.com/apache/hadoop/pull/6430#issuecomment-1885771188
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 33s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 6s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 34m 23s | | trunk passed |
| +1 :green_heart: | compile | 17m 44s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 16m 29s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | checkstyle | 4m 32s | | trunk passed |
| +1 :green_heart: | mvnsite | 4m 24s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 18s | | trunk passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 3m 31s | | trunk passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 8m 53s | | trunk passed |
| +1 :green_heart: | shadedclient | 38m 1s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 58s | | the patch passed |
| +1 :green_heart: | compile | 16m 48s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 16m 48s | | the patch passed |
| +1 :green_heart: | compile | 15m 27s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | javac | 15m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 28s | | the patch passed |
| +1 :green_heart: | mvnsite | 4m 24s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 12s | | the patch passed with JDK
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 3m 30s | | the patch passed with JDK
Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| +1 :green_heart: | spotbugs | 10m 9s | | the patch passed |
| +1 :green_heart: | shadedclient | 39m 22s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 19m 25s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 2m 44s | | hadoop-hdfs-client in the patch
passed. |
| +1 :green_heart: | unit | 215m 4s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 7s | | The patch does not
generate ASF License warnings. |
| | | 486m 33s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6430 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint |
| uname | Linux 6f24688a3742 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 95d9fbe4a7f83a66e29507536c1b2befd8c8fe46 |
| Default Java | Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6430/2/testReport/ |
| Max. process+thread count | 3940 (vs. ulimit of 5500) |
| modules | C: hadoop-common-p
