[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037333#comment-13037333 ] Hudson commented on HDFS-1741: -- Integrated in Hadoop-Hdfs-trunk #673 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/]) > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement > Components: build >Affects Versions: 0.23.0 >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Fix For: 0.23.0 > > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027494#comment-13027494 ] Konstantin Boudnik commented on HDFS-1741: -- Nigel, your help with INFRA is highly appreciated. As soon as HDFS is added to the Sonar we can do the other two components in the similar way. > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement > Components: build >Affects Versions: 0.23.0 >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Fix For: 0.23.0 > > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027491#comment-13027491 ] Eli Collins commented on HDFS-1741: --- +1 Thanks for the earlier explanations Cos. > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027483#comment-13027483 ] Konstantin Boudnik commented on HDFS-1741: -- Nigel, I will commit it as soon as the patch gets formal +1. Care to review? ;) > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027413#comment-13027413 ] Nigel Daley commented on HDFS-1741: --- Cos, once this is committed I'm happy to help with the infra work. > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026835#comment-13026835 ] Konstantin Boudnik commented on HDFS-1741: -- bq. Uses a variable instead of the literal string "0.23.0-SNAPSHOT". Right, as I said this is project.version setting. So in Maven world this is the ultimate source of version information. Everything else is suppose to use it if needed. Sonar handling is done at analysis.apache.org, so we don't need to do anything in the Hudson, but rather hdfs would have to be added to that server much like Avro, etc. > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026833#comment-13026833 ] Eli Collins commented on HDFS-1741: --- bq. Eli, I am not sure what you meant by is not hard-coded? Uses a variable instead of the literal string "0.23.0-SNAPSHOT". Was curious if it can use the ant version property. No big deal if it can't access variables from ant. Would be great to modify the current Hudson job to run Sonar? Is there an INFRA jira for that? Good stuff by the way. > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[
https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026822#comment-13026822
]
Konstantin Boudnik commented on HDFS-1741:
--
Eli, I am not sure what you meant by {{is not hard-coded}}? This is the
project's version definition (one of the core Maven properties) much like the
one in build.xml
{{}}
While I agree that adding 6th entry of the same version string to the build
system isn't a very bright thing to do, but I don't believe it should be taken
care off in this particular JIRA - it rather be better done as a part of
mavenization project. Besides, I am afraid Maven won't be able to use the one
from Ant build system.
As for testing, I have ran maven sonar:sonar with the test in place on a system
running sonar system and was able to see all kinds of statistics about HDFS
code base.
> Provide a minimal pom file to allow integration of HDFS into Sonar analysis
> ---
>
> Key: HDFS-1741
> URL: https://issues.apache.org/jira/browse/HDFS-1741
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Konstantin Boudnik
>Assignee: Konstantin Boudnik
> Attachments: HDFS-1741.patch
>
>
> In order to user Sonar facility a project has to be either build by Maven or
> has a special pom 'wrapper'. Let's provide a minimal one to allow just that.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026750#comment-13026750 ] Eli Collins commented on HDFS-1741: --- Can you make it so the version (0.23-SNAPSHOT) is not hard-coded? Testing? > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1741) Provide a minimal pom file to allow integration of HDFS into Sonar analysis
[ https://issues.apache.org/jira/browse/HDFS-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026305#comment-13026305 ] Konstantin Boudnik commented on HDFS-1741: -- Anyone cares to review? > Provide a minimal pom file to allow integration of HDFS into Sonar analysis > --- > > Key: HDFS-1741 > URL: https://issues.apache.org/jira/browse/HDFS-1741 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: Konstantin Boudnik >Assignee: Konstantin Boudnik > Attachments: HDFS-1741.patch > > > In order to user Sonar facility a project has to be either build by Maven or > has a special pom 'wrapper'. Let's provide a minimal one to allow just that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
