[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035731#comment-13035731 ] Suresh Srinivas commented on HDFS-1941: --- +1 for the patch. > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035896#comment-13035896 ] Hadoop QA commented on HDFS-1941: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479359/HDFS-1941-1.patch against trunk revision 1124459. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/569//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/569//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/569//console This message is automatically generated. > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035980#comment-13035980 ] Bharath Mundlapudi commented on HDFS-1941: -- Failed tests are not related to this patch. > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036012#comment-13036012 ] Suresh Srinivas commented on HDFS-1941: --- This patch also is removing a previous functionality that is no longer necessary and hence no tests. > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037202#comment-13037202 ] Hudson commented on HDFS-1941: -- Integrated in Hadoop-Hdfs-trunk-Commit #677 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/677/]) > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Fix For: 0.23.0 > > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037326#comment-13037326 ] Hudson commented on HDFS-1941: -- Integrated in Hadoop-Hdfs-trunk #673 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/]) > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Fix For: 0.23.0 > > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038829#comment-13038829 ] Suresh Srinivas commented on HDFS-1941: --- I reverted this change. This utility to generate cluster ID is useful for automated deployments. > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Fix For: 0.23.0 > > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038833#comment-13038833 ] Todd Lipcon commented on HDFS-1941: --- can you reopen and re-resolve it so that the jira indicates it was deemed invalid? > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Fix For: 0.23.0 > > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038844#comment-13038844 ] Suresh Srinivas commented on HDFS-1941: --- Todd, I just commented about reverting the change. Please give couple of more minutes and it will be done. > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Fix For: 0.23.0 > > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038845#comment-13038845 ] Hudson commented on HDFS-1941: -- Integrated in Hadoop-Hdfs-trunk-Commit #681 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/681/]) Reverting the change r1125031 - HDFS-1941. Remove -genclusterid option from namenode command. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127311 Files : * /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java * /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/common/HdfsConstants.java * /hadoop/hdfs/trunk/CHANGES.txt > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Fix For: 0.23.0 > > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1941) Remove -genclusterid from NameNode startup options
[ https://issues.apache.org/jira/browse/HDFS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039090#comment-13039090 ] Hudson commented on HDFS-1941: -- Integrated in Hadoop-Hdfs-trunk #677 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/677/]) Reverting the change r1125031 - HDFS-1941. Remove -genclusterid option from namenode command. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127311 Files : * /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java * /hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/common/HdfsConstants.java * /hadoop/hdfs/trunk/CHANGES.txt > Remove -genclusterid from NameNode startup options > -- > > Key: HDFS-1941 > URL: https://issues.apache.org/jira/browse/HDFS-1941 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi >Priority: Minor > Fix For: 0.23.0 > > Attachments: HDFS-1941-1.patch > > > Currently, namenode -genclusterid is a helper utility to generate unique > clusterid. This option is useless once namenode -format automatically > generates the clusterid. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
