[jira] [Commented] (HDFS-2041) Some mtimes and atimes are lost when edit logs are replayed
[ https://issues.apache.org/jira/browse/HDFS-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051035#comment-13051035 ] Hudson commented on HDFS-2041: -- Integrated in Hadoop-Hdfs-trunk #699 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/]) Some mtimes and atimes are lost when edit logs are replayed --- Key: HDFS-2041 URL: https://issues.apache.org/jira/browse/HDFS-2041 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Fix For: 0.23.0 Attachments: hdfs-2041.txt, hdfs-2041.txt The refactoring in HDFS-2003 allowed findbugs to expose two potential bugs: - the atime field logged with OP_MKDIR is unused - the timestamp field logged with OP_CONCAT_DELETE is unused The concat issue is definitely real. The atime for MKDIR might always be identical to mtime in that case, in which case it could be ignored. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2041) Some mtimes and atimes are lost when edit logs are replayed
[ https://issues.apache.org/jira/browse/HDFS-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13050112#comment-13050112 ] Hudson commented on HDFS-2041: -- Integrated in Hadoop-Hdfs-trunk-Commit #746 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/746/]) Some mtimes and atimes are lost when edit logs are replayed --- Key: HDFS-2041 URL: https://issues.apache.org/jira/browse/HDFS-2041 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Fix For: 0.23.0 Attachments: hdfs-2041.txt, hdfs-2041.txt The refactoring in HDFS-2003 allowed findbugs to expose two potential bugs: - the atime field logged with OP_MKDIR is unused - the timestamp field logged with OP_CONCAT_DELETE is unused The concat issue is definitely real. The atime for MKDIR might always be identical to mtime in that case, in which case it could be ignored. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2041) Some mtimes and atimes are lost when edit logs are replayed
[
https://issues.apache.org/jira/browse/HDFS-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047325#comment-13047325
]
Aaron T. Myers commented on HDFS-2041:
--
+1, the change looks good to me, Todd. Great find.
Thanks also for removing the vestigial {{runCommand}} from {{TestHDFSConcat}}.
Some mtimes and atimes are lost when edit logs are replayed
---
Key: HDFS-2041
URL: https://issues.apache.org/jira/browse/HDFS-2041
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Fix For: 0.23.0
Attachments: hdfs-2041.txt, hdfs-2041.txt
The refactoring in HDFS-2003 allowed findbugs to expose two potential bugs:
- the atime field logged with OP_MKDIR is unused
- the timestamp field logged with OP_CONCAT_DELETE is unused
The concat issue is definitely real. The atime for MKDIR might always be
identical to mtime in that case, in which case it could be ignored.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2041) Some mtimes and atimes are lost when edit logs are replayed
[ https://issues.apache.org/jira/browse/HDFS-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13046931#comment-13046931 ] Hadoop QA commented on HDFS-2041: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481995/hdfs-2041.txt against trunk revision 1134124. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/758//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/758//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/758//console This message is automatically generated. Some mtimes and atimes are lost when edit logs are replayed --- Key: HDFS-2041 URL: https://issues.apache.org/jira/browse/HDFS-2041 Project: Hadoop HDFS Issue Type: Bug Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Fix For: 0.23.0 Attachments: hdfs-2041.txt, hdfs-2041.txt The refactoring in HDFS-2003 allowed findbugs to expose two potential bugs: - the atime field logged with OP_MKDIR is unused - the timestamp field logged with OP_CONCAT_DELETE is unused The concat issue is definitely real. The atime for MKDIR might always be identical to mtime in that case, in which case it could be ignored. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
