[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-11-01 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141126#comment-13141126
 ] 

Hudson commented on HDFS-2065:
--

Integrated in Hadoop-Hdfs-trunk #850 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/850/])
HDFS-2065. Add null checks in DFSClient.getFileChecksum(..).  Contributed 
by Uma Maheswara Rao G

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195731
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java


 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch, HDFS-2065.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-11-01 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141160#comment-13141160
 ] 

Hudson commented on HDFS-2065:
--

Integrated in Hadoop-Mapreduce-trunk #884 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/884/])
HDFS-2065. Add null checks in DFSClient.getFileChecksum(..).  Contributed 
by Uma Maheswara Rao G

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195731
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java


 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch, HDFS-2065.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Uma Maheswara Rao G (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140528#comment-13140528
 ] 

Uma Maheswara Rao G commented on HDFS-2065:
---

updated patch for 20 security!

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Tsz Wo (Nicholas), SZE (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140563#comment-13140563
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2065:
--

+1 Patch looks good.  Thanks!

One nite: could you put {{locatedblocks = blockLocations.getLocatedBlocks();}} 
in one line?

Although getLocatedBlocks() won't return null in trunk, could you also post a 
similar patch for trunk?  It is good to check null and your patch also adds a 
test.

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Uma Maheswara Rao G (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140579#comment-13140579
 ] 

Uma Maheswara Rao G commented on HDFS-2065:
---

Thanks a lot for the review!
Fixed the nits.

I will post the patch for trunk as well.

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Hadoop QA (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140591#comment-13140591
 ] 

Hadoop QA commented on HDFS-2065:
-

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12501679/HDFS-2065-20.205Security.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 7 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1506//console

This message is automatically generated.

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Hadoop QA (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140662#comment-13140662
 ] 

Hadoop QA commented on HDFS-2065:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501686/HDFS-2065.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 7 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed these unit tests:
  org.apache.hadoop.hdfs.TestFileAppend2
  org.apache.hadoop.hdfs.TestBalancerBandwidth
  org.apache.hadoop.cli.TestHDFSCLI

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1507//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1507//console

This message is automatically generated.

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch, HDFS-2065.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140733#comment-13140733
 ] 

Hudson commented on HDFS-2065:
--

Integrated in Hadoop-Hdfs-0.23-Commit #118 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/118/])
svn merge -c 1195731 from trunk for HDFS-2065.

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195736
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java


 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch, HDFS-2065.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140732#comment-13140732
 ] 

Hudson commented on HDFS-2065:
--

Integrated in Hadoop-Hdfs-trunk-Commit #1287 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1287/])
HDFS-2065. Add null checks in DFSClient.getFileChecksum(..).  Contributed 
by Uma Maheswara Rao G

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195731
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java


 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch, HDFS-2065.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140735#comment-13140735
 ] 

Hudson commented on HDFS-2065:
--

Integrated in Hadoop-Common-0.23-Commit #117 (See 
[https://builds.apache.org/job/Hadoop-Common-0.23-Commit/117/])
svn merge -c 1195731 from trunk for HDFS-2065.

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195736
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java


 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch, HDFS-2065.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140738#comment-13140738
 ] 

Hudson commented on HDFS-2065:
--

Integrated in Hadoop-Common-trunk-Commit #1211 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1211/])
HDFS-2065. Add null checks in DFSClient.getFileChecksum(..).  Contributed 
by Uma Maheswara Rao G

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195731
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java


 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch, HDFS-2065.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-31 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140775#comment-13140775
 ] 

Hudson commented on HDFS-2065:
--

Integrated in Hadoop-Mapreduce-trunk-Commit #1237 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1237/])
HDFS-2065. Add null checks in DFSClient.getFileChecksum(..).  Contributed 
by Uma Maheswara Rao G

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195731
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java


 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Uma Maheswara Rao G
 Fix For: 0.20.205.1, 0.20.206.0, 0.23.0, 0.24.0

 Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, 
 HDFS-2065-20.205Security.patch, HDFS-2065.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-10-29 Thread Uma Maheswara Rao G (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139159#comment-13139159
 ] 

Uma Maheswara Rao G commented on HDFS-2065:
---

Bharath,

There are some more scenarios for getBlockLocations returning null values. i.e, 
when we call getFileCheckSum on non existing files or directories, it will 
throw NullPointerException. These two conditions handled in HDFS-2509

 I think we need to clean some places, where it is checking for null values 
from getBlockLocations.
See the code below from NameNodeFsck

{code}
LocatedBlocks blocks = namenode.getNamesystem().getBlockLocations(path, 0,
fileLen, false, false);
if (blocks == null) { // the file is deleted
  return;
}
{code}

Also can you please provide one Unit test for this scenario, which should 
illustrate that, when inode.getBlocks() will return null?

Thanks
Uma

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
 Fix For: 0.23.0

 Attachments: HDFS-2065-1.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-09-23 Thread Laxman (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113318#comment-13113318
 ] 

Laxman commented on HDFS-2065:
--

Hi Bharath,

I assumed this may happen when we create an empty file and make a call to 
getFileChecksum. But that doesn't seems to be the case. Even in empty file 
scenario this call doesn't throw any NPE.

Can you please provide the scenario or stack trace for this. That will be 
helpful to reproduce and provide the correct fix.

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
 Fix For: 0.23.0

 Attachments: HDFS-2065-1.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-08-22 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088600#comment-13088600
 ] 

Hadoop QA commented on HDFS-2065:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12483562/HDFS-2065-1.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1139//console

This message is automatically generated.

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
 Fix For: 0.23.0

 Attachments: HDFS-2065-1.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-08-22 Thread Tsz Wo (Nicholas), SZE (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088604#comment-13088604
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2065:
--

Hi Bharath, I tried to re-test the patch but it did not apply anymore.  Could 
you update it?


 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
 Fix For: 0.23.0

 Attachments: HDFS-2065-1.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-08-22 Thread Bharath Mundlapudi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088848#comment-13088848
 ] 

Bharath Mundlapudi commented on HDFS-2065:
--

Ok, I will recheck this. 

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
 Fix For: 0.23.0

 Attachments: HDFS-2065-1.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum

2011-07-06 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13060939#comment-13060939
 ] 

Hadoop QA commented on HDFS-2065:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12483562/HDFS-2065-1.patch
  against trunk revision 1143147.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed these core unit tests:


-1 contrib tests.  The patch failed contrib unit tests.

+1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/886//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/886//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/886//console

This message is automatically generated.

 Fix NPE in DFSClient.getFileChecksum
 

 Key: HDFS-2065
 URL: https://issues.apache.org/jira/browse/HDFS-2065
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
 Fix For: 0.23.0

 Attachments: HDFS-2065-1.patch


 The following code can throw NPE if callGetBlockLocations returns null.
 If server returns null 
 {code}
 ListLocatedBlock locatedblocks
 = callGetBlockLocations(namenode, src, 0, 
 Long.MAX_VALUE).getLocatedBlocks();
 {code}
 The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira