[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[ https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251850#comment-13251850 ] Ravi Prakash commented on HDFS-2119: Hi Mahadev! I agree! It doesn't make much sense to have different version strings for different modules if they have all been checked out from the same repository. We have too many modules to do that for each and every one. Should the fix be to have one single hash value to verify all the source (common+hdfs+mapreduce) that is in the root directory? > "hdfs version" should print out information similar to what "hadoop version" > prints out > --- > > Key: HDFS-2119 > URL: https://issues.apache.org/jira/browse/HDFS-2119 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.24.0 > > Attachments: HDFS-2119.1.patch, HDFS-2119.2.patch, HDFS-2119.3.patch > > > Implement version in hdfs CLI -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[ https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129909#comment-13129909 ] Mahadev konar commented on HDFS-2119: - @ravi, Can we not do this using shared version for all the 3 common/hdfs/mapred. I need to look into what the new tar assembly in hadoop-dist module is, but I think we could probably just calculate the version somewhere common and use it in hdfs/common/mapred. Will update after looking into the the poms. > "hdfs version" should print out information similar to what "hadoop version" > prints out > --- > > Key: HDFS-2119 > URL: https://issues.apache.org/jira/browse/HDFS-2119 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 0.23.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash > Fix For: 0.23.0 > > Attachments: HDFS-2119.1.patch, HDFS-2119.2.patch, HDFS-2119.3.patch > > > Implement version in hdfs CLI -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[
https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123841#comment-13123841
]
Ravi Prakash commented on HDFS-2119:
This patch applies on branch-0.23. I ran test-patch on my local machine and
this is what I got
{noformat}
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version )
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
{noformat}
> "hdfs version" should print out information similar to what "hadoop version"
> prints out
> ---
>
> Key: HDFS-2119
> URL: https://issues.apache.org/jira/browse/HDFS-2119
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.23.0
>Reporter: Ravi Prakash
>Assignee: Ravi Prakash
> Fix For: 0.23.0
>
> Attachments: HDFS-2119.1.patch, HDFS-2119.2.patch, HDFS-2119.3.patch
>
>
> Implement version in hdfs CLI
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[ https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123807#comment-13123807 ] Hadoop QA commented on HDFS-2119: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12498376/HDFS-2119.3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1356//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1356//console This message is automatically generated. > "hdfs version" should print out information similar to what "hadoop version" > prints out > --- > > Key: HDFS-2119 > URL: https://issues.apache.org/jira/browse/HDFS-2119 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 0.22.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Minor > Fix For: 0.22.0 > > Attachments: HDFS-2119.1.patch, HDFS-2119.2.patch, HDFS-2119.3.patch > > > Implement version in hdfs -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[ https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099320#comment-13099320 ] Ravi Prakash commented on HDFS-2119: YARN had to add the exact same thing. https://issues.apache.org/jira/browse/MAPREDUCE-2587 So this method seems acceptable. After the project unsplit do we really need different version strings though? If yes can someone please commit this? If no, can someone please mark this JIRA as "won't Fix" > "hdfs version" should print out information similar to what "hadoop version" > prints out > --- > > Key: HDFS-2119 > URL: https://issues.apache.org/jira/browse/HDFS-2119 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 0.22.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Minor > Fix For: 0.22.0 > > Attachments: HDFS-2119.1.patch, HDFS-2119.2.patch > > > Implement version in hdfs -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[
https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063435#comment-13063435
]
Ravi Prakash commented on HDFS-2119:
I tried reducing the duplicated code, but unfortunately its tough.
1. If I try to use common's VersionInfo.java to accept an argument for the name
of the package whose annotation would be read, I would have to call {noformat}
Class myClass = ClassLoader.getSystemClassLoader().loadClass(args[0]);
version =
myClass.getPackage().getAnnotation(HdfsVersionAnnotation.class);
{noformat} and HdfsVersionAnnotation cannot defined in common.
2. Since I can't extend annotations, HdfsVersionAnnotation can't be extended
from HadoopVersionAnnotation
3. If I were to write create HadoopVersionAnnotation from
hdfs/src/saveVersion.sh , there'd be ambiguity in the package info.
Can anyone suggest a way I can reduce the duplicated code? Or should I create a
properties file? Any suggestions anyone?
> "hdfs version" should print out information similar to what "hadoop version"
> prints out
> ---
>
> Key: HDFS-2119
> URL: https://issues.apache.org/jira/browse/HDFS-2119
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ravi Prakash
>Assignee: Ravi Prakash
>Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-2119.1.patch, HDFS-2119.2.patch
>
>
> Implement version in hdfs
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[ https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061263#comment-13061263 ] Ravi Prakash commented on HDFS-2119: Hi! Can someone please review and commit this patch? > "hdfs version" should print out information similar to what "hadoop version" > prints out > --- > > Key: HDFS-2119 > URL: https://issues.apache.org/jira/browse/HDFS-2119 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 0.22.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Minor > Fix For: 0.22.0 > > Attachments: HDFS-2119.1.patch, HDFS-2119.2.patch > > > Implement version in hdfs -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[ https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058809#comment-13058809 ] Hadoop QA commented on HDFS-2119: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484920/HDFS-2119.2.patch against trunk revision 1141767. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/876//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/876//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/876//console This message is automatically generated. > "hdfs version" should print out information similar to what "hadoop version" > prints out > --- > > Key: HDFS-2119 > URL: https://issues.apache.org/jira/browse/HDFS-2119 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 0.22.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Minor > Fix For: 0.22.0 > > Attachments: HDFS-2119.1.patch, HDFS-2119.2.patch > > > Implement version in hdfs -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[ https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058066#comment-13058066 ] Hadoop QA commented on HDFS-2119: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484821/HDFS-2119.1.patch against trunk revision 1141658. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/873//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/873//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/873//console This message is automatically generated. > "hdfs version" should print out information similar to what "hadoop version" > prints out > --- > > Key: HDFS-2119 > URL: https://issues.apache.org/jira/browse/HDFS-2119 > Project: Hadoop HDFS > Issue Type: Improvement >Affects Versions: 0.22.0 >Reporter: Ravi Prakash >Assignee: Ravi Prakash >Priority: Minor > Fix For: 0.22.0 > > Attachments: HDFS-2119.1.patch > > > Implement version in hdfs -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2119) "hdfs version" should print out information similar to what "hadoop version" prints out
[
https://issues.apache.org/jira/browse/HDFS-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058014#comment-13058014
]
Ravi Prakash commented on HDFS-2119:
Courtesy Arpit Gupta
{quote}in 20 we could use the hadoop version command to determine what version
and checksum of the hadoop code
in .next hadoop version command only lists the info for the common but not for
hdfs and mapred.
Can we add the appropriate version command to hdfs and mapred or better yet
display the version of hdfs and mapred when
hadoop version command is issued.{quote}
> "hdfs version" should print out information similar to what "hadoop version"
> prints out
> ---
>
> Key: HDFS-2119
> URL: https://issues.apache.org/jira/browse/HDFS-2119
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 0.22.0
>Reporter: Ravi Prakash
>Assignee: Ravi Prakash
>Priority: Minor
> Fix For: 0.22.0
>
>
> Implement version in hdfs
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
