[jira] [Commented] (HDFS-2162) Merge NameNode roles into NodeType.
[ https://issues.apache.org/jira/browse/HDFS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201680#comment-13201680 ] Aaron T. Myers commented on HDFS-2162: -- Suresh, any update on this? Merge NameNode roles into NodeType. --- Key: HDFS-2162 URL: https://issues.apache.org/jira/browse/HDFS-2162 Project: Hadoop HDFS Issue Type: Sub-task Components: ha, name-node Affects Versions: 0.23.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Priority: Minor Currently Namenode has {{NamenodeRole}} with roles NAMENODE, BACKUP and CHECKPOINT. {{NodeType}} has node types NAME_NODE and DATA_NODE. Merge NamenodeRole into NodeType. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2162) Merge NameNode roles into NodeType.
[ https://issues.apache.org/jira/browse/HDFS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188261#comment-13188261 ] Tsz Wo (Nicholas), SZE commented on HDFS-2162: -- NodeType is used in Storage and Upgrade while NamenodeRole is used in BackupNode. It does not make sense to pass DATA_NODE to BackupNode and, similarly, it does not make sense to pass BACKUP/CHECKPOINT to Storage. Thus, it may be better to keep two enums. BTW, the enum names do sound confusing. How about renaming NodeType to StorageType. Merge NameNode roles into NodeType. --- Key: HDFS-2162 URL: https://issues.apache.org/jira/browse/HDFS-2162 Project: Hadoop HDFS Issue Type: Sub-task Components: ha, name-node Affects Versions: 0.23.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Priority: Minor Currently Namenode has {{NamenodeRole}} with roles NAMENODE, BACKUP and CHECKPOINT. {{NodeType}} has node types NAME_NODE and DATA_NODE. Merge NamenodeRole into NodeType. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2162) Merge NameNode roles into NodeType.
[ https://issues.apache.org/jira/browse/HDFS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172614#comment-13172614 ] Todd Lipcon commented on HDFS-2162: --- Suresh, are you still planning on working on this? Merge NameNode roles into NodeType. --- Key: HDFS-2162 URL: https://issues.apache.org/jira/browse/HDFS-2162 Project: Hadoop HDFS Issue Type: Sub-task Components: ha, name-node Affects Versions: 0.23.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Priority: Minor Currently Namenode has {{NamenodeRole}} with roles NAMENODE, BACKUP and CHECKPOINT. {{NodeType}} has node types NAME_NODE and DATA_NODE. Merge NamenodeRole into NodeType. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2162) Merge NameNode roles into NodeType.
[ https://issues.apache.org/jira/browse/HDFS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172786#comment-13172786 ] Suresh Srinivas commented on HDFS-2162: --- Konstantin had expressed his reservation about this change. If most of you feel this is is a good idea (I feel it is), I can work on this. So post your comments. Merge NameNode roles into NodeType. --- Key: HDFS-2162 URL: https://issues.apache.org/jira/browse/HDFS-2162 Project: Hadoop HDFS Issue Type: Sub-task Components: ha, name-node Affects Versions: 0.23.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Priority: Minor Currently Namenode has {{NamenodeRole}} with roles NAMENODE, BACKUP and CHECKPOINT. {{NodeType}} has node types NAME_NODE and DATA_NODE. Merge NamenodeRole into NodeType. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2162) Merge NameNode roles into NodeType.
[ https://issues.apache.org/jira/browse/HDFS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172932#comment-13172932 ] Aaron T. Myers commented on HDFS-2162: -- I'm personally in favor of the change. It's certainly not strictly necessary, but seems like a nice simplification. I don't think the current terminology is well-known to users, as these are really internal enums within HDFS. Merge NameNode roles into NodeType. --- Key: HDFS-2162 URL: https://issues.apache.org/jira/browse/HDFS-2162 Project: Hadoop HDFS Issue Type: Sub-task Components: ha, name-node Affects Versions: 0.23.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Priority: Minor Currently Namenode has {{NamenodeRole}} with roles NAMENODE, BACKUP and CHECKPOINT. {{NodeType}} has node types NAME_NODE and DATA_NODE. Merge NamenodeRole into NodeType. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2162) Merge NameNode roles into NodeType.
[ https://issues.apache.org/jira/browse/HDFS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069870#comment-13069870 ] Konstantin Shvachko commented on HDFS-2162: --- I think this an unnecessary code change, which is induced by unnecessary attempt to change current terminology. Merge NameNode roles into NodeType. --- Key: HDFS-2162 URL: https://issues.apache.org/jira/browse/HDFS-2162 Project: Hadoop HDFS Issue Type: Sub-task Components: name-node Affects Versions: 0.23.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Priority: Minor Currently Namenode has {{NamenodeRole}} with roles NAMENODE, BACKUP and CHECKPOINT. {{NodeType}} has node types NAME_NODE and DATA_NODE. Merge NamenodeRole into NodeType. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira