[jira] [Commented] (HDFS-2320) Make merged protocol changes from 0.20-append to 0.20-security compatible with previous releases.
[ https://issues.apache.org/jira/browse/HDFS-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100801#comment-13100801 ] Jitendra Nath Pandey commented on HDFS-2320: +1. The patch looks good to me. > Make merged protocol changes from 0.20-append to 0.20-security compatible > with previous releases. > - > > Key: HDFS-2320 > URL: https://issues.apache.org/jira/browse/HDFS-2320 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, hdfs client, name-node >Affects Versions: 0.20.205.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Fix For: 0.20.205.0 > > Attachments: HDFS-2320.patch, HDFS-2320.patch > > > 0.20-append changes have been merged to 0.20-security. The merge has changes > to version numbers in several protocols. This jira makes the protocol changes > compatible with older release, allowing clients running older version to talk > to server running 205 version and clients running 205 version talk to older > servers running 203, 204. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2320) Make merged protocol changes from 0.20-append to 0.20-security compatible with previous releases.
[ https://issues.apache.org/jira/browse/HDFS-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099677#comment-13099677 ] Suresh Srinivas commented on HDFS-2320: --- I did the following manual test TestDFSIO write and read tests: # From 204 client against 205 server with my change. # From 205 client against 204 server Both tests passed. Without my patch I see version mismatch failure. > Make merged protocol changes from 0.20-append to 0.20-security compatible > with previous releases. > - > > Key: HDFS-2320 > URL: https://issues.apache.org/jira/browse/HDFS-2320 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, hdfs client, name-node >Affects Versions: 0.20.205.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Fix For: 0.20.205.0 > > Attachments: HDFS-2320.patch > > > 0.20-append changes have been merged to 0.20-security. The merge has changes > to version numbers in several protocols. This jira makes the protocol changes > compatible with older release, allowing clients running older version to talk > to server running 205 version and clients running 205 version talk to older > servers running 203, 204. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2320) Make merged protocol changes from 0.20-append to 0.20-security compatible with previous releases.
[ https://issues.apache.org/jira/browse/HDFS-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099646#comment-13099646 ] Suresh Srinivas commented on HDFS-2320: --- I plan to do that testing manually. Thanks for the validation Todd. > Make merged protocol changes from 0.20-append to 0.20-security compatible > with previous releases. > - > > Key: HDFS-2320 > URL: https://issues.apache.org/jira/browse/HDFS-2320 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, hdfs client, name-node >Affects Versions: 0.20.205.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Fix For: 0.20.205.0 > > Attachments: HDFS-2320.patch > > > 0.20-append changes have been merged to 0.20-security. The merge has changes > to version numbers in several protocols. This jira makes the protocol changes > compatible with older release, allowing clients running older version to talk > to server running 205 version and clients running 205 version talk to older > servers running 203, 204. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2320) Make merged protocol changes from 0.20-append to 0.20-security compatible with previous releases.
[ https://issues.apache.org/jira/browse/HDFS-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099601#comment-13099601 ] Todd Lipcon commented on HDFS-2320: --- Your logic seems reasonable. Have you tested this somehow? eg running a TestDFSIO with the new client pointed at the old cluster and killing a node or two while it's going? And vice versa? > Make merged protocol changes from 0.20-append to 0.20-security compatible > with previous releases. > - > > Key: HDFS-2320 > URL: https://issues.apache.org/jira/browse/HDFS-2320 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, hdfs client, name-node >Affects Versions: 0.20.205.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Fix For: 0.20.205.0 > > Attachments: HDFS-2320.patch > > > 0.20-append changes have been merged to 0.20-security. The merge has changes > to version numbers in several protocols. This jira makes the protocol changes > compatible with older release, allowing clients running older version to talk > to server running 205 version and clients running 205 version talk to older > servers running 203, 204. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2320) Make merged protocol changes from 0.20-append to 0.20-security compatible with previous releases.
[ https://issues.apache.org/jira/browse/HDFS-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099073#comment-13099073 ] Suresh Srinivas commented on HDFS-2320: --- h2. 0.20-append changes h3. ClientProtocol.java - version changed from 61 to 63 # Added boolean ClientProtocol#recoverLease(String src, String clientName). DistributedFileSystem#recoverLease() exposes this method to Applications # Added LocatedBlock addBlock(String src, String clientName, DatanodeInfo[] excludedNodes) *Compatibility* # recoverLease() - Only used by HBase current. HBase currently checks for existence of this method before calling it. No backward compatibility issues. # addBlock() - DFSClient tracks the support for this method using a flag serverSupportsHDFS630. The flag is set to false on getting exception from server. No backward compatibility issue. h3. DatanodeProtocol.java - version changed from 25 to 26 Changed method nextGenerationStamp(Block ) -> nextGenerationStamp(Block, boolean) *Compatibility* This method is used only by Datanode. Since the whole cluster is upgraded, datanodes will run newer version of the protocol. This does not affect client compatibility, as the client does not use this RPC call. h3. ClientDatanodeProtocol.java - version changed from 4 to 5 Added a new method getBlockInfo(Block block) used by the client. *Compatibility* When new client talks to old server, to read a file that is being written to, this will result in debug logs that print this exception. *Required change* Add a flag in DFSClient to detect no support for this method and handle it accordingly. This avoids having to make a method call all the way to the server, catch an exception and print an exception. h3. DataTransferProtocol.java - version changed from 17 to 19 The changes in this are compatible. The version change is unnecessary. Given that the protocol changes does not affect the client, I propose reverting the changes to version number in the protocols. > Make merged protocol changes from 0.20-append to 0.20-security compatible > with previous releases. > - > > Key: HDFS-2320 > URL: https://issues.apache.org/jira/browse/HDFS-2320 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, hdfs client, name-node >Affects Versions: 0.20.205.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Fix For: 0.20.205.0 > > > 0.20-append changes have been merged to 0.20-security. The merge has changes > to version numbers in several protocols. This jira makes the protocol changes > compatible with older release, allowing clients running older version to talk > to server running 205 version and clients running 205 version talk to older > servers running 203, 204. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
