[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137106#comment-13137106 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Mapreduce-0.23-Build #64 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/64/]) svn merge -c 1171136 from trunk for HDFS-2333. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189411 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.20.206.0, 0.23.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137041#comment-13137041 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Hdfs-0.23-Build #52 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/52/]) svn merge -c 1171136 from trunk for HDFS-2333. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189411 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.20.206.0, 0.23.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136339#comment-13136339 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Mapreduce-0.23-Commit #57 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/57/]) svn merge -c 1171136 from trunk for HDFS-2333. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189411 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.20.206.0, 0.23.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136283#comment-13136283 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Common-0.23-Commit #58 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/58/]) svn merge -c 1171136 from trunk for HDFS-2333. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189411 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.20.206.0, 0.23.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136286#comment-13136286 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Hdfs-0.23-Commit #58 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/58/]) svn merge -c 1171136 from trunk for HDFS-2333. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189411 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.20.206.0, 0.23.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106052#comment-13106052 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Mapreduce-trunk #832 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/832/]) HDFS-2333. Change DFSOutputStream back to package private, otherwise, there are two SC_START_IN_CTOR findbugs warnings. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171136 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106034#comment-13106034 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Hdfs-trunk #802 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/802/]) HDFS-2333. Change DFSOutputStream back to package private, otherwise, there are two SC_START_IN_CTOR findbugs warnings. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171136 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105463#comment-13105463 ] Hadoop QA commented on HDFS-2333: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494634/h2333_20110915.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.server.datanode.TestReplicasMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1252//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1252//console This message is automatically generated. > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105438#comment-13105438 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Mapreduce-trunk-Commit #905 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/905/]) HDFS-2333. Change DFSOutputStream back to package private, otherwise, there are two SC_START_IN_CTOR findbugs warnings. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171136 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.20.205.0, 0.24.0 > > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105435#comment-13105435 ] Tsz Wo (Nicholas), SZE commented on HDFS-2333: -- I should mention that the two SC_START_IN_CTOR findbugs warnings were due to starting a thread in the constructors of DFSOutputStream. The code starting a thread was there for a long time. In HDFS-2284, DFSOutputStream was changed from package private to public but, surprisingly, the change triggered the findbugs warnings. Even DFSOutputStream is package private, the class could still be extended and the same problem could occur. The real fix is not to starting a thread in the constructors. In this issue, DFSOutputStream is changed back to package private. I have committed this. > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105432#comment-13105432 ] Hadoop QA commented on HDFS-2333: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494636/h2333_20110915_0.20s.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1254//console This message is automatically generated. > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105431#comment-13105431 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Hdfs-trunk-Commit #970 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/970/]) HDFS-2333. Change DFSOutputStream back to package private, otherwise, there are two SC_START_IN_CTOR findbugs warnings. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171136 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105430#comment-13105430 ] Hudson commented on HDFS-2333: -- Integrated in Hadoop-Common-trunk-Commit #893 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/893/]) HDFS-2333. Change DFSOutputStream back to package private, otherwise, there are two SC_START_IN_CTOR findbugs warnings. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171136 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/resources/DatanodeWebHdfsMethods.java > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch, h2333_20110915.patch, h2333_20110915_0.20s.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105221#comment-13105221 ] Ivan Kelly commented on HDFS-2333: -- Looks good to me. +1 Perhaps add to the DFSClient#append javadoc that null is acceptable for the 3rd and 4th parameter. > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104838#comment-13104838 ] Hadoop QA commented on HDFS-2333: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494463/h2333_20110914b.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.TestDFSRollback org.apache.hadoop.hdfs.server.datanode.TestReplicasMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1249//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1249//console This message is automatically generated. > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104759#comment-13104759 ] Hadoop QA commented on HDFS-2333: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494450/h2333_20110914.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.namenode.TestListCorruptFileBlocks org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1246//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1246//console This message is automatically generated. > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch, > h2333_20110914b.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104599#comment-13104599 ] Hadoop QA commented on HDFS-2333: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494450/h2333_20110914.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.server.datanode.TestReplicasMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1242//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1242//console This message is automatically generated. > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
[ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104546#comment-13104546 ] Ivan Kelly commented on HDFS-2333: -- Ah, better if you just leave it private i think. I assumed you needed it public so I just changed it to final. Package private is better though. > HDFS-2284 introduced 2 findbugs warnings on trunk > - > > Key: HDFS-2333 > URL: https://issues.apache.org/jira/browse/HDFS-2333 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: HDFS-2333.diff, h2333_20110914.patch > > > When HDFS-2284 was submitted it made DFSOutputStream public which triggered > two SC_START_IN_CTOR findbug warnings. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
