[jira] [Commented] (HDFS-2517) Protobuf - Add protocol service for JournalProtocol
[ https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155121#comment-13155121 ] Hudson commented on HDFS-2517: -- Integrated in Hadoop-Mapreduce-trunk #905 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/905/]) HDFS-2517. Add protobuf service for JounralProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1204544 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/HdfsProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/JournalProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/JournalProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/hdfs.proto Protobuf - Add protocol service for JournalProtocol --- Key: HDFS-2517 URL: https://issues.apache.org/jira/browse/HDFS-2517 Project: Hadoop HDFS Issue Type: New Feature Components: name-node Affects Versions: 0.23.0, 0.24.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Fix For: 0.24.0 Attachments: HDFS-2517.txt, HDFS-2517.txt This jira adds protobuf service for implementing journal protocol using protocol buffers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2517) Protobuf - Add protocol service for JournalProtocol
[ https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154248#comment-13154248 ] Suresh Srinivas commented on HDFS-2517: --- Test failure is unrelated. Tests not included, as this adds just proto definitions. Existing tests will test this functionality on switching to protobuf. Protobuf - Add protocol service for JournalProtocol --- Key: HDFS-2517 URL: https://issues.apache.org/jira/browse/HDFS-2517 Project: Hadoop HDFS Issue Type: New Feature Components: name-node Affects Versions: 0.23.0, 0.24.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Attachments: HDFS-2517.txt, HDFS-2517.txt This jira adds protobuf service for implementing journal protocol using protocol buffers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2517) Protobuf - Add protocol service for JournalProtocol
[ https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154258#comment-13154258 ] Hudson commented on HDFS-2517: -- Integrated in Hadoop-Hdfs-trunk-Commit #1374 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1374/]) HDFS-2517. Add protobuf service for JounralProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1204544 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/HdfsProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/JournalProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/JournalProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/hdfs.proto Protobuf - Add protocol service for JournalProtocol --- Key: HDFS-2517 URL: https://issues.apache.org/jira/browse/HDFS-2517 Project: Hadoop HDFS Issue Type: New Feature Components: name-node Affects Versions: 0.23.0, 0.24.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Fix For: 0.24.0 Attachments: HDFS-2517.txt, HDFS-2517.txt This jira adds protobuf service for implementing journal protocol using protocol buffers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2517) Protobuf - Add protocol service for JournalProtocol
[ https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154261#comment-13154261 ] Hudson commented on HDFS-2517: -- Integrated in Hadoop-Common-trunk-Commit #1301 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1301/]) HDFS-2517. Add protobuf service for JounralProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1204544 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/HdfsProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/JournalProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/JournalProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/hdfs.proto Protobuf - Add protocol service for JournalProtocol --- Key: HDFS-2517 URL: https://issues.apache.org/jira/browse/HDFS-2517 Project: Hadoop HDFS Issue Type: New Feature Components: name-node Affects Versions: 0.23.0, 0.24.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Fix For: 0.24.0 Attachments: HDFS-2517.txt, HDFS-2517.txt This jira adds protobuf service for implementing journal protocol using protocol buffers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2517) Protobuf - Add protocol service for JournalProtocol
[ https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154272#comment-13154272 ] Hudson commented on HDFS-2517: -- Integrated in Hadoop-Mapreduce-trunk-Commit #1324 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1324/]) HDFS-2517. Add protobuf service for JounralProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1204544 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/HdfsProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/JournalProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/JournalProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/hdfs.proto Protobuf - Add protocol service for JournalProtocol --- Key: HDFS-2517 URL: https://issues.apache.org/jira/browse/HDFS-2517 Project: Hadoop HDFS Issue Type: New Feature Components: name-node Affects Versions: 0.23.0, 0.24.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Fix For: 0.24.0 Attachments: HDFS-2517.txt, HDFS-2517.txt This jira adds protobuf service for implementing journal protocol using protocol buffers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2517) Protobuf - Add protocol service for JournalProtocol
[ https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154030#comment-13154030 ] Hadoop QA commented on HDFS-2517: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501850/HDFS-2517.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1591//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1591//console This message is automatically generated. Protobuf - Add protocol service for JournalProtocol --- Key: HDFS-2517 URL: https://issues.apache.org/jira/browse/HDFS-2517 Project: Hadoop HDFS Issue Type: New Feature Components: name-node Affects Versions: 0.23.0, 0.24.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Attachments: HDFS-2517.txt, HDFS-2517.txt This jira adds protobuf service for implementing journal protocol using protocol buffers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2517) Protobuf - Add protocol service for JournalProtocol
[ https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153279#comment-13153279 ] Jitendra Nath Pandey commented on HDFS-2517: +1 Protobuf - Add protocol service for JournalProtocol --- Key: HDFS-2517 URL: https://issues.apache.org/jira/browse/HDFS-2517 Project: Hadoop HDFS Issue Type: New Feature Components: name-node Affects Versions: 0.23.0, 0.24.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Attachments: HDFS-2517.txt, HDFS-2517.txt This jira adds protobuf service for implementing journal protocol using protocol buffers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2517) Protobuf - Add protocol service for JournalProtocol
[ https://issues.apache.org/jira/browse/HDFS-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140798#comment-13140798 ] Jitendra Nath Pandey commented on HDFS-2517: # In enum NamenodeRoleProto shouldn't the first constant should start with zero, because the corresponding java enum doesn't assign any values. # StartLogSegmentResponseProto is empty, does it make sense to define an empty proto message to be used for all void returning rpc's? Protobuf - Add protocol service for JournalProtocol --- Key: HDFS-2517 URL: https://issues.apache.org/jira/browse/HDFS-2517 Project: Hadoop HDFS Issue Type: New Feature Components: name-node Affects Versions: 0.23.0, 0.24.0 Reporter: Suresh Srinivas Assignee: Suresh Srinivas Attachments: HDFS-2517.txt This jira adds protobuf service for implementing journal protocol using protocol buffers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
