[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155120#comment-13155120 ] Hudson commented on HDFS-2518: -- Integrated in Hadoop-Mapreduce-trunk #905 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/905/]) HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155076#comment-13155076 ] Hudson commented on HDFS-2518: -- Integrated in Hadoop-Hdfs-trunk #871 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/871/]) HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154576#comment-13154576 ] Hudson commented on HDFS-2518: -- Integrated in Hadoop-Mapreduce-trunk-Commit #1330 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1330/]) HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154527#comment-13154527 ] Hudson commented on HDFS-2518: -- Integrated in Hadoop-Common-trunk-Commit #1307 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1307/]) HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154523#comment-13154523 ] Hudson commented on HDFS-2518: -- Integrated in Hadoop-Hdfs-trunk-Commit #1380 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1380/]) HDFS-2518. Add protobuf service for NamenodeProtocol. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204707 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/proto/NamenodeProtocolProtos.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/proto/NamenodeProtocol.proto > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154517#comment-13154517 ] Suresh Srinivas commented on HDFS-2518: --- Owen, HDFS-2578 is created to address your comment. > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154495#comment-13154495 ] Suresh Srinivas commented on HDFS-2518: --- Test failure TestViewFsHdfs is unrelated to this patch. Also this patch introduces protobuf definitions. It will be tested when protobuf mechanism is used for RPCs, using the existing tests. > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154490#comment-13154490 ] Suresh Srinivas commented on HDFS-2518: --- Owen, we have done this for several other patches. I will create another jira to get rid of them. > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154286#comment-13154286 ] Hadoop QA commented on HDFS-2518: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501858/HDFS-2518.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsHdfs +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1594//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1594//console This message is automatically generated. > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154275#comment-13154275 ] Owen O'Malley commented on HDFS-2518: - Please don't include the generated code in subversion. We already require protoc in order to compile Hadoop, so there isn't any need to avoid it here. > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153281#comment-13153281 ] Jitendra Nath Pandey commented on HDFS-2518: +1 > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt, HDFS-2518.txt, HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141430#comment-13141430 ] Suresh Srinivas commented on HDFS-2518: --- bq. GetBlockKeysRequestProto, GetTransactionIdRequestProto, EndCheckpointResponseProto are empty, can we replace them with a single empty proto? bq. Instead of StartCheckpointResponseProto, can we just use NamenodeCommandProto which is already defined? That applies to many response protos e.g. RegisterResponseProto could be replaced with NamenodeRegistrationProto. The reason is, the request and response could in the future change to include additional optional fields. > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2518) Protobuf - Add protobuf service for NamenodeProtocol
[ https://issues.apache.org/jira/browse/HDFS-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141381#comment-13141381 ] Jitendra Nath Pandey commented on HDFS-2518: # GetBlocksRequestProto should have DatanodeInfoProto. # GetBlockKeysRequestProto, GetTransactionIdRequestProto, EndCheckpointResponseProto are empty, can we replace them with a single empty proto? # Instead of StartCheckpointResponseProto, can we just use NamenodeCommandProto which is already defined? That applies to many response protos e.g. RegisterResponseProto could be replaced with NamenodeRegistrationProto. > Protobuf - Add protobuf service for NamenodeProtocol > > > Key: HDFS-2518 > URL: https://issues.apache.org/jira/browse/HDFS-2518 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.23.0, 0.24.0 >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas > Attachments: HDFS-2518.txt > > > This jira adds a protobuf service definition for NamenodeProtocol. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
