[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-09-28 Thread Matt Foley (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465905#comment-13465905
 ] 

Matt Foley commented on HDFS-2751:
--

merged to branch-1.1

 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1, 1.1.0

 Attachments: HDFS-2751.branch-1.patch, hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-07-24 Thread Brandon Li (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421921#comment-13421921
 ] 

Brandon Li commented on HDFS-2751:
--

I did teragen/terasort/teravalid with the branch-1 patch.

 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: HDFS-2751.branch-1.patch, hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-07-23 Thread Brandon Li (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420954#comment-13420954
 ] 

Brandon Li commented on HDFS-2751:
--

Uploaded patch to back port to branch-1.

 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: HDFS-2751.branch-1.patch, hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-20 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189686#comment-13189686
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Mapreduce-0.23-Commit #406 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/406/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233795
Files : 
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-20 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189701#comment-13189701
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Mapreduce-trunk-Commit #1579 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1579/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233796
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-20 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189765#comment-13189765
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Hdfs-trunk #931 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/931/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233796
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-20 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189777#comment-13189777
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Hdfs-0.23-Build #144 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/144/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233795
Files : 
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-20 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189789#comment-13189789
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Mapreduce-0.23-Build #166 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/166/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233795
Files : 
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-20 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189795#comment-13189795
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Mapreduce-trunk #964 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/964/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233796
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-19 Thread Hadoop QA (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189622#comment-13189622
 ] 

Hadoop QA commented on HDFS-2751:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12511219/hdfs-2751.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 javadoc.  The javadoc tool appears to have generated 21 warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 eclipse:eclipse.  The patch built with eclipse:eclipse.

-1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) 
warnings.

-1 release audit.  The applied patch generated 1 release audit warnings 
(more than the trunk's current 0 warnings).

-1 core tests.  The patch failed these unit tests:
  org.apache.hadoop.hdfs.TestLeaseRenewer

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1788//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1788//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1788//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1788//console

This message is automatically generated.

 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-19 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189668#comment-13189668
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Common-trunk-Commit #1560 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1560/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233796
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-19 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189670#comment-13189670
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Common-0.23-Commit #392 (See 
[https://builds.apache.org/job/Hadoop-Common-0.23-Commit/392/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233795
Files : 
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-19 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189673#comment-13189673
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Hdfs-trunk-Commit #1634 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1634/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233796
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-19 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189674#comment-13189674
 ] 

Hudson commented on HDFS-2751:
--

Integrated in Hadoop-Hdfs-0.23-Commit #383 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/383/])
HDFS-2751. Datanode may incorrectly drop OS cache behind reads even for 
short reads. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1233795
Files : 
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java


 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Fix For: 0.24.0, 0.23.1

 Attachments: hdfs-2751.txt, hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-04 Thread Todd Lipcon (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13179997#comment-13179997
 ] 

Todd Lipcon commented on HDFS-2751:
---

(thanks to JD Cryans for finding this one)

 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon

 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2751) Datanode drops OS cache behind reads even for short reads

2012-01-04 Thread Eli Collins (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13180058#comment-13180058
 ] 

Eli Collins commented on HDFS-2751:
---

+1 pending jenkins

 Datanode drops OS cache behind reads even for short reads
 -

 Key: HDFS-2751
 URL: https://issues.apache.org/jira/browse/HDFS-2751
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: data-node
Affects Versions: 0.23.0, 0.24.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
 Attachments: hdfs-2751.txt


 HDFS-2465 has some code which attempts to disable the drop cache behind 
 reads functionality when the reads are 256KB (eg HBase random access). But 
 this check was missing in the {{close()}} function, so it always drops cache 
 behind reads regardless of the size of the read. This hurts HBase random read 
 performance when this patch is enabled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira