[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448753#comment-13448753 ] Hudson commented on HDFS-2793: -- Integrated in Hadoop-Mapreduce-trunk #1187 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1187/]) HDFS-2793. Add an admin command to trigger an edit log roll. Contributed by Todd Lipcon. (Revision 1380982) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380982 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Fix For: 3.0.0, 2.2.0-alpha > > Attachments: hdfs-2793.txt, hdfs-2793.txt, hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448689#comment-13448689 ] Hudson commented on HDFS-2793: -- Integrated in Hadoop-Hdfs-trunk #1156 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1156/]) HDFS-2793. Add an admin command to trigger an edit log roll. Contributed by Todd Lipcon. (Revision 1380982) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380982 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Fix For: 3.0.0, 2.2.0-alpha > > Attachments: hdfs-2793.txt, hdfs-2793.txt, hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448500#comment-13448500 ] Hudson commented on HDFS-2793: -- Integrated in Hadoop-Mapreduce-trunk-Commit #2706 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2706/]) HDFS-2793. Add an admin command to trigger an edit log roll. Contributed by Todd Lipcon. (Revision 1380982) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380982 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Fix For: 3.0.0, 2.2.0-alpha > > Attachments: hdfs-2793.txt, hdfs-2793.txt, hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448473#comment-13448473 ] Hudson commented on HDFS-2793: -- Integrated in Hadoop-Hdfs-trunk-Commit #2745 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2745/]) HDFS-2793. Add an admin command to trigger an edit log roll. Contributed by Todd Lipcon. (Revision 1380982) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380982 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Fix For: 3.0.0, 2.2.0-alpha > > Attachments: hdfs-2793.txt, hdfs-2793.txt, hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448470#comment-13448470 ] Hudson commented on HDFS-2793: -- Integrated in Hadoop-Common-trunk-Commit #2682 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2682/]) HDFS-2793. Add an admin command to trigger an edit log roll. Contributed by Todd Lipcon. (Revision 1380982) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380982 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientNamenodeProtocol.proto * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Fix For: 3.0.0, 2.2.0-alpha > > Attachments: hdfs-2793.txt, hdfs-2793.txt, hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448422#comment-13448422 ] Hadoop QA commented on HDFS-2793: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543787/hdfs-2793.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3147//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3147//console This message is automatically generated. > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Attachments: hdfs-2793.txt, hdfs-2793.txt, hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448401#comment-13448401 ] Hadoop QA commented on HDFS-2793: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543780/hdfs-2793.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3146//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3146//console This message is automatically generated. > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Attachments: hdfs-2793.txt, hdfs-2793.txt, hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448383#comment-13448383 ] Aaron T. Myers commented on HDFS-2793: -- The latest patch looks good to me. +1 pending Jenkings. > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Attachments: hdfs-2793.txt, hdfs-2793.txt, hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[
https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448364#comment-13448364
]
Aaron T. Myers commented on HDFS-2793:
--
One nit, I think this should just be "ClientProtocol":
{code}
+ @Override // ClientNamenodeProtocol
{code}
> Add an admin command to trigger an edit log roll
>
>
> Key: HDFS-2793
> URL: https://issues.apache.org/jira/browse/HDFS-2793
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: name-node
>Affects Versions: 0.24.0
>Reporter: Aaron T. Myers
>Assignee: Todd Lipcon
> Attachments: hdfs-2793.txt, hdfs-2793.txt
>
>
> This seems like it would also be helpful outside of the context of HA, but
> especially so given that the standby can currently only read finalized log
> segments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448105#comment-13448105 ] Aaron T. Myers commented on HDFS-2793: -- bq. Is the 2NN's principal always considered a superuser? I think so, but just want to confirm. Pretty certain that's the case, yes. > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Attachments: hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448099#comment-13448099 ] Todd Lipcon commented on HDFS-2793: --- bq. It's certainly the case that arbitrary clients should be super users, but when would a non-super user node be calling this method? I think it should be safe to always check for super user privileges. Is the 2NN's principal always considered a superuser? I think so, but just want to confirm. bq. Should the rollEdits RPC be marked @Idempotent? I can't think of a case when calling it twice would be problematic. Makes sense. > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Attachments: hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[
https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448076#comment-13448076
]
Aaron T. Myers commented on HDFS-2793:
--
Patch looks pretty good to me. Just a few little comments:
# I don't understand why this "if(...)" is necessary:
{code}
if (isFromClient) {
checkSuperuserPrivilege();
}
{code}
It's certainly the case that arbitrary clients should be super users, but when
would a non-super user node be calling this method? I think it should be safe
to always check for super user privileges.
# Should the rollEdits RPC be marked {{@Idempotent}}? I can't think of a case
when calling it twice would be problematic.
> Add an admin command to trigger an edit log roll
>
>
> Key: HDFS-2793
> URL: https://issues.apache.org/jira/browse/HDFS-2793
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: name-node
>Affects Versions: 0.24.0
>Reporter: Aaron T. Myers
>Assignee: Todd Lipcon
> Attachments: hdfs-2793.txt
>
>
> This seems like it would also be helpful outside of the context of HA, but
> especially so given that the standby can currently only read finalized log
> segments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447518#comment-13447518 ] Hadoop QA commented on HDFS-2793: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543618/hdfs-2793.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3140//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3140//console This message is automatically generated. > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Todd Lipcon > Attachments: hdfs-2793.txt > > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
[ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221222#comment-13221222 ] Aaron T. Myers commented on HDFS-2793: -- Converted this to a top-level issue, since it's applicable outside of HA as well. > Add an admin command to trigger an edit log roll > > > Key: HDFS-2793 > URL: https://issues.apache.org/jira/browse/HDFS-2793 > Project: Hadoop HDFS > Issue Type: New Feature > Components: name-node >Affects Versions: 0.24.0 >Reporter: Aaron T. Myers >Assignee: Aaron T. Myers > > This seems like it would also be helpful outside of the context of HA, but > especially so given that the standby can currently only read finalized log > segments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
