[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622436#comment-14622436 ] Hudson commented on HDFS-2956: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #250 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/250/]) HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622373#comment-14622373 ] Hudson commented on HDFS-2956: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #240 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/240/]) HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622301#comment-14622301 ] Hudson commented on HDFS-2956: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2198 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2198/]) HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622291#comment-14622291 ] Hudson commented on HDFS-2956: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2179 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2179/]) HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622135#comment-14622135 ] Hudson commented on HDFS-2956: -- FAILURE: Integrated in Hadoop-trunk-Commit #8147 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8147/]) HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622132#comment-14622132 ] Hudson commented on HDFS-2956: -- FAILURE: Integrated in Hadoop-Yarn-trunk #982 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/982/]) HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622123#comment-14622123 ] Hudson commented on HDFS-2956: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #252 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/252/]) HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B)HDFS-2956. calling fetchdt without a --renewer argument throws NPE (Contributed by Vinayakumar B) (vinayakumarb: rev b48908033fcac7a4bd4313c1fd1457999fba08e1) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDelegationTokenFetcher.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Fix For: 2.8.0 > > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622083#comment-14622083
]
Hadoop QA commented on HDFS-2956:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 35s | Findbugs (version ) appears to
be broken on trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 48s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 46s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 34s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 44s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 35s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 9s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 160m 52s | Tests failed in hadoop-hdfs. |
| | | 203m 0s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestEncryptionZonesWithKMS |
| | hadoop.hdfs.TestLeaseRecovery2 |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12744653/HDFS-2956-04.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / d66302e |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11656/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11656/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11656/console |
This message was automatically generated.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Labels: BB2015-05-TBR
> Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch,
> HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch,
> HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622082#comment-14622082 ] Vinayakumar B commented on HDFS-2956: - Thanks for the reviews [~ajisakaa], I will commit the patch soon. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Labels: BB2015-05-TBR > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622078#comment-14622078 ] Akira AJISAKA commented on HDFS-2956: - +1 > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Labels: BB2015-05-TBR > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622046#comment-14622046 ] Vinayakumar B commented on HDFS-2956: - test failure unrelated > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Labels: BB2015-05-TBR > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, > HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622033#comment-14622033
]
Hadoop QA commented on HDFS-2956:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 16m 31s | Findbugs (version ) appears to
be broken on trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 8m 14s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 11s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 43s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 2m 42s | The patch appears to introduce 1
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 160m 20s | Tests failed in hadoop-hdfs. |
| | | 204m 28s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| Failed unit tests |
hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12744645/HDFS-8578-03.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 5214876 |
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11654/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11654/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11654/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11654/console |
This message was automatically generated.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Labels: BB2015-05-TBR
> Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch,
> HDFS-2956-04.patch, HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch,
> HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621588#comment-14621588
]
Akira AJISAKA commented on HDFS-2956:
-
Thanks [~vinayrpet] for creating the patch for branch-2. Mostly looks good to
me. I noticed there is a difference in the test between trunk and branch-2.
{code:title=branch-2}
// make sure we got back exactly the 1 token we expected
assertTrue(itr.hasNext());
assertNotNull("Token without renewer shouldn't be null", itr.next());
assertTrue(!itr.hasNext());
{code}
{code:title=trunk}
assertTrue("token not exist error", itr.hasNext());
assertNotNull("Token should be there without renewer", itr.next());
{code}
I'm thinking we can add {{assertTrue(!itr.hasNext())}} to the trunk as well.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Labels: BB2015-05-TBR
> Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch,
> HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621570#comment-14621570 ] Akira AJISAKA commented on HDFS-2956: - bq. Findbugs is not actually there. Not related to the patch. Filed HDFS-8749. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Labels: BB2015-05-TBR > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620639#comment-14620639 ] Vinayakumar B commented on HDFS-2956: - [~ajisakaa], Thanks for the reviews. Could you also take a look at the branch-2 patch? This is different in test. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Labels: BB2015-05-TBR > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620619#comment-14620619 ] Vinayakumar B commented on HDFS-2956: - Findbugs is not actually there. trunk test failures are not related. branch-2 checkstyles are also not related. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Labels: BB2015-05-TBR > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620451#comment-14620451
]
Hadoop QA commented on HDFS-2956:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 30s | Findbugs (version ) appears to
be broken on branch-2. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 6m 2s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 39s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 5s | The applied patch generated
40 new checkstyle issues (total was 0, now 40). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 11s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 2m 35s | The patch appears to introduce 1
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 1m 22s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 155m 58s | Tests passed in hadoop-hdfs.
|
| | | 194m 19s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12744457/HDFS-2956.branch-2.03.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | branch-2 / d17a7bb |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11647/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11647/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11647/console |
This message was automatically generated.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Labels: BB2015-05-TBR
> Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch,
> HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620346#comment-14620346
]
Hadoop QA commented on HDFS-2956:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 14s | Findbugs (version ) appears to
be broken on trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 35s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 32s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 35s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 2m 36s | The patch appears to introduce 1
new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 3s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 161m 49s | Tests failed in hadoop-hdfs. |
| | | 202m 59s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| Failed unit tests |
hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes |
| | hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes |
| | hadoop.hdfs.TestAppendSnapshotTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/1271/HDFS-2956.03.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 63d0365 |
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11645/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11645/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11645/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11645/console |
This message was automatically generated.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Labels: BB2015-05-TBR
> Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch,
> HDFS-2956.03.patch, HDFS-2956.branch-2.03.patch, HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620140#comment-14620140 ] Akira AJISAKA commented on HDFS-2956: - Thanks [~vinayrpet] for the clarification and creating the regression test. +1 pending Jenkins. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Labels: BB2015-05-TBR > Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, > HDFS-2956.03.patch, HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620058#comment-14620058
]
Hadoop QA commented on HDFS-2956:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12744434/HDFS-2956-02.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 63d0365 |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11644/console |
This message was automatically generated.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Labels: BB2015-05-TBR
> Attachments: HDFS-2956-01.patch, HDFS-2956-02.patch, HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619929#comment-14619929
]
Akira AJISAKA commented on HDFS-2956:
-
Hi [~vinayrpet], thank you for taking this issue. My concern is, when passing
empty string renewer to a request, the request will fail under any condition.
If the concern is true, it's better to fail fast by checking if {{--renewer}}
argument exists in {{DelegationTokenFetcher#main}}.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Labels: BB2015-05-TBR
> Attachments: HDFS-2956-01.patch, HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610653#comment-14610653 ] Vinayakumar B commented on HDFS-2956: - Test failures are unrelated to current patch. Those are related to HADOOP-12009. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 2.0.0-alpha, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinayakumar B > Labels: BB2015-05-TBR > Attachments: HDFS-2956-01.patch, HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Auto-Re: [jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
您的邮件已收到！谢谢！
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605677#comment-14605677
]
Hadoop QA commented on HDFS-2956:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 17m 50s | Pre-patch trunk has 1 extant
Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 39s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 12s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 17s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 160m 22s | Tests failed in hadoop-hdfs. |
| | | 206m 32s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.web.TestWebHdfsFileSystemContract |
| | hadoop.hdfs.TestHDFSFileSystemContract |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742491/HDFS-2956-01.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c815344 |
| Pre-patch Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/11528/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/11528/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/11528/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/11528/console |
This message was automatically generated.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Labels: BB2015-05-TBR
> Attachments: HDFS-2956-01.patch, HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354568#comment-14354568
]
Hadoop QA commented on HDFS-2956:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600339/HDFS-2956.patch
against trunk revision 47f7f18.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
org.apache.hadoop.hdfs.TestAppendSnapshotTruncate
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9811//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9811//console
This message is automatically generated.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinayakumar B
> Attachments: HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784843#comment-13784843 ] Aaron T. Myers commented on HDFS-2956: -- You actually can't safely downgrade a PB field from required to optional in a compatible fashion. If you did so, the side trying to deserialize a message that still has the field marked "required" will consider a message missing this field to be a malformed message. See the section on [this page|https://developers.google.com/protocol-buffers/docs/proto] entitled "Required is Forever." > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinay > Attachments: HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762769#comment-13762769 ] Vinay commented on HDFS-2956: - Hi [~atm], could you please take a look at the patch as you already aware of the issue..? Thanks > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0, 3.0.0 >Reporter: Todd Lipcon >Assignee: Vinay > Attachments: HDFS-2956.patch > > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752445#comment-13752445
]
Daryn Sharp commented on HDFS-2956:
---
I'm not a protobuf expert, but I think downgrading a required field to optional
is ok for compatibility but someone else should definitively comment.
Only nit is the condition {{renewer.toString() != null)}} is unnecessary
because it will never return null.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 0.24.0, 3.0.0
>Reporter: Todd Lipcon
>Assignee: Vinay
> Attachments: HDFS-2956.patch
>
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439538#comment-13439538 ] Daryn Sharp commented on HDFS-2956: --- Unfortunately I've been too consumed with other token work to double back to this jira... I can spare time to review if you want to take a stab at a patch. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon >Assignee: Daryn Sharp > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439154#comment-13439154 ] Aaron T. Myers commented on HDFS-2956: -- Hey Daryn, any update on this? > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon >Assignee: Daryn Sharp > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425861#comment-13425861
]
Raju commented on HDFS-2956:
Here we are defining the protocol message as
{code}
message GetDelegationTokenRequestProto {
required string renewer = 1;
}
{code}
based on some of the above comments I feel the renewer should be optional
(since null can be passed I mean we are not providing renewer).
Even with optional we will have the generated class with null check for
renewer, so I guess we can have null check for renewer like
{code}
if(renewer != null) {
GetDelegationTokenRequestProto req = GetDelegationTokenRequestProto
.newBuilder()
.setRenewer(renewer.toString())
.build();
} else {
GetDelegationTokenRequestProto req = GetDelegationTokenRequestProto
.newBuilder()
.build();
}
{code}
This should be possible since we are declaring the renewer optional, similarly
we can parse the message back at serverside translator.
Please correct me if I am wrong
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 0.24.0
>Reporter: Todd Lipcon
>Assignee: Daryn Sharp
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288744#comment-13288744 ] Aaron T. Myers commented on HDFS-2956: -- bq. I am leaning towards fixing it to be like it was befor +1 > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon >Assignee: Daryn Sharp > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288536#comment-13288536 ] Daryn Sharp commented on HDFS-2956: --- I am leaning towards fixing it to be like it was before, but wanted input before making the change. Does anyone else disagree? > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon >Assignee: Daryn Sharp > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287747#comment-13287747 ] Todd Lipcon commented on HDFS-2956: --- Seems to me (without a ton of expertise in this area of the code) that we should treat it as a bug in the PB-ification and restore the previous behavior of non-renewable tokens. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon >Assignee: Daryn Sharp > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287738#comment-13287738 ] Daryn Sharp commented on HDFS-2956: --- It's potentially more than a 1-liner. The NN used to generate (apparently by design) a non-renewable token if the renewer is null. The PB stuff broke the ability to pass a null renewer. OTOH, the hftp servlet defaults the renewer to the client's UGI when passed a null renewer. The quick and dirty answer is for the token fetcher to default the renewer to UGI's login user unless the renewer flag is explicitly provided. This breaks the ability to request a non-renewable hdfs token, but as mentioned earlier, PB broke that anyway. Or should the PB code be fixed to allow a null renewer once again, and perhaps for consistency change hftp to not default a null renewer to the client's UGI? > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon >Assignee: Daryn Sharp > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280185#comment-13280185 ] Daryn Sharp commented on HDFS-2956: --- I'll look into it. It's probably a 1-line fix. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278396#comment-13278396 ] Aaron T. Myers commented on HDFS-2956: -- Hey Daryn, any update here? I just bumped into this myself. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[ https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255725#comment-13255725 ] Daryn Sharp commented on HDFS-2956: --- If someone doesn't take this, I'll get to it in the next few days since I'm already touching tokens. > calling fetchdt without a --renewer argument throws NPE > --- > > Key: HDFS-2956 > URL: https://issues.apache.org/jira/browse/HDFS-2956 > Project: Hadoop HDFS > Issue Type: Bug > Components: security >Affects Versions: 0.24.0 >Reporter: Todd Lipcon > > If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument, > then it will throw a NullPointerException: > Exception in thread "main" java.lang.NullPointerException > at > org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830) > this is because getDelegationToken is being called with a null renewer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2956) calling fetchdt without a --renewer argument throws NPE
[
https://issues.apache.org/jira/browse/HDFS-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255720#comment-13255720
]
Daryn Sharp commented on HDFS-2956:
---
It's supposed to be acceptable to pass a null renewer. Since the renewer is a
{{Text}}, the typical problem is code leaving off a null check before calling
{{renewer.toString()}}.
> calling fetchdt without a --renewer argument throws NPE
> ---
>
> Key: HDFS-2956
> URL: https://issues.apache.org/jira/browse/HDFS-2956
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: security
>Affects Versions: 0.24.0
>Reporter: Todd Lipcon
>
> If I call "bin/hdfs fetchdt /tmp/mytoken" without a "--renewer foo" argument,
> then it will throw a NullPointerException:
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDelegationToken(ClientNamenodeProtocolTranslatorPB.java:830)
> this is because getDelegationToken is being called with a null renewer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
