[jira] [Commented] (HDFS-3055) Implement recovery mode for branch-1
[ https://issues.apache.org/jira/browse/HDFS-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252012#comment-13252012 ] Colin Patrick McCabe commented on HDFS-3055: I reran all the unit tests for branch-1 last night and could trace no failures to this change. Should be good to go. > Implement recovery mode for branch-1 > > > Key: HDFS-3055 > URL: https://issues.apache.org/jira/browse/HDFS-3055 > Project: Hadoop HDFS > Issue Type: New Feature >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 1.0.0 > > Attachments: HDFS-3055-b1.001.patch, HDFS-3055-b1.002.patch, > HDFS-3055-b1.003.patch, HDFS-3055-b1.004.patch, HDFS-3055-b1.005.patch, > HDFS-3055-b1.006.patch, HDFS-3055-b1.007.patch > > > Implement recovery mode for branch-1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3055) Implement recovery mode for branch-1
[ https://issues.apache.org/jira/browse/HDFS-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250194#comment-13250194 ] Todd Lipcon commented on HDFS-3055: --- OK. +1, patch looks good. Please run all the branch-1 unit tests so we don't introduce any other failures - should be OK but best to be safe on the stable branch. When you report back, I'll commit. > Implement recovery mode for branch-1 > > > Key: HDFS-3055 > URL: https://issues.apache.org/jira/browse/HDFS-3055 > Project: Hadoop HDFS > Issue Type: New Feature >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 1.0.0 > > Attachments: HDFS-3055-b1.001.patch, HDFS-3055-b1.002.patch, > HDFS-3055-b1.003.patch, HDFS-3055-b1.004.patch, HDFS-3055-b1.005.patch, > HDFS-3055-b1.006.patch > > > Implement recovery mode for branch-1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3055) Implement recovery mode for branch-1
[ https://issues.apache.org/jira/browse/HDFS-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250155#comment-13250155 ] Colin Patrick McCabe commented on HDFS-3055: > can you explain the changes in FSNamesystem.java? That change fixes error handling in FSNamesystem. Previously, we did not call FSNamesystem::shutdown() when initialization failed. This led to the MBeans staying registered. This is irrelevant when running the NameNode normally, since the MBeans are destroyed when the entire process goes away. However, when run from a test context, the next attempt to create a MiniDFSCluster instance will fail with "port in use" or some such error. > Can you update the logging in the test cases to use > StringUtils.stringifyException to match trunk? Ok. > Did you run all the existing tests in branch-1? I ran these tests: TestCheckpoint, TestEditLog, TestNameNodeRecovery, TestEditLogLoading, TestNameNodeMXBean, TestSaveNamespace, TestSecurityTokenEditLog, TestStorageDirectoryFailure, TestStorageRestore > Implement recovery mode for branch-1 > > > Key: HDFS-3055 > URL: https://issues.apache.org/jira/browse/HDFS-3055 > Project: Hadoop HDFS > Issue Type: New Feature >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 1.0.0 > > Attachments: HDFS-3055-b1.001.patch, HDFS-3055-b1.002.patch, > HDFS-3055-b1.003.patch, HDFS-3055-b1.004.patch, HDFS-3055-b1.005.patch > > > Implement recovery mode for branch-1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3055) Implement recovery mode for branch-1
[
https://issues.apache.org/jira/browse/HDFS-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250131#comment-13250131
]
Todd Lipcon commented on HDFS-3055:
---
- can you explain the changes in FSNamesystem.java?
- Can you update the logging in the test cases to use
StringUtils.stringifyException to match trunk?
- Did you run all the existing tests in branch-1? The one difference that I can
see that might cause a failure is that the IOException thrown during a failed
startup used to retain the exception {{t}} as its cause, but no longer does.
Otherwise looks good.
> Implement recovery mode for branch-1
>
>
> Key: HDFS-3055
> URL: https://issues.apache.org/jira/browse/HDFS-3055
> Project: Hadoop HDFS
> Issue Type: New Feature
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: HDFS-3055-b1.001.patch, HDFS-3055-b1.002.patch,
> HDFS-3055-b1.003.patch, HDFS-3055-b1.004.patch, HDFS-3055-b1.005.patch
>
>
> Implement recovery mode for branch-1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3055) Implement recovery mode for branch-1
[ https://issues.apache.org/jira/browse/HDFS-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247590#comment-13247590 ] Tsz Wo (Nicholas), SZE commented on HDFS-3055: -- For the same feature, we usually use the same JIRA for different branches. It is okay that you already created two (HDFS-3004 and this). Please try to get HDFS-3004 to trunk first. > Implement recovery mode for branch-1 > > > Key: HDFS-3055 > URL: https://issues.apache.org/jira/browse/HDFS-3055 > Project: Hadoop HDFS > Issue Type: New Feature >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 1.0.0 > > Attachments: HDFS-3055-b1.001.patch, HDFS-3055-b1.002.patch, > HDFS-3055-b1.003.patch > > > Implement recovery mode for branch-1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3055) Implement recovery mode for branch-1
[ https://issues.apache.org/jira/browse/HDFS-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246910#comment-13246910 ] Todd Lipcon commented on HDFS-3055: --- Hi Colin. Is this patch up to date with respect to the trunk version? Have you run the unit tests for branch-1? I'll review it, but want to make sure there aren't any changes in flight. > Implement recovery mode for branch-1 > > > Key: HDFS-3055 > URL: https://issues.apache.org/jira/browse/HDFS-3055 > Project: Hadoop HDFS > Issue Type: New Feature >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 1.0.0 > > Attachments: HDFS-3055-b1.001.patch, HDFS-3055-b1.002.patch > > > Implement recovery mode for branch-1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
