[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246274#comment-13246274 ] Hudson commented on HDFS-3176: -- Integrated in Hadoop-Mapreduce-trunk #1040 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1040/]) HDFS-3176. Use MD5MD5CRC32FileChecksum.readFields() in JsonUtil . Contributed by Kihwal Lee (Revision 1309114) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309114 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246230#comment-13246230 ] Hudson commented on HDFS-3176: -- Integrated in Hadoop-Hdfs-trunk #1005 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1005/]) HDFS-3176. Use MD5MD5CRC32FileChecksum.readFields() in JsonUtil . Contributed by Kihwal Lee (Revision 1309114) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309114 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246209#comment-13246209 ] Hudson commented on HDFS-3176: -- Integrated in Hadoop-Hdfs-0.23-Build #218 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/218/]) svn merge -c 1309114 from trunk for HDFS-3176. Use MD5MD5CRC32FileChecksum.readFields() in JsonUtil. (Revision 1309115) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309115 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245681#comment-13245681 ] Hudson commented on HDFS-3176: -- Integrated in Hadoop-Mapreduce-trunk-Commit #1996 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1996/]) HDFS-3176. Use MD5MD5CRC32FileChecksum.readFields() in JsonUtil . Contributed by Kihwal Lee (Revision 1309114) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309114 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245667#comment-13245667 ] Hudson commented on HDFS-3176: -- Integrated in Hadoop-Common-trunk-Commit #1983 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1983/]) HDFS-3176. Use MD5MD5CRC32FileChecksum.readFields() in JsonUtil . Contributed by Kihwal Lee (Revision 1309114) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309114 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245663#comment-13245663 ] Hudson commented on HDFS-3176: -- Integrated in Hadoop-Hdfs-trunk-Commit #2058 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2058/]) HDFS-3176. Use MD5MD5CRC32FileChecksum.readFields() in JsonUtil . Contributed by Kihwal Lee (Revision 1309114) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309114 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/JsonUtil.java > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244587#comment-13244587 ] Hadoop QA commented on HDFS-3176: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521023/hdfs-3176-branch-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2159//console This message is automatically generated. > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244539#comment-13244539 ] Kihwal Lee commented on HDFS-3176: -- No additional test is included because the patch does not introduce any functional change. > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244508#comment-13244508 ] Hadoop QA commented on HDFS-3176: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521002/hdfs-3176.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2152//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2152//console This message is automatically generated. > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176-branch-1.patch, hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3176) JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own.
[ https://issues.apache.org/jira/browse/HDFS-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244414#comment-13244414 ] Tsz Wo (Nicholas), SZE commented on HDFS-3176: -- +1 patch looks good. Thanks for fixing this. > JsonUtil should not parse the MD5MD5CRC32FileChecksum bytes on its own. > --- > > Key: HDFS-3176 > URL: https://issues.apache.org/jira/browse/HDFS-3176 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0, 1.0.1 >Reporter: Kihwal Lee >Assignee: Kihwal Lee > Fix For: 1.1.0, 0.23.3, 2.0.0, 3.0.0 > > Attachments: hdfs-3176.patch > > > Currently JsonUtil used by webhdfs parses MD5MD5CRC32FileChecksum binary > bytes on its own and contructs a MD5MD5CRC32FileChecksum. It should instead > call MD5MD5CRC32FileChecksum.readFields(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
