[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257487#comment-13257487 ] Hudson commented on HDFS-3282: -- Integrated in Hadoop-Mapreduce-trunk #1054 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1054/]) iHDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327790) HDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327788) Result = SUCCESS umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327790 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsDataInputStream.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Fix For: 3.0.0 > > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257456#comment-13257456 ] Hudson commented on HDFS-3282: -- Integrated in Hadoop-Hdfs-trunk #1019 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1019/]) iHDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327790) HDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327788) Result = FAILURE umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327790 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsDataInputStream.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Fix For: 3.0.0 > > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257204#comment-13257204 ] Hudson commented on HDFS-3282: -- Integrated in Hadoop-Mapreduce-trunk-Commit #2120 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2120/]) iHDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327790) HDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327788) Result = ABORTED umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327790 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsDataInputStream.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Fix For: 3.0.0 > > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257185#comment-13257185 ] Uma Maheswara Rao G commented on HDFS-3282: --- I just committed this to trunk! > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Fix For: 3.0.0 > > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257184#comment-13257184 ] Uma Maheswara Rao G commented on HDFS-3282: --- Thanks a lot Eli and Nicholas for taking a look on Javac warnings. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257178#comment-13257178 ] Hudson commented on HDFS-3282: -- Integrated in Hadoop-Common-trunk-Commit #2103 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2103/]) iHDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327790) HDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327788) Result = SUCCESS umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327790 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsDataInputStream.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257176#comment-13257176 ] Hudson commented on HDFS-3282: -- Integrated in Hadoop-Hdfs-trunk-Commit #2176 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2176/]) HDFS-3282. Expose getFileLength API. Contributed by Uma Maheswara Rao G. (Revision 1327788) Result = FAILURE umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327788 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257038#comment-13257038 ] Tsz Wo (Nicholas), SZE commented on HDFS-3282: -- Thanks for looking at this, Eli. Unfortunately, we don't have something like OK_JAVAC_WARNINGS. The test-patch script simply compare the number of javac warnings with and without the patch. So, no additional change to the patch is required. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256958#comment-13256958 ] Eli Collins commented on HDFS-3282: --- Oops, misread javac warnings for javadocs warnings, never mind. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256952#comment-13256952 ] Eli Collins commented on HDFS-3282: --- If you're going to punt on the javadoc warnings this introduces the patch should bump OK_JAVADOC_WARNINGS so subsequent jenkins runs don't automatically -1. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256916#comment-13256916 ] Tsz Wo (Nicholas), SZE commented on HDFS-3282: -- All the new javac warnings are the deprecated warnings of the use of DFSDataInputStream. Let's fix them separately. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256896#comment-13256896 ] Hadoop QA commented on HDFS-3282: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523204/HDFS-3282.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 41 javac compiler warnings (more than the trunk's current 20 warnings). +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2300//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2300//console This message is automatically generated. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256791#comment-13256791 ] Uma Maheswara Rao G commented on HDFS-3282: --- Thanks Nicholas for the review again!. I will commit this patch in some time. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256614#comment-13256614 ] Uma Maheswara Rao G commented on HDFS-3282: --- Thanks a lot, Nicholas for the review! Updated the patch with addressing your comments and also removed one unused import from previous patch. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > Attachments: HDFS-3282.patch, HDFS-3282.patch > > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[
https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256166#comment-13256166
]
Tsz Wo (Nicholas), SZE commented on HDFS-3282:
--
Uma, good work! Some comments:
- Let's put HdfsDataInputStream in org.apache.hadoop.hdfs.client. It is a
package for all the public APIs.
- HdfsDataInputStream.getAllBlocks() should be public. You also have to change
DFSInputStream.getAllBlocks() to public.
- Move the @SuppressWarnings("deprecation") annotation on DistributedFileSystem
to DistributedFileSystem.reportChecksumFailure(..). Otherwise, it will
suppress all the warnings in DistributedFileSystem.
- Let's replace the javadoc of DFSDataInputStream with "@deprecated use {@link
HdfsDataInputStream} instead."
> Expose getFileLength API.
> -
>
> Key: HDFS-3282
> URL: https://issues.apache.org/jira/browse/HDFS-3282
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs client
>Affects Versions: 3.0.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-3282.patch
>
>
> This JIRA is to expose the getFileLength API through a new public
> DistributedFileSystemInfo class.
> I would appreciate if someone suggest good name for this public class.
> Nicholas, did you plan any special design for this public client class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[
https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256124#comment-13256124
]
Uma Maheswara Rao G commented on HDFS-3282:
---
Thanks a lot for your clarification.
{quote}
Let me clarify it: the return type is HdfsDataInputStream but the return object
is still DFSDataInputStream so that users could cast the stream to
DFSDataInputStream as before. We also have to keep the DFSDataInputStream
constructor.
{quote}
Yep, While implementing I got it. Implemented in this way only :-). Otherwise
keeping DFSDataInputStream extends HdfsDataInputStream, almost no use.
> Expose getFileLength API.
> -
>
> Key: HDFS-3282
> URL: https://issues.apache.org/jira/browse/HDFS-3282
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs client
>Affects Versions: 3.0.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
>
> This JIRA is to expose the getFileLength API through a new public
> DistributedFileSystemInfo class.
> I would appreciate if someone suggest good name for this public class.
> Nicholas, did you plan any special design for this public client class?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255891#comment-13255891 ] Tsz Wo (Nicholas), SZE commented on HDFS-3282: -- > change DistributedFileSystem.open(..) to return HdfsDataInputStream. Let me clarify it: the return type is HdfsDataInputStream but the return object is still DFSDataInputStream so that users could cast the stream to DFSDataInputStream as before. We also have to keep the DFSDataInputStream constructor. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255840#comment-13255840 ] Uma Maheswara Rao G commented on HDFS-3282: --- Sounds fine to me. I will proceed with this approach. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254978#comment-13254978 ] Tsz Wo (Nicholas), SZE commented on HDFS-3282: -- Todd, good point. Then, let's - move the code to HdfsDataInputStream; - keep DFSDataInputStream (an empty class), change it to extend HdfsDataInputStream and deprecate it; - change DistributedFileSystem.open(..) to return HdfsDataInputStream. > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254963#comment-13254963 ] Todd Lipcon commented on HDFS-3282: --- Nicholas: despite us advertising DFSDataInputStream as a private API, I imagine this change would break people. Could we instead just add a new interface which would be implemented by the existing class? > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3282) Expose getFileLength API.
[ https://issues.apache.org/jira/browse/HDFS-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254941#comment-13254941 ] Tsz Wo (Nicholas), SZE commented on HDFS-3282: -- Hi Uma, We could move DFSClient.DFSDataInputStream to a new class, say org.apache.hadoop.hdfs.client.HdfsDataInputStream, which is a public API. Then, change the return type of DistributedFileSystem.open(..) to HdfsDataInputStream. What do you think? > Expose getFileLength API. > - > > Key: HDFS-3282 > URL: https://issues.apache.org/jira/browse/HDFS-3282 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client >Affects Versions: 3.0.0 >Reporter: Uma Maheswara Rao G >Assignee: Uma Maheswara Rao G > > This JIRA is to expose the getFileLength API through a new public > DistributedFileSystemInfo class. > I would appreciate if someone suggest good name for this public class. > Nicholas, did you plan any special design for this public client class? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
