[jira] [Commented] (HDFS-3293) Implement equals for storageinfo and journainfo class.
[ https://issues.apache.org/jira/browse/HDFS-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263987#comment-13263987 ] Hari Mankude commented on HDFS-3293: Changes are trivial. So test is not included. > Implement equals for storageinfo and journainfo class. > --- > > Key: HDFS-3293 > URL: https://issues.apache.org/jira/browse/HDFS-3293 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Attachments: hdfs-3293.patch > > > Implement equals for storageinfo and journalinfo class. Also journalinfo > class needs a toString() method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3293) Implement equals for storageinfo and journainfo class.
[ https://issues.apache.org/jira/browse/HDFS-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264000#comment-13264000 ] Tsz Wo (Nicholas), SZE commented on HDFS-3293: -- - Since clusterID is a String, we need to call clusterID.equals(..). - Add @Override for JournalInfo.toString(). - We need to also override hashcode(). Otherwise, it will have findbugs warnings. > Implement equals for storageinfo and journainfo class. > --- > > Key: HDFS-3293 > URL: https://issues.apache.org/jira/browse/HDFS-3293 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Attachments: hdfs-3293.patch > > > Implement equals for storageinfo and journalinfo class. Also journalinfo > class needs a toString() method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3293) Implement equals for storageinfo and journainfo class.
[ https://issues.apache.org/jira/browse/HDFS-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264022#comment-13264022 ] Hari Mankude commented on HDFS-3293: Fixed all the issues mentioned by Nicholas. > Implement equals for storageinfo and journainfo class. > --- > > Key: HDFS-3293 > URL: https://issues.apache.org/jira/browse/HDFS-3293 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Attachments: hdfs-3293-1.patch, hdfs-3293.patch > > > Implement equals for storageinfo and journalinfo class. Also journalinfo > class needs a toString() method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3293) Implement equals for storageinfo and journainfo class.
[ https://issues.apache.org/jira/browse/HDFS-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264063#comment-13264063 ] Hadoop QA commented on HDFS-3293: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524928/hdfs-3293.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2346//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2346//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2346//console This message is automatically generated. > Implement equals for storageinfo and journainfo class. > --- > > Key: HDFS-3293 > URL: https://issues.apache.org/jira/browse/HDFS-3293 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Attachments: hdfs-3293-1.patch, hdfs-3293.patch > > > Implement equals for storageinfo and journalinfo class. Also journalinfo > class needs a toString() method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3293) Implement equals for storageinfo and journainfo class.
[ https://issues.apache.org/jira/browse/HDFS-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264153#comment-13264153 ] Hadoop QA commented on HDFS-3293: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524935/hdfs-3293-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.namenode.TestListCorruptFileBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2347//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2347//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2347//console This message is automatically generated. > Implement equals for storageinfo and journainfo class. > --- > > Key: HDFS-3293 > URL: https://issues.apache.org/jira/browse/HDFS-3293 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Attachments: hdfs-3293-1.patch, hdfs-3293.patch > > > Implement equals for storageinfo and journalinfo class. Also journalinfo > class needs a toString() method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3293) Implement equals for storageinfo and journainfo class.
[ https://issues.apache.org/jira/browse/HDFS-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265402#comment-13265402 ] Hadoop QA commented on HDFS-3293: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525099/hdfs-3293-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2351//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2351//console This message is automatically generated. > Implement equals for storageinfo and journainfo class. > --- > > Key: HDFS-3293 > URL: https://issues.apache.org/jira/browse/HDFS-3293 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Attachments: hdfs-3293-1.patch, hdfs-3293-2.patch, hdfs-3293.patch > > > Implement equals for storageinfo and journalinfo class. Also journalinfo > class needs a toString() method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
