[jira] [Commented] (HDFS-3305) GetImageServlet should considered SBN a valid requestor in a secure HA setup

2012-04-19 Thread Todd Lipcon (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257708#comment-13257708
 ] 

Todd Lipcon commented on HDFS-3305:
---

+1 pending jenkins

 GetImageServlet should considered SBN a valid requestor in a secure HA setup
 

 Key: HDFS-3305
 URL: https://issues.apache.org/jira/browse/HDFS-3305
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: ha, name-node
Affects Versions: 2.0.0
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
 Attachments: HDFS-3305.patch


 Right now only the NN and 2NN are considered valid requestors. This won't 
 work if the ANN and SBN use distinct principal names.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HDFS-3305) GetImageServlet should considered SBN a valid requestor in a secure HA setup

2012-04-19 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257785#comment-13257785
 ] 

Hadoop QA commented on HDFS-3305:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523385/HDFS-3305.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 1 new or modified test 
files.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 eclipse:eclipse.  The patch built with eclipse:eclipse.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed these unit tests:
  org.apache.hadoop.hdfs.TestDatanodeBlockScanner

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/2304//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2304//console

This message is automatically generated.

 GetImageServlet should considered SBN a valid requestor in a secure HA setup
 

 Key: HDFS-3305
 URL: https://issues.apache.org/jira/browse/HDFS-3305
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: ha, name-node
Affects Versions: 2.0.0
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
 Attachments: HDFS-3305.patch


 Right now only the NN and 2NN are considered valid requestors. This won't 
 work if the ANN and SBN use distinct principal names.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HDFS-3305) GetImageServlet should considered SBN a valid requestor in a secure HA setup

2012-04-19 Thread Aaron T. Myers (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257789#comment-13257789
 ] 

Aaron T. Myers commented on HDFS-3305:
--

I'm confident that the test failure is unrelated. That test doesn't touch this 
code path, and I just ran TestDatanodeBlockScanner locally on my box and 
confirmed that it passed just fine.

Thanks a lot for the review, Todd. I'll commit this momentarily.

 GetImageServlet should considered SBN a valid requestor in a secure HA setup
 

 Key: HDFS-3305
 URL: https://issues.apache.org/jira/browse/HDFS-3305
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: ha, name-node
Affects Versions: 2.0.0
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
 Attachments: HDFS-3305.patch


 Right now only the NN and 2NN are considered valid requestors. This won't 
 work if the ANN and SBN use distinct principal names.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira