[jira] [Commented] (HDFS-3387) [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser
[
https://issues.apache.org/jira/browse/HDFS-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362812#comment-14362812
]
Harsh J commented on HDFS-3387:
---
The text can rather look generic such as this:
{quote}
The general command line syntax is:
command [genericOptions] [commandOptions]
{quote}
> [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser
> --
>
> Key: HDFS-3387
> URL: https://issues.apache.org/jira/browse/HDFS-3387
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
>Affects Versions: 2.0.0-alpha
>Reporter: Brahma Reddy Battula
>Priority: Trivial
> Attachments: HDFS-3387.patch, HDFS-3387_updated.patch
>
>
> Scenario:
> --
> Execute any fsshell command with invalid options
> Like ./hdfs haadmin -transitionToActive...
> Here it is logging as following..
> bin/hadoop command [genericOptions] [commandOptions]...
> Expected: Here help message is misleading to user saying that bin/hadoop that
> is not actually user ran
> it's better to log bin/hdfs..Anyway hadoop is deprecated..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-3387) [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser
[ https://issues.apache.org/jira/browse/HDFS-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272624#comment-13272624 ] Hadoop QA commented on HDFS-3387: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526384/HDFS-3387_updated.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2408//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2408//console This message is automatically generated. > [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser > -- > > Key: HDFS-3387 > URL: https://issues.apache.org/jira/browse/HDFS-3387 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 2.0.0 >Reporter: Brahma Reddy Battula >Priority: Trivial > Fix For: 2.0.0, 3.0.0 > > Attachments: HDFS-3387.patch, HDFS-3387_updated.patch > > > Scenario: > -- > Execute any fsshell command with invalid options > Like ./hdfs haadmin -transitionToActive... > Here it is logging as following.. > bin/hadoop command [genericOptions] [commandOptions]... > Expected: Here help message is misleading to user saying that bin/hadoop that > is not actually user ran > it's better to log bin/hdfs..Anyway hadoop is deprecated.. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3387) [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser
[ https://issues.apache.org/jira/browse/HDFS-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272563#comment-13272563 ] Brahma Reddy Battula commented on HDFS-3387: @Daryn Sharp..Thanks for look... hadoop fs is not deprecated..Whatever you told is correct..It's better to separate out hdfs and hadoop(general filesystem) when running fsshell commands...I'll Fix same ..:) > [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser > -- > > Key: HDFS-3387 > URL: https://issues.apache.org/jira/browse/HDFS-3387 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 2.0.0 >Reporter: Brahma Reddy Battula >Priority: Trivial > Fix For: 2.0.0, 3.0.0 > > Attachments: HDFS-3387.patch, HDFS-3387_updated.patch > > > Scenario: > -- > Execute any fsshell command with invalid options > Like ./hdfs haadmin -transitionToActive... > Here it is logging as following.. > bin/hadoop command [genericOptions] [commandOptions]... > Expected: Here help message is misleading to user saying that bin/hadoop that > is not actually user ran > it's better to log bin/hdfs..Anyway hadoop is deprecated.. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3387) [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser
[ https://issues.apache.org/jira/browse/HDFS-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270797#comment-13270797 ] Daryn Sharp commented on HDFS-3387: --- Are you sure "hadoop fs" is deprecated? It doesn't seem to make sense to run "hdfs fs" on a non-hdfs filesystem. > [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser > -- > > Key: HDFS-3387 > URL: https://issues.apache.org/jira/browse/HDFS-3387 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 2.0.0 >Reporter: Brahma Reddy Battula >Priority: Trivial > Fix For: 2.0.0, 3.0.0 > > Attachments: HDFS-3387.patch > > > Scenario: > -- > Execute any fsshell command with invalid options > Like ./hdfs haadmin -transitionToActive... > Here it is logging as following.. > bin/hadoop command [genericOptions] [commandOptions]... > Expected: Here help message is misleading to user saying that bin/hadoop that > is not actually user ran > it's better to log bin/hdfs..Anyway hadoop is deprecated.. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3387) [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser
[ https://issues.apache.org/jira/browse/HDFS-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270684#comment-13270684 ] Aaron T. Myers commented on HDFS-3387: -- Hey Brahma, you need to root your patch at repo root. The patch you attached doesn't include the path to the file you edited. > [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser > -- > > Key: HDFS-3387 > URL: https://issues.apache.org/jira/browse/HDFS-3387 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 2.0.0 >Reporter: Brahma Reddy Battula >Priority: Trivial > Fix For: 2.0.0, 3.0.0 > > Attachments: HDFS-3387.patch > > > Scenario: > -- > Execute any fsshell command with invalid options > Like ./hdfs haadmin -transitionToActive... > Here it is logging as following.. > bin/hadoop command [genericOptions] [commandOptions]... > Expected: Here help message is misleading to user saying that bin/hadoop that > is not actually user ran > it's better to log bin/hdfs..Anyway hadoop is deprecated.. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3387) [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser
[ https://issues.apache.org/jira/browse/HDFS-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270650#comment-13270650 ] Hadoop QA commented on HDFS-3387: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526018/HDFS-3387.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2389//console This message is automatically generated. > [Fsshell]It's better to provide hdfs instead of hadoop in GenericOptionsParser > -- > > Key: HDFS-3387 > URL: https://issues.apache.org/jira/browse/HDFS-3387 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 2.0.0 >Reporter: Brahma Reddy Battula >Priority: Trivial > Fix For: 2.0.0, 3.0.0 > > Attachments: HDFS-3387.patch > > > Scenario: > -- > Execute any fsshell command with invalid options > Like ./hdfs haadmin -transitionToActive... > Here it is logging as following.. > bin/hadoop command [genericOptions] [commandOptions]... > Expected: Here help message is misleading to user saying that bin/hadoop that > is not actually user ran > it's better to log bin/hdfs..Anyway hadoop is deprecated.. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
