[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414357#comment-13414357 ] Hudson commented on HDFS-3609: -- Integrated in Hadoop-Hdfs-trunk #1103 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1103/]) HDFS-3609. libhdfs: don't force the URI to look like hdfs://hostname:port. Contributed by Colin Patrick McCabe (Revision 1361454) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361454 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.0.1-alpha Attachments: HDFS-3609.001.patch, HDFS-3609.002.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414411#comment-13414411 ] Hudson commented on HDFS-3609: -- Integrated in Hadoop-Mapreduce-trunk #1136 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1136/]) HDFS-3609. libhdfs: don't force the URI to look like hdfs://hostname:port. Contributed by Colin Patrick McCabe (Revision 1361454) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361454 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.0.1-alpha Attachments: HDFS-3609.001.patch, HDFS-3609.002.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414208#comment-13414208 ] Eli Collins commented on HDFS-3609: --- +1 lgtm libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.0.1-alpha Attachments: HDFS-3609.001.patch, HDFS-3609.002.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414233#comment-13414233 ] Hudson commented on HDFS-3609: -- Integrated in Hadoop-Mapreduce-trunk-Commit #2488 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2488/]) HDFS-3609. libhdfs: don't force the URI to look like hdfs://hostname:port. Contributed by Colin Patrick McCabe (Revision 1361454) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361454 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.0.1-alpha Attachments: HDFS-3609.001.patch, HDFS-3609.002.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414256#comment-13414256 ] Hudson commented on HDFS-3609: -- Integrated in Hadoop-Common-trunk-Commit #2469 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2469/]) HDFS-3609. libhdfs: don't force the URI to look like hdfs://hostname:port. Contributed by Colin Patrick McCabe (Revision 1361454) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361454 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.0.1-alpha Attachments: HDFS-3609.001.patch, HDFS-3609.002.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414261#comment-13414261 ] Hudson commented on HDFS-3609: -- Integrated in Hadoop-Hdfs-trunk-Commit #2534 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2534/]) HDFS-3609. libhdfs: don't force the URI to look like hdfs://hostname:port. Contributed by Colin Patrick McCabe (Revision 1361454) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361454 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.h libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 2.0.1-alpha Attachments: HDFS-3609.001.patch, HDFS-3609.002.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413334#comment-13413334 ] Eli Collins commented on HDFS-3609: --- Patch looks good Nit: what you're calling URI prefix/location/protocol type in the comments is called the scheme in URI lingo. Testing? Eg confirmed you can run libhdfs against an HA config (ie one w/o a port) now? The test failures here are obviously unrelated. libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Attachments: HDFS-3609.001.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413381#comment-13413381 ] Colin Patrick McCabe commented on HDFS-3609: I've verified I can connect without an explicit port, using hdfs_test. There will be an opportunity to add more unit tests once HDFS-3606 is in. libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Attachments: HDFS-3609.001.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413440#comment-13413440 ] Hadoop QA commented on HDFS-3609: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536315/HDFS-3609.002.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2810//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2810//console This message is automatically generated. libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Attachments: HDFS-3609.001.patch, HDFS-3609.002.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3609) libhdfs: don't force the URI to look like hdfs://hostname:port
[ https://issues.apache.org/jira/browse/HDFS-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412269#comment-13412269 ] Hadoop QA commented on HDFS-3609: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536119/HDFS-3609.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.TestDatanodeBlockScanner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2796//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2796//console This message is automatically generated. libhdfs: don't force the URI to look like hdfs://hostname:port -- Key: HDFS-3609 URL: https://issues.apache.org/jira/browse/HDFS-3609 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.0-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Attachments: HDFS-3609.001.patch Currently, libhdfs forces the URI to look like hdfs://hostname:port. For configurations like HA or federation this is not ideal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
