[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412714#comment-13412714 ] Hudson commented on HDFS-3615: -- Integrated in Hadoop-Hdfs-trunk #1101 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1101/]) HDFS-3615. Two BlockTokenSecretManager findbugs warnings. Contributed by Aaron T. Myers. (Revision 1360255) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1360255 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Assignee: Aaron T. Myers Fix For: 2.0.1-alpha Attachments: HDFS-3615.patch Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412805#comment-13412805 ] Hudson commented on HDFS-3615: -- Integrated in Hadoop-Mapreduce-trunk #1134 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1134/]) HDFS-3615. Two BlockTokenSecretManager findbugs warnings. Contributed by Aaron T. Myers. (Revision 1360255) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1360255 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Assignee: Aaron T. Myers Fix For: 2.0.1-alpha Attachments: HDFS-3615.patch Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411651#comment-13411651 ] Hadoop QA commented on HDFS-3615: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535964/HDFS-3615.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2792//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2792//console This message is automatically generated. Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Assignee: Aaron T. Myers Attachments: HDFS-3615.patch Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411674#comment-13411674 ] Aaron T. Myers commented on HDFS-3615: -- No tests are included since this is just a simple findbugs warning fix that doesn't change any behavior. Thanks for the review, Eli. I'm going to commit this momentarily. Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Assignee: Aaron T. Myers Attachments: HDFS-3615.patch Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411683#comment-13411683 ] Hudson commented on HDFS-3615: -- Integrated in Hadoop-Common-trunk-Commit #2451 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2451/]) HDFS-3615. Two BlockTokenSecretManager findbugs warnings. Contributed by Aaron T. Myers. (Revision 1360255) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1360255 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Assignee: Aaron T. Myers Fix For: 2.0.1-alpha Attachments: HDFS-3615.patch Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411687#comment-13411687 ] Hudson commented on HDFS-3615: -- Integrated in Hadoop-Hdfs-trunk-Commit #2517 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2517/]) HDFS-3615. Two BlockTokenSecretManager findbugs warnings. Contributed by Aaron T. Myers. (Revision 1360255) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1360255 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Assignee: Aaron T. Myers Fix For: 2.0.1-alpha Attachments: HDFS-3615.patch Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411767#comment-13411767 ] Hudson commented on HDFS-3615: -- Integrated in Hadoop-Mapreduce-trunk-Commit #2469 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2469/]) HDFS-3615. Two BlockTokenSecretManager findbugs warnings. Contributed by Aaron T. Myers. (Revision 1360255) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1360255 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Assignee: Aaron T. Myers Fix For: 2.0.1-alpha Attachments: HDFS-3615.patch Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411137#comment-13411137 ] Eli Collins commented on HDFS-3615: --- +1 pending jenkins Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Assignee: Aaron T. Myers Attachments: HDFS-3615.patch Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings
[ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409843#comment-13409843 ] Eli Collins commented on HDFS-3615: --- I must have been looking at a stale tree, Fix issue with NN/DN re-registration recently modified this file, is likely the culprit. Two BlockTokenSecretManager findbugs warnings - Key: HDFS-3615 URL: https://issues.apache.org/jira/browse/HDFS-3615 Project: Hadoop HDFS Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Eli Collins Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time ISInconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
