[jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
[ https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413672#comment-13413672 ] Hudson commented on HDFS-3633: -- Integrated in Hadoop-Hdfs-trunk #1102 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1102/]) HDFS-3633. libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE. Contributed by Colin Patrick McCabe (Revision 1361005) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361005 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE - Key: HDFS-3633 URL: https://issues.apache.org/jira/browse/HDFS-3633 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.1-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.1-alpha Attachments: HDFS-3633.001.patch In libhdfs in hdfsDelete, the header file says any non-zero argument to hdfsDelete will be interpreted as true. However, the hdfsDelete function does not translate these non-zero values to JNI_FALSE and JNI_TRUE, potentially leading to undefined or JVM-specific behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
[ https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413762#comment-13413762 ] Hudson commented on HDFS-3633: -- Integrated in Hadoop-Mapreduce-trunk #1135 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1135/]) HDFS-3633. libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE. Contributed by Colin Patrick McCabe (Revision 1361005) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361005 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE - Key: HDFS-3633 URL: https://issues.apache.org/jira/browse/HDFS-3633 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.1-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.1-alpha Attachments: HDFS-3633.001.patch In libhdfs in hdfsDelete, the header file says any non-zero argument to hdfsDelete will be interpreted as true. However, the hdfsDelete function does not translate these non-zero values to JNI_FALSE and JNI_TRUE, potentially leading to undefined or JVM-specific behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
[ https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413363#comment-13413363 ] Hudson commented on HDFS-3633: -- Integrated in Hadoop-Common-trunk-Commit #2459 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2459/]) HDFS-3633. libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE. Contributed by Colin Patrick McCabe (Revision 1361005) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361005 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE - Key: HDFS-3633 URL: https://issues.apache.org/jira/browse/HDFS-3633 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.1-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.1-alpha Attachments: HDFS-3633.001.patch In libhdfs in hdfsDelete, the header file says any non-zero argument to hdfsDelete will be interpreted as true. However, the hdfsDelete function does not translate these non-zero values to JNI_FALSE and JNI_TRUE, potentially leading to undefined or JVM-specific behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
[ https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413367#comment-13413367 ] Hudson commented on HDFS-3633: -- Integrated in Hadoop-Hdfs-trunk-Commit #2525 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2525/]) HDFS-3633. libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE. Contributed by Colin Patrick McCabe (Revision 1361005) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361005 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE - Key: HDFS-3633 URL: https://issues.apache.org/jira/browse/HDFS-3633 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.1-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.1-alpha Attachments: HDFS-3633.001.patch In libhdfs in hdfsDelete, the header file says any non-zero argument to hdfsDelete will be interpreted as true. However, the hdfsDelete function does not translate these non-zero values to JNI_FALSE and JNI_TRUE, potentially leading to undefined or JVM-specific behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
[ https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413393#comment-13413393 ] Hudson commented on HDFS-3633: -- Integrated in Hadoop-Mapreduce-trunk-Commit #2478 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2478/]) HDFS-3633. libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE. Contributed by Colin Patrick McCabe (Revision 1361005) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1361005 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/hdfs.c libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE - Key: HDFS-3633 URL: https://issues.apache.org/jira/browse/HDFS-3633 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.1-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.1-alpha Attachments: HDFS-3633.001.patch In libhdfs in hdfsDelete, the header file says any non-zero argument to hdfsDelete will be interpreted as true. However, the hdfsDelete function does not translate these non-zero values to JNI_FALSE and JNI_TRUE, potentially leading to undefined or JVM-specific behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
[ https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411841#comment-13411841 ] Andy Isaacson commented on HDFS-3633: - +1, LGTM. libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE - Key: HDFS-3633 URL: https://issues.apache.org/jira/browse/HDFS-3633 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.1-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HDFS-3633.001.patch In libhdfs in hdfsDelete, the header file says any non-zero argument to hdfsDelete will be interpreted as true. However, the hdfsDelete function does not translate these non-zero values to JNI_FALSE and JNI_TRUE, potentially leading to undefined or JVM-specific behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
[
https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411099#comment-13411099
]
Colin Patrick McCabe commented on HDFS-3633:
The code in question is here:
{code}
jboolean jRecursive = recursive;
if (invokeMethod(env, jVal, jExc, INSTANCE, jFS, HADOOP_FS,
delete, (Lorg/apache/hadoop/fs/Path;Z)Z, jPath, jRecursive) != 0)
{
errno = errnoFromException(jExc, env, org.apache.hadoop.fs.
FileSystem::delete);
destroyLocalReference(env, jPath);
return -1;
}
{code}
jRecursive must get either JNI_FALSE or JNI_TRUE.
libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
-
Key: HDFS-3633
URL: https://issues.apache.org/jira/browse/HDFS-3633
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.0.1-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
In libhdfs in hdfsDelete, the header file says any non-zero argument to
hdfsDelete will be interpreted as true. However, the hdfsDelete function
does not translate these non-zero values to JNI_FALSE and JNI_TRUE,
potentially leading to undefined or JVM-specific behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE
[ https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13411219#comment-13411219 ] Hadoop QA commented on HDFS-3633: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535957/HDFS-3633.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2785//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2785//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2785//console This message is automatically generated. libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE - Key: HDFS-3633 URL: https://issues.apache.org/jira/browse/HDFS-3633 Project: Hadoop HDFS Issue Type: Bug Components: libhdfs Affects Versions: 2.0.1-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HDFS-3633.001.patch In libhdfs in hdfsDelete, the header file says any non-zero argument to hdfsDelete will be interpreted as true. However, the hdfsDelete function does not translate these non-zero values to JNI_FALSE and JNI_TRUE, potentially leading to undefined or JVM-specific behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
