[jira] [Commented] (HDFS-3644) OEV should recognize and deal with 0.20.20x opcode versions

2012-07-12 Thread Suresh Srinivas (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412946#comment-13412946
 ] 

Suresh Srinivas commented on HDFS-3644:
---

BTW a comment to relevant to my previous comment - 
https://issues.apache.org/jira/browse/HDFS-1842?focusedCommentId=13021839&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13021839

> OEV should recognize and deal with 0.20.20x opcode versions
> ---
>
> Key: HDFS-3644
> URL: https://issues.apache.org/jira/browse/HDFS-3644
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Priority: Minor
>
> We have some opcode conflicts for edit logs between 0.20.20x (LV -19, -31) vs 
> newer versions. For edit log loading, we dealt with this by forcing users to 
> save namespace on an earlier version before upgrading. But, using a trunk OEV 
> on an older version is useful since the OEV has had so many improvements. It 
> would be nice to be able to specify a flag to the OEV to be able to run on 
> older edit logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HDFS-3644) OEV should recognize and deal with 0.20.20x opcode versions

2012-07-12 Thread Suresh Srinivas (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413036#comment-13413036
 ] 

Suresh Srinivas commented on HDFS-3644:
---

Todd, can you tell me which apache release the LV -19 is from. Saves me time, 
since you have already done this analysis.

> OEV should recognize and deal with 0.20.20x opcode versions
> ---
>
> Key: HDFS-3644
> URL: https://issues.apache.org/jira/browse/HDFS-3644
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Priority: Minor
>
> We have some opcode conflicts for edit logs between 0.20.20x (LV -19, -31) vs 
> newer versions. For edit log loading, we dealt with this by forcing users to 
> save namespace on an earlier version before upgrading. But, using a trunk OEV 
> on an older version is useful since the OEV has had so many improvements. It 
> would be nice to be able to specify a flag to the OEV to be able to run on 
> older edit logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HDFS-3644) OEV should recognize and deal with 0.20.20x opcode versions

2012-07-12 Thread Eli Collins (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413053#comment-13413053
 ] 

Eli Collins commented on HDFS-3644:
---

Suresh,

{code}
hadoop-branch-1 $ grep -r LAYOUT_VERSIONS_203 src/
src/hdfs/org/apache/hadoop/hdfs/server/common/Storage.java:  public static 
final int[] LAYOUT_VERSIONS_203 = {-19, -31};
{code}

> OEV should recognize and deal with 0.20.20x opcode versions
> ---
>
> Key: HDFS-3644
> URL: https://issues.apache.org/jira/browse/HDFS-3644
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Priority: Minor
>
> We have some opcode conflicts for edit logs between 0.20.20x (LV -19, -31) vs 
> newer versions. For edit log loading, we dealt with this by forcing users to 
> save namespace on an earlier version before upgrading. But, using a trunk OEV 
> on an older version is useful since the OEV has had so many improvements. It 
> would be nice to be able to specify a flag to the OEV to be able to run on 
> older edit logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HDFS-3644) OEV should recognize and deal with 0.20.20x opcode versions

2012-07-12 Thread Suresh Srinivas (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413057#comment-13413057
 ] 

Suresh Srinivas commented on HDFS-3644:
---

@Eli, not sure if you saw my previous comment:
bq. The conflict code was only in 0.20.203. Post upgrade to later releases the 
conflicting opcode is not used.

Given that a tool that works with the opcodes seems unnecessary, since the 
problem is only in 0.20.203 alone. Even the editlog code does not handle these 
conflicts in 0.20.204. We make users save namespace to work around it.

> OEV should recognize and deal with 0.20.20x opcode versions
> ---
>
> Key: HDFS-3644
> URL: https://issues.apache.org/jira/browse/HDFS-3644
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Priority: Minor
>
> We have some opcode conflicts for edit logs between 0.20.20x (LV -19, -31) vs 
> newer versions. For edit log loading, we dealt with this by forcing users to 
> save namespace on an earlier version before upgrading. But, using a trunk OEV 
> on an older version is useful since the OEV has had so many improvements. It 
> would be nice to be able to specify a flag to the OEV to be able to run on 
> older edit logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HDFS-3644) OEV should recognize and deal with 0.20.20x opcode versions

2012-07-12 Thread Todd Lipcon (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413061#comment-13413061
 ] 

Todd Lipcon commented on HDFS-3644:
---

bq. We make users save namespace to work around it

That's the same proposal here: we error out with "Sorry, you cannot use the OEV 
on an edit log from this version of Hadoop." Instead of erroring out with 
"EofException" while trying to read a symlink target, which makes people think 
the log itself is corrupt.

> OEV should recognize and deal with 0.20.20x opcode versions
> ---
>
> Key: HDFS-3644
> URL: https://issues.apache.org/jira/browse/HDFS-3644
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Priority: Minor
>
> We have some opcode conflicts for edit logs between 0.20.20x (LV -19, -31) vs 
> newer versions. For edit log loading, we dealt with this by forcing users to 
> save namespace on an earlier version before upgrading. But, using a trunk OEV 
> on an older version is useful since the OEV has had so many improvements. It 
> would be nice to be able to specify a flag to the OEV to be able to run on 
> older edit logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HDFS-3644) OEV should recognize and deal with 0.20.20x opcode versions

2012-07-12 Thread Suresh Srinivas (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413179#comment-13413179
 ] 

Suresh Srinivas commented on HDFS-3644:
---

bq. That's the same proposal here
Sorry, that was not clear to me by the title or description. Perhaps we could 
change them for better clarity.

> OEV should recognize and deal with 0.20.20x opcode versions
> ---
>
> Key: HDFS-3644
> URL: https://issues.apache.org/jira/browse/HDFS-3644
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Priority: Minor
>
> We have some opcode conflicts for edit logs between 0.20.20x (LV -19, -31) vs 
> newer versions. For edit log loading, we dealt with this by forcing users to 
> save namespace on an earlier version before upgrading. But, using a trunk OEV 
> on an older version is useful since the OEV has had so many improvements. It 
> would be nice to be able to specify a flag to the OEV to be able to run on 
> older edit logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HDFS-3644) OEV should recognize and deal with 0.20.20x opcode versions

2012-07-16 Thread Colin Patrick McCabe (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415770#comment-13415770
 ] 

Colin Patrick McCabe commented on HDFS-3644:


bq. That's the same proposal here: we error out with "Sorry, you cannot use the 
OEV on an edit log from this version of Hadoop." Instead of erroring out with 
"EofException" while trying to read a symlink target, which makes people think 
the log itself is corrupt.

Seems reasonable to me.

> OEV should recognize and deal with 0.20.20x opcode versions
> ---
>
> Key: HDFS-3644
> URL: https://issues.apache.org/jira/browse/HDFS-3644
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: tools
>Affects Versions: 2.0.0-alpha, 3.0.0
>Reporter: Todd Lipcon
>Priority: Minor
>
> We have some opcode conflicts for edit logs between 0.20.20x (LV -19, -31) vs 
> newer versions. For edit log loading, we dealt with this by forcing users to 
> save namespace on an earlier version before upgrading. But, using a trunk OEV 
> on an older version is useful since the OEV has had so many improvements. It 
> would be nice to be able to specify a flag to the OEV to be able to run on 
> older edit logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira