[ 
https://issues.apache.org/jira/browse/HDFS-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477584#comment-13477584
 ] 

Lars Hofhansl commented on HDFS-4060:
-------------------------------------

The sync to disk is not actually on a synchronous path as seen from the client, 
so there is a short race that the client returns but the metric was not updated.

See HDFS-3979, which would fix the issue, but appears to be stuck in discussion 
about what extra tests it would need, if any.

                
> TestHSync#testSequenceFileSync failed
> -------------------------------------
>
>                 Key: HDFS-4060
>                 URL: https://issues.apache.org/jira/browse/HDFS-4060
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eli Collins
>              Labels: test-fail
>
> TestHSync#testSequenceFileSync failed in the pre commit run of HDFS-4055.
> {noformat}
> java.lang.AssertionError: Bad value for metric FsyncCount expected:<2> but 
> was:<1>
>       at org.junit.Assert.fail(Assert.java:91)
>       at org.junit.Assert.failNotEquals(Assert.java:645)
>       at org.junit.Assert.assertEquals(Assert.java:126)
>       at org.junit.Assert.assertEquals(Assert.java:470)
>       at 
> org.apache.hadoop.test.MetricsAsserts.assertCounter(MetricsAsserts.java:228)
>       at 
> org.apache.hadoop.hdfs.server.datanode.TestHSync.checkSyncMetric(TestHSync.java:46)
>       at 
> org.apache.hadoop.hdfs.server.datanode.TestHSync.checkSyncMetric(TestHSync.java:49)
>       at 
> org.apache.hadoop.hdfs.server.datanode.TestHSync.testSequenceFileSync(TestHSync.java:158)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to