[jira] [Commented] (HDFS-4083) Protocol changes for snapshots

2012-10-19 Thread Tsz Wo (Nicholas), SZE (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480420#comment-13480420
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4083:
--

Need to update ClientProtocol.versionID.  Patch looks good other than that.

 Protocol changes for snapshots
 --

 Key: HDFS-4083
 URL: https://issues.apache.org/jira/browse/HDFS-4083
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: data-node, name-node
Affects Versions: Snapshot (HDFS-2802)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Attachments: HDFS-4083.patch, HDFS-4083.patch


 This jira addresses protobuf .proto definition and java protocol classes and 
 translation

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HDFS-4083) Protocol changes for snapshots

2012-10-19 Thread Suresh Srinivas (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480430#comment-13480430
 ] 

Suresh Srinivas commented on HDFS-4083:
---

bq. Need to update ClientProtocol.versionID. Patch looks good other than that.
We no longer update it because with protobuf changes, the protocols are always 
expected to be wire compatible.

 Protocol changes for snapshots
 --

 Key: HDFS-4083
 URL: https://issues.apache.org/jira/browse/HDFS-4083
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: data-node, name-node
Affects Versions: Snapshot (HDFS-2802)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Attachments: HDFS-4083.patch, HDFS-4083.patch


 This jira addresses protobuf .proto definition and java protocol classes and 
 translation

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HDFS-4083) Protocol changes for snapshots

2012-10-19 Thread Tsz Wo (Nicholas), SZE (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480445#comment-13480445
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-4083:
--

You are right.

+1 on the patch.

 Protocol changes for snapshots
 --

 Key: HDFS-4083
 URL: https://issues.apache.org/jira/browse/HDFS-4083
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: data-node, name-node
Affects Versions: Snapshot (HDFS-2802)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Attachments: HDFS-4083.patch, HDFS-4083.patch


 This jira addresses protobuf .proto definition and java protocol classes and 
 translation

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira