[jira] [Commented] (HDFS-4132) when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory
[
https://issues.apache.org/jira/browse/HDFS-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490020#comment-13490020
]
Hudson commented on HDFS-4132:
--
Integrated in Hadoop-Mapreduce-trunk #1245 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1245/])
HDFS-4132. When libwebhdfs is not enabled, nativeMiniDfsClient frees
uninitialized memory. Contributed by Colin Patrick McCabe. (Revision 1405149)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1405149
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/native_mini_dfs.c
> when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory
> ---
>
> Key: HDFS-4132
> URL: https://issues.apache.org/jira/browse/HDFS-4132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HDFS-4132.001.patch
>
>
> When libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory.
> Details: jconfStr is declared uninitialized...
> {code}
> struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
> {
> struct NativeMiniDfsCluster* cl = NULL;
> jobject bld = NULL, bld2 = NULL, cobj = NULL;
> jvalue val;
> JNIEnv *env = getJNIEnv();
> jthrowable jthr;
> jstring jconfStr;
> {code}
> and only initialized later if conf->webhdfsEnabled:
> {code}
> ...
> if (conf->webhdfsEnabled) {
> jthr = newJavaStr(env, DFS_WEBHDFS_ENABLED_KEY, &jconfStr);
> if (jthr) {
> printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
> ...
> {code}
> Then we try to free this uninitialized memory at the end, usually resulting
> in a crash.
> {code}
> (*env)->DeleteLocalRef(env, jconfStr);
> return cl;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4132) when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory
[
https://issues.apache.org/jira/browse/HDFS-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490012#comment-13490012
]
Hudson commented on HDFS-4132:
--
Integrated in Hadoop-Hdfs-trunk #1215 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1215/])
HDFS-4132. When libwebhdfs is not enabled, nativeMiniDfsClient frees
uninitialized memory. Contributed by Colin Patrick McCabe. (Revision 1405149)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1405149
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/native_mini_dfs.c
> when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory
> ---
>
> Key: HDFS-4132
> URL: https://issues.apache.org/jira/browse/HDFS-4132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HDFS-4132.001.patch
>
>
> When libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory.
> Details: jconfStr is declared uninitialized...
> {code}
> struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
> {
> struct NativeMiniDfsCluster* cl = NULL;
> jobject bld = NULL, bld2 = NULL, cobj = NULL;
> jvalue val;
> JNIEnv *env = getJNIEnv();
> jthrowable jthr;
> jstring jconfStr;
> {code}
> and only initialized later if conf->webhdfsEnabled:
> {code}
> ...
> if (conf->webhdfsEnabled) {
> jthr = newJavaStr(env, DFS_WEBHDFS_ENABLED_KEY, &jconfStr);
> if (jthr) {
> printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
> ...
> {code}
> Then we try to free this uninitialized memory at the end, usually resulting
> in a crash.
> {code}
> (*env)->DeleteLocalRef(env, jconfStr);
> return cl;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4132) when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory
[
https://issues.apache.org/jira/browse/HDFS-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489990#comment-13489990
]
Hudson commented on HDFS-4132:
--
Integrated in Hadoop-Yarn-trunk #25 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/25/])
HDFS-4132. When libwebhdfs is not enabled, nativeMiniDfsClient frees
uninitialized memory. Contributed by Colin Patrick McCabe. (Revision 1405149)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1405149
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/native_mini_dfs.c
> when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory
> ---
>
> Key: HDFS-4132
> URL: https://issues.apache.org/jira/browse/HDFS-4132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HDFS-4132.001.patch
>
>
> When libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory.
> Details: jconfStr is declared uninitialized...
> {code}
> struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
> {
> struct NativeMiniDfsCluster* cl = NULL;
> jobject bld = NULL, bld2 = NULL, cobj = NULL;
> jvalue val;
> JNIEnv *env = getJNIEnv();
> jthrowable jthr;
> jstring jconfStr;
> {code}
> and only initialized later if conf->webhdfsEnabled:
> {code}
> ...
> if (conf->webhdfsEnabled) {
> jthr = newJavaStr(env, DFS_WEBHDFS_ENABLED_KEY, &jconfStr);
> if (jthr) {
> printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
> ...
> {code}
> Then we try to free this uninitialized memory at the end, usually resulting
> in a crash.
> {code}
> (*env)->DeleteLocalRef(env, jconfStr);
> return cl;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4132) when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory
[
https://issues.apache.org/jira/browse/HDFS-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489740#comment-13489740
]
Hudson commented on HDFS-4132:
--
Integrated in Hadoop-trunk-Commit #2951 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/2951/])
HDFS-4132. When libwebhdfs is not enabled, nativeMiniDfsClient frees
uninitialized memory. Contributed by Colin Patrick McCabe. (Revision 1405149)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1405149
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/native_mini_dfs.c
> when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory
> ---
>
> Key: HDFS-4132
> URL: https://issues.apache.org/jira/browse/HDFS-4132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HDFS-4132.001.patch
>
>
> When libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory.
> Details: jconfStr is declared uninitialized...
> {code}
> struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
> {
> struct NativeMiniDfsCluster* cl = NULL;
> jobject bld = NULL, bld2 = NULL, cobj = NULL;
> jvalue val;
> JNIEnv *env = getJNIEnv();
> jthrowable jthr;
> jstring jconfStr;
> {code}
> and only initialized later if conf->webhdfsEnabled:
> {code}
> ...
> if (conf->webhdfsEnabled) {
> jthr = newJavaStr(env, DFS_WEBHDFS_ENABLED_KEY, &jconfStr);
> if (jthr) {
> printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
> ...
> {code}
> Then we try to free this uninitialized memory at the end, usually resulting
> in a crash.
> {code}
> (*env)->DeleteLocalRef(env, jconfStr);
> return cl;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4132) when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory
[
https://issues.apache.org/jira/browse/HDFS-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488925#comment-13488925
]
Todd Lipcon commented on HDFS-4132:
---
Looks good to me. I double checked that the spec says DeleteLocalRef(NULL) is a
no-op. +1, I'll commit this later today unless there are any other comments.
> when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory
> ---
>
> Key: HDFS-4132
> URL: https://issues.apache.org/jira/browse/HDFS-4132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HDFS-4132.001.patch
>
>
> When libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory.
> Details: jconfStr is declared uninitialized...
> {code}
> struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
> {
> struct NativeMiniDfsCluster* cl = NULL;
> jobject bld = NULL, bld2 = NULL, cobj = NULL;
> jvalue val;
> JNIEnv *env = getJNIEnv();
> jthrowable jthr;
> jstring jconfStr;
> {code}
> and only initialized later if conf->webhdfsEnabled:
> {code}
> ...
> if (conf->webhdfsEnabled) {
> jthr = newJavaStr(env, DFS_WEBHDFS_ENABLED_KEY, &jconfStr);
> if (jthr) {
> printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
> ...
> {code}
> Then we try to free this uninitialized memory at the end, usually resulting
> in a crash.
> {code}
> (*env)->DeleteLocalRef(env, jconfStr);
> return cl;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4132) when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory
[
https://issues.apache.org/jira/browse/HDFS-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488387#comment-13488387
]
Jing Zhao commented on HDFS-4132:
-
That's bug brought by HDFS-3923. Thanks for the fix Colin!
> when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory
> ---
>
> Key: HDFS-4132
> URL: https://issues.apache.org/jira/browse/HDFS-4132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HDFS-4132.001.patch
>
>
> When libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory.
> Details: jconfStr is declared uninitialized...
> {code}
> struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
> {
> struct NativeMiniDfsCluster* cl = NULL;
> jobject bld = NULL, bld2 = NULL, cobj = NULL;
> jvalue val;
> JNIEnv *env = getJNIEnv();
> jthrowable jthr;
> jstring jconfStr;
> {code}
> and only initialized later if conf->webhdfsEnabled:
> {code}
> ...
> if (conf->webhdfsEnabled) {
> jthr = newJavaStr(env, DFS_WEBHDFS_ENABLED_KEY, &jconfStr);
> if (jthr) {
> printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
> ...
> {code}
> Then we try to free this uninitialized memory at the end, usually resulting
> in a crash.
> {code}
> (*env)->DeleteLocalRef(env, jconfStr);
> return cl;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4132) when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory
[
https://issues.apache.org/jira/browse/HDFS-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488379#comment-13488379
]
Hadoop QA commented on HDFS-4132:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12551642/HDFS-4132.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3436//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3436//console
This message is automatically generated.
> when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory
> ---
>
> Key: HDFS-4132
> URL: https://issues.apache.org/jira/browse/HDFS-4132
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HDFS-4132.001.patch
>
>
> When libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized
> memory.
> Details: jconfStr is declared uninitialized...
> {code}
> struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
> {
> struct NativeMiniDfsCluster* cl = NULL;
> jobject bld = NULL, bld2 = NULL, cobj = NULL;
> jvalue val;
> JNIEnv *env = getJNIEnv();
> jthrowable jthr;
> jstring jconfStr;
> {code}
> and only initialized later if conf->webhdfsEnabled:
> {code}
> ...
> if (conf->webhdfsEnabled) {
> jthr = newJavaStr(env, DFS_WEBHDFS_ENABLED_KEY, &jconfStr);
> if (jthr) {
> printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
> ...
> {code}
> Then we try to free this uninitialized memory at the end, usually resulting
> in a crash.
> {code}
> (*env)->DeleteLocalRef(env, jconfStr);
> return cl;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
