[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534857#comment-13534857
]
Hudson commented on HDFS-4307:
--
Integrated in Hadoop-Hdfs-0.23-Build #467 (See
[https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/467/])
Revert HDFS-4307 (Revision 1423066)
HDFS-4307. SocketCache should use monotonic time (Colin Patrick McCabe via
tgraves) (Revision 1422971)
Result = UNSTABLE
tgraves :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1423066
Files :
*
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/SocketCache.java
tgraves :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1422971
Files :
*
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/SocketCache.java
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532313#comment-13532313
]
Hudson commented on HDFS-4307:
--
Integrated in Hadoop-Mapreduce-trunk #1285 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1285/])
HDFS-4307. SocketCache should use monotonic time. Contributed by Colin
Patrick McCabe. (Revision 1421572)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1421572
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/SocketCache.java
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532286#comment-13532286
]
Hudson commented on HDFS-4307:
--
Integrated in Hadoop-Hdfs-trunk #1254 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1254/])
HDFS-4307. SocketCache should use monotonic time. Contributed by Colin
Patrick McCabe. (Revision 1421572)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1421572
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/SocketCache.java
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532229#comment-13532229
]
Hudson commented on HDFS-4307:
--
Integrated in Hadoop-Yarn-trunk #65 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/65/])
HDFS-4307. SocketCache should use monotonic time. Contributed by Colin
Patrick McCabe. (Revision 1421572)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1421572
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/SocketCache.java
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531578#comment-13531578
]
Hudson commented on HDFS-4307:
--
Integrated in Hadoop-trunk-Commit #3121 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/3121/])
HDFS-4307. SocketCache should use monotonic time. Contributed by Colin
Patrick McCabe. (Revision 1421572)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1421572
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/SocketCache.java
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531560#comment-13531560
]
Aaron T. Myers commented on HDFS-4307:
--
+1, the latest patch looks good to me. I agree that writing a test for this
isn't warranted in this case.
I'm going to commit this momentarily.
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530552#comment-13530552
]
Colin Patrick McCabe commented on HDFS-4307:
yeah, sadly changing the system clock is not something a junit test can
realistically do :)
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530532#comment-13530532
]
Andy Isaacson commented on HDFS-4307:
-
bq. HDFS-4307.002.patch
LGTM! +1.
Since the patch has no observable effects short of changing the system clock,
the lack of tests included is justified.
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530519#comment-13530519
]
Hadoop QA commented on HDFS-4307:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12560652/HDFS-4307.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3651//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3651//console
This message is automatically generated.
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HDFS-4307.001.patch, HDFS-4307.002.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530308#comment-13530308
]
Hadoop QA commented on HDFS-4307:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12560613/HDFS-4307.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/3650//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3650//console
This message is automatically generated.
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HDFS-4307.001.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4307) SocketCache should use monotonic time
[
https://issues.apache.org/jira/browse/HDFS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530282#comment-13530282
]
Andy Isaacson commented on HDFS-4307:
-
bq. {{+ private static long getMonotonicMillis() {}}
Seems like this could use org/apache/hadoop/util/Time.java:monotonicNow rather
than rolling a local copy.
bq. {{+return System.nanoTime() / 1000;}}
Alas, there are 1e6 nanoseconds per millisecond. (So just use the library
routine which gets it right.)
> SocketCache should use monotonic time
> -
>
> Key: HDFS-4307
> URL: https://issues.apache.org/jira/browse/HDFS-4307
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HDFS-4307.001.patch
>
>
> {{SocketCache}} should use monotonic time, not wall-clock time. Otherwise,
> if the time is adjusted by ntpd or a system administrator, sockets could be
> either abrupbtly expired, or left in the cache indefinitely.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
