[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687454#comment-13687454 ] Fengdong Yu commented on HDFS-4533: --- I reopened this issue, because there is a minor bug, which I found during my upgrade test. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Assignee: Fengdong Yu Labels: patch Fix For: 2.1.0-beta Attachments: HDFS-4533_2.patch, HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687503#comment-13687503 ] Suresh Srinivas commented on HDFS-4533: --- Can you describe what the bug is? Also please open another Jira, add a link to that Jira in this Jira, instead of reopening this Jira. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Assignee: Fengdong Yu Labels: patch Fix For: 2.1.0-beta Attachments: HDFS-4533_2.patch, HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687512#comment-13687512
]
Fengdong Yu commented on HDFS-4533:
---
there is a typo, I've uploaded the patch here.
{code}
nameStartOpt=$nameStartOpts $@
{code}
it should be:
{code}
nameStartOpt=$nameStartOpt $@
{code}
I will open a new JIRA. Thanks.
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Assignee: Fengdong Yu
Labels: patch
Fix For: 2.1.0-beta
Attachments: HDFS-4533_2.patch, HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687543#comment-13687543 ] Suresh Srinivas commented on HDFS-4533: --- I should have done a better job code reviewing this. In fact I might have been the reason for this - see https://issues.apache.org/jira/browse/HDFS-4533?focusedCommentId=13597719page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13597719 Thanks for the follow up [~azuryy] start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Assignee: Fengdong Yu Labels: patch Fix For: 2.1.0-beta Attachments: HDFS-4533_2.patch, HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687565#comment-13687565
]
Hadoop QA commented on HDFS-4533:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12588502/HDFS-4533_2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4534//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4534//console
This message is automatically generated.
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Assignee: Fengdong Yu
Labels: patch
Fix For: 2.1.0-beta
Attachments: HDFS-4533_2.patch, HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13685856#comment-13685856 ] Suresh Srinivas commented on HDFS-4533: --- [~azuryy] I added you as HDFS contributor and assigned this jira to you. Congrats and look forward to more contributions! start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Assignee: Fengdong Yu Labels: patch Fix For: 2.1.0-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686386#comment-13686386 ] Fengdong Yu commented on HDFS-4533: --- Thanks, Suresh. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Assignee: Fengdong Yu Labels: patch Fix For: 2.1.0-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684194#comment-13684194
]
Fengdong Yu commented on HDFS-4533:
---
Hi Suresh,
My ICLA was confirmed, the following is from the Secretary e-mail.
{quote}
Dear Azuryy Yu,
This message acknowledges receipt of your ICLA, which has been filed in the
Apache Software Foundation records.
If you have been invited as a committer, please advise the project PMC that
your ICLA has been filed.
Warm Regards,
-- Craig L Russell
Secretary, Apache Software Foundation
{quote}
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Labels: patch
Fix For: 2.1.0-beta
Attachments: HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683127#comment-13683127 ] Fengdong Yu commented on HDFS-4533: --- Hi Suresh, I've send email to submit icla, Thanks. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.1.0-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683060#comment-13683060 ] Fengdong Yu commented on HDFS-4533: --- Hi Suresh, I Just noticed this issue was fixed, sorry for response later. I will file icla soon. Thanks. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.1.0-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655726#comment-13655726 ] Suresh Srinivas commented on HDFS-4533: --- [~azuryy] Can you please file icla - http://www.apache.org/licenses/icla.txt. Once you do that, I will add you as a contributor and assign this jira to you. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655228#comment-13655228 ] Hudson commented on HDFS-4533: -- Integrated in Hadoop-Yarn-trunk #206 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/206/]) HDFS-4533. start-dfs.sh ignores additional parameters besides -upgrade. Contributed by Fengdong Yu. (Revision 1481178) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1481178 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655257#comment-13655257 ] Hudson commented on HDFS-4533: -- Integrated in Hadoop-Hdfs-trunk #1395 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1395/]) HDFS-4533. start-dfs.sh ignores additional parameters besides -upgrade. Contributed by Fengdong Yu. (Revision 1481178) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1481178 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13655285#comment-13655285 ] Hudson commented on HDFS-4533: -- Integrated in Hadoop-Mapreduce-trunk #1422 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1422/]) HDFS-4533. start-dfs.sh ignores additional parameters besides -upgrade. Contributed by Fengdong Yu. (Revision 1481178) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1481178 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13654662#comment-13654662 ] Suresh Srinivas commented on HDFS-4533: --- [~cmccabe] Can you explain how after the patch the invalid option is ignored? Did you run this command with the patch? start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13654691#comment-13654691
]
Colin Patrick McCabe commented on HDFS-4533:
I ran the command with the patch, and {{./sbin/start-dfs.sh -crazygonuts}} was
rejected. However, {{./sbin/start-dfs.sh -upgrade -crazygonuts}} was accepted
without a visible error message.
Given that the obvious error handling cases are covered, I withdraw my earlier
objection. I still think we should add a way to pass arguments to the other
daemons, but I suppose that can be added in a separate JIRA when we actually
need it.
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Labels: patch
Fix For: 2.0.5-beta
Attachments: HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13654807#comment-13654807 ] Hudson commented on HDFS-4533: -- Integrated in Hadoop-trunk-Commit #3739 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3739/]) HDFS-4533. start-dfs.sh ignores additional parameters besides -upgrade. Contributed by Fengdong Yu. (Revision 1481178) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1481178 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605492#comment-13605492
]
Colin Patrick McCabe commented on HDFS-4533:
I think I would rather have something like this:
{code}
usage=Usage: start-dfs.sh [-upgrade|-rollback] [-nnOpt additional NameNode
options]
{code}
that way you could do something like this:
{code}
./start-dfs.sh -nnOpt '-clusterId 123'
{code}
That way, it would be easy for us to add a way to pass options to the
{{JournalNode}}, {{DataNode}}, etc. in the future. Just dumping everything we
can't parse into the NameNode arguments seems suboptimal... and will prevent us
giving helpful error messages when the user messes up.
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Labels: patch
Fix For: 2.0.5-beta
Attachments: HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605500#comment-13605500 ] Suresh Srinivas commented on HDFS-4533: --- +1 for the patch. Colin, please file another jira to do what you suggested. Personally I do not think it is such a good idea. The current patch looks good to me. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605585#comment-13605585
]
Colin Patrick McCabe commented on HDFS-4533:
Hi Suresh,
My concern is that this change will regress error handling.
Before the patch:
{code}
cmccabe@keter:/h ./sbin/start-dfs.sh -crazygonuts
Usage: start-dfs.sh [-upgrade|-rollback]
{code}
After the patch:
{code}
cmccabe@keter:/h ./sbin/start-dfs.sh -crazygonuts
[... silently does the wrong thing ...]
{code}
Does that make sense?
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Labels: patch
Fix For: 2.0.5-beta
Attachments: HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13598471#comment-13598471 ] Fengdong Yu commented on HDFS-4533: --- Hi suresh, I did manually test on our cluster. It does work well. I changed the patch to using $@ instead of while loop. I generate patch under svn: hadoop/common/branches/branch-2.0.3-alpha/hadoop-hdfs-project/hadoop-hdfs/src/main/bin, I don't think this a wrong svn directory for my patch. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13598473#comment-13598473 ] Fengdong Yu commented on HDFS-4533: --- should I generate patch under svn: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin ? start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13598474#comment-13598474
]
Hadoop QA commented on HDFS-4533:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12573006/HDFS-4533.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4067//console
This message is automatically generated.
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Labels: patch
Fix For: 2.0.5-beta
Attachments: HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[ https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13598478#comment-13598478 ] Fengdong Yu commented on HDFS-4533: --- Generate patch against trunk revision. start-dfs.sh ignored additional parameters besides -upgrade --- Key: HDFS-4533 URL: https://issues.apache.org/jira/browse/HDFS-4533 Project: Hadoop HDFS Issue Type: Bug Components: datanode, namenode Affects Versions: 2.0.3-alpha Reporter: Fengdong Yu Labels: patch Fix For: 2.0.5-beta Attachments: HDFS-4533.patch start-dfs.sh only takes -upgrade option and ignored others. So If run the following command, it will ignore the clusterId option. start-dfs.sh -upgrade -clusterId 1234 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13598505#comment-13598505
]
Hadoop QA commented on HDFS-4533:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12573007/HDFS-4533.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.datanode.TestDataDirs
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4069//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4069//console
This message is automatically generated.
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Labels: patch
Fix For: 2.0.5-beta
Attachments: HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4533) start-dfs.sh ignored additional parameters besides -upgrade
[
https://issues.apache.org/jira/browse/HDFS-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597719#comment-13597719
]
Suresh Srinivas commented on HDFS-4533:
---
Instead of the while loop the following code will add the remaining options,
right?
{code}
nameStartOpt=$nameStartOpts $@
{code}
Did you manually test this?
start-dfs.sh ignored additional parameters besides -upgrade
---
Key: HDFS-4533
URL: https://issues.apache.org/jira/browse/HDFS-4533
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode, namenode
Affects Versions: 2.0.3-alpha
Reporter: Fengdong Yu
Labels: patch
Fix For: 2.0.5-beta
Attachments: HDFS-4533.patch
start-dfs.sh only takes -upgrade option and ignored others.
So If run the following command, it will ignore the clusterId option.
start-dfs.sh -upgrade -clusterId 1234
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
