[jira] [Commented] (HDFS-4669) org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager fails using IBM java

2013-04-09 Thread Chris Nauroth (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626925#comment-13626925
 ] 

Chris Nauroth commented on HDFS-4669:
-

+1 for the patch.  I verified that the test passes on Mac and Windows.  Thank 
you, Tian!

 org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager fails using IBM 
 java
 

 Key: HDFS-4669
 URL: https://issues.apache.org/jira/browse/HDFS-4669
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: test
Affects Versions: 2.0.3-alpha
Reporter: Tian Hong Wang
  Labels: patch
 Fix For: 2.0.3-alpha

 Attachments: HADOOP-4669.patch


 TestBlockPoolManager unit test fails with the following error message using 
 IBM java:
 testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager)
   Time elapsed: 27 sec   FAILURE!
 org.junit.ComparisonFailure: expected:stop #[1
 refresh #2]
  but was:stop #[2
 refresh #1]
 
 The root cause is:
 (1)if we want to remove the first NS, keep the second NS, it should be 
 conf.set(DFSConfigKeys.DFS_NAMESERVICES, ns2), not 
 conf.set(DFSConfigKeys.DFS_NAMESERVICES, ns1).
 (2)Since HashMap  HashSet store the data in the random order way, so in ibm 
 java  Oracle java, HashMap get the random order key, value that causing 
 the random ns1ns2 value.  So in the code, it should use LinkedHashMap  
 LinkedHashSet to keep the original order.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-4669) org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager fails using IBM java

2013-04-08 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625453#comment-13625453
 ] 

Hadoop QA commented on HDFS-4669:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12577529/HADOOP-4669.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/4196//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4196//console

This message is automatically generated.

 org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager fails using IBM 
 java
 

 Key: HDFS-4669
 URL: https://issues.apache.org/jira/browse/HDFS-4669
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: test
Affects Versions: 2.0.3-alpha
Reporter: Tian Hong Wang
  Labels: patch
 Fix For: 2.0.3-alpha

 Attachments: HADOOP-4669.patch


 TestBlockPoolManager unit test fails with the following error message using 
 IBM java:
 testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager)
   Time elapsed: 27 sec   FAILURE!
 org.junit.ComparisonFailure: expected:stop #[1
 refresh #2]
  but was:stop #[2
 refresh #1]
 
 The root cause is:
 (1)if we want to remove the first NS, keep the second NS, it should be 
 conf.set(DFSConfigKeys.DFS_NAMESERVICES, ns2), not 
 conf.set(DFSConfigKeys.DFS_NAMESERVICES, ns1).
 (2)Since HashMap  HashSet store the data in the random order way, so in ibm 
 java  Oracle java, HashMap get the random order key, value that causing 
 the random ns1ns2 value.  So in the code, it should use LinkedHashMap  
 LinkedHashSet to keep the original order.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira