[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632119#comment-13632119 ] Hadoop QA commented on HDFS-4698: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12578767/HDFS-4698.001.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1 warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4252//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/4252//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4252//console This message is automatically generated. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640059#comment-13640059 ] Aaron T. Myers commented on HDFS-4698: -- Patch looks pretty good to me, though I do believe the findbugs warning is legitimate. A few little comments: # It looks to me like the patch misses a place in DFSInputStream where it should be adding to the statistics before closing a BlockReader. Currently the patch only adds the stats in DFSInputStream#blockSeekTo, but I think they should also be added in DFSInputStream#close. # Recommend you add a comment to DFSInputStream#getReadStatistics about how to use the API, i.e. that the stats will only be up-to-date after closing the DFSInputStream. # Recommend adding comments to DFSInputStream.ReadStatistics explaining the meaning of the various fields, i.e. that SCR bytes will count for both SCR and "local bytes", that total >= local >= SCR, that remote bytes read can be determined by total - local, etc. # For that matter, you might want to add a getRemoteBytesRead method to DFSInputStream.ReadStatistics to do the subtraction for the user. # Any thoughts about how this new feature should interact with the existing FileSystem#Statistics class? Valid answers include "not at all" and/or "this will be helpful as-is, we can think about that later." > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640739#comment-13640739 ] Colin Patrick McCabe commented on HDFS-4698: Thanks for the review. Looking at this again, I think it would not be too difficult to update the stats after every read, rather than just after close. That will make it a lot more useful, I think. bq. Recommend adding comments to DFSInputStream.ReadStatistics explaining the meaning of the various fields, i.e. that SCR bytes will count for both SCR and "local bytes", that total >= local >= SCR, that remote bytes read can be determined by total - local, etc. OK. bq. For that matter, you might want to add a getRemoteBytesRead method to DFSInputStream.ReadStatistics to do the subtraction for the user. Will add. bq. Any thoughts about how this new feature should interact with the existing FileSystem#Statistics class? Valid answers include "not at all" and/or "this will be helpful as-is, we can think about that later." The per-file metrics introduced by this change are helpful when you just want to know how many bytes you've read out of a currently open file, or whether or not you are getting short-circuit local reads most of the time when reading a currently open file. {{FileSystem#Statistics}} is more about aggregate statistics for the client as a whole. I'm a little more hesitant to add this kind of information to there for a few reasons. One is that {{FileSystem#Statistics}} is supposed to be generic to all filesystems, but SCR is somewhat of an implementation detail of HDFS. The other is that we currently update those stats from multiple threads after every read or write operation. So they are correspondingly more expensive in terms of CPU time. I think the tl;dr is that we should think about that later. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640762#comment-13640762 ] Aaron T. Myers commented on HDFS-4698: -- bq. I think it would not be too difficult to update the stats after every read, rather than just after close. That will make it a lot more useful, I think. I think this is a good idea, if only to make the interface more easily understood. Though not a bug per se, it's a little odd to continue to be accessing an (Input|Output)Stream after having called close on it. bq. I think the tl;dr is that we should think about that later. Makes sense to me. Thanks for thinking about it. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641205#comment-13641205 ] Hadoop QA commented on HDFS-4698: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12580399/HDFS-4698.002.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.TestDatanodeJsp {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4312//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4312//console This message is automatically generated. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644876#comment-13644876 ] Hadoop QA commented on HDFS-4698: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12581027/HDFS-4698.003.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4337//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4337//console This message is automatically generated. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652251#comment-13652251 ] Aaron T. Myers commented on HDFS-4698: -- Latest patch looks pretty good to me. Two comments, one question: # Recommend you move the comments for totalBytesRead, totalLocalBytesRead, etc. from the member variables to the methods, and make them proper javadocs. That way people who are programming against this API in IDEs will see the comments when calling these methods, rather than having to look at the code for the private member variables. # In the test, recommend you use the JUnit Assume feature, instead of returning early in the event the domain socket didn't load, so that the test shows up properly as having been skipped in maven runs. # Any thoughts about adding this to the libhdfs API as well? Could certainly do that in a separate JIRA, if you'd like. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652660#comment-13652660 ] Colin Patrick McCabe commented on HDFS-4698: bq. 1. Recommend you move the comments for totalBytesRead, totalLocalBytesRead, etc. from the member variables to the methods, and make them proper javadocs. That way people who are programming against this API in IDEs will see the comments when calling these methods, rather than having to look at the code for the private member variables. Make sense, added. bq. 2. In the test, recommend you use the JUnit Assume feature, instead of returning early in the event the domain socket didn't load, so that the test shows up properly as having been skipped in maven runs. OK. bq. Any thoughts about adding this to the libhdfs API as well? Could certainly do that in a separate JIRA, if you'd like. Good idea. I added it to the libhdfs API and added a unit test to {{test_libhdfs_threaded}}. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652667#comment-13652667 ] gongsuochen commented on HDFS-4698: --- hello, all how could I unsubscribe from this list? > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652713#comment-13652713 ] Hadoop QA commented on HDFS-4698: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12582413/HDFS-4698.005.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4368//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4368//console This message is automatically generated. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653353#comment-13653353 ] Aaron T. Myers commented on HDFS-4698: -- The latest patch looks great to me. Just two little comments. +1 once these are addressed: # Recommend you add a javadoc to getRemoteBytesRead similar to the other methods. # Recommend you add totalRemoteBytesRead to the hdfsReadStatistics struct in libhdfs. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653403#comment-13653403 ] Hadoop QA commented on HDFS-4698: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12582548/HDFS-4698.006.patch against trunk revision . {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4371//console This message is automatically generated. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653432#comment-13653432 ] Hadoop QA commented on HDFS-4698: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12582549/HDFS-4698.007.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:red}-1 javac{color:red}. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4373//console This message is automatically generated. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653510#comment-13653510 ] Hadoop QA commented on HDFS-4698: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12582561/HDFS-4698.008.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4375//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4375//console This message is automatically generated. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch, HDFS-4698.008.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653580#comment-13653580 ] Colin Patrick McCabe commented on HDFS-4698: Test failure is unrelated to the patch. It is HDFS-3538 > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch, HDFS-4698.008.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654666#comment-13654666 ] Aaron T. Myers commented on HDFS-4698: -- +1, the latest patch looks good to me. I'm going to commit this momentarily. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch, HDFS-4698.008.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654670#comment-13654670 ] Hudson commented on HDFS-4698: -- Integrated in Hadoop-trunk-Commit #3737 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3737/]) HDFS-4698. Provide client-side metrics for remote reads, local reads, and short-circuit reads. Contributed by Colin Patrick McCabe. (Revision 1481121) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1481121 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/hdfs_web.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReader.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsDataInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.h * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch, HDFS-4698.008.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655226#comment-13655226 ] Hudson commented on HDFS-4698: -- Integrated in Hadoop-Yarn-trunk #206 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/206/]) HDFS-4698. Provide client-side metrics for remote reads, local reads, and short-circuit reads. Contributed by Colin Patrick McCabe. (Revision 1481121) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1481121 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/hdfs_web.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReader.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsDataInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.h * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 3.0.0 > > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch, HDFS-4698.008.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655255#comment-13655255 ] Hudson commented on HDFS-4698: -- Integrated in Hadoop-Hdfs-trunk #1395 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1395/]) HDFS-4698. Provide client-side metrics for remote reads, local reads, and short-circuit reads. Contributed by Colin Patrick McCabe. (Revision 1481121) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1481121 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/hdfs_web.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReader.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsDataInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.h * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 3.0.0 > > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch, HDFS-4698.008.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655283#comment-13655283 ] Hudson commented on HDFS-4698: -- Integrated in Hadoop-Mapreduce-trunk #1422 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1422/]) HDFS-4698. Provide client-side metrics for remote reads, local reads, and short-circuit reads. Contributed by Colin Patrick McCabe. (Revision 1481121) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1481121 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/libwebhdfs/src/hdfs_web.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReader.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocal.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderLocalLegacy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/client/HdfsDataInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.h * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 3.0.0 > > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch, HDFS-4698.008.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4698) provide client-side metrics for remote reads, local reads, and short-circuit reads
[ https://issues.apache.org/jira/browse/HDFS-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667100#comment-13667100 ] Suresh Srinivas commented on HDFS-4698: --- I did not find the description of this jira in CHANGES.txt in branch-2. I have added it. > provide client-side metrics for remote reads, local reads, and short-circuit > reads > -- > > Key: HDFS-4698 > URL: https://issues.apache.org/jira/browse/HDFS-4698 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.0.4-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 3.0.0, 2.0.5-beta > > Attachments: HDFS-4698.001.patch, HDFS-4698.002.patch, > HDFS-4698.003.patch, HDFS-4698.004.patch, HDFS-4698.005.patch, > HDFS-4698.006.patch, HDFS-4698.007.patch, HDFS-4698.008.patch > > > We should provide metrics to let clients know how many bytes of data they > have read remotely, versus locally or via short-circuit local reads. This > will allow clients to know how well they're doing at bringing the computation > to the data, which will be useful in evaluating placement policies and > cluster configurations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira