[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303878#comment-14303878 ] Akira AJISAKA commented on HDFS-4922: - The configurable parameters have been removed from the document, so the patch can not be applied. Adding "dfs.client.read.shortcircuit.buffer.size" to hdfs-site.xml is fine for me. hdfs-site.xml describes most of the configurable parameters except for "dfs.client.read.shortcircuit.buffer.size". > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, > HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922-006.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290112#comment-14290112
]
Hadoop QA commented on HDFS-4922:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622806/HDFS-4922-006.patch
against trunk revision 6c3fec5.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9317//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch,
> HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922-006.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290101#comment-14290101 ] Allen Wittenauer commented on HDFS-4922: If someone updates this, we can get this committed :) > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, > HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922-006.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150189#comment-14150189
]
Hadoop QA commented on HDFS-4922:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622806/HDFS-4922-006.patch
against trunk revision 6b7673e.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8227//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch,
> HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922-006.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870568#comment-13870568
]
Hadoop QA commented on HDFS-4922:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622806/HDFS-4922-006.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5869//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5869//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch,
> HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922-006.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870511#comment-13870511 ] Akira AJISAKA commented on HDFS-4922: - LGTM +1. Thank you, [~azuryy]! > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, > HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922-006.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870474#comment-13870474 ] Fengdong Yu commented on HDFS-4922: --- Hi [~ajisakaa], I refreshed the patch, and I'll file a separate jira to describe these parameters in the hdfs-default.xml. Thanks. > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, > HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922-006.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870400#comment-13870400
]
Akira AJISAKA commented on HDFS-4922:
-
Thanks for updating! Minor comment:
{code}
+ Local block reader maintains a chunk buffer, This controls the maximum chunks
+ can be filled in the chunk buffer for each read.
+ The buffer size was specified in bytes, but
+ It would be better to be integral multiple of "dfs.bytes-per-checksum"
{code}
Some capital letters can be converted to small. Below fix is good to me.
{code}
+ Local block reader maintains a chunk buffer, this controls the maximum chunks
+ can be filled in the chunk buffer for each read.
+ The buffer size was specified in bytes. It would be better to be integral
+ multiple of "dfs.bytes-per-checksum" for better performance.
{code}
Also, now these parameters are not described in hdfs-default.xml. Would you add
them?
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch,
> HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867532#comment-13867532
]
Hadoop QA commented on HDFS-4922:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622336/HDFS-4922-005.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5859//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5859//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch,
> HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867464#comment-13867464 ] Fengdong Yu commented on HDFS-4922: --- Thanks [~ajisakaa] for renew the patch, [~cmccabe] review. I uploaded a new patch to address all the comments. > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, > HDFS-4922-004.patch, HDFS-4922-005.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866841#comment-13866841
]
Colin Patrick McCabe commented on HDFS-4922:
{code}
+ Local block reader maintains a chunk buffer, This controls the maximum chunks
+ can be filled in the chunk buffer for each read.
+ It would be better to be integral multiple of "dfs.bytes-per-checksum"
{code}
You should mention that this is specified in terms of bytes.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch,
> HDFS-4922-004.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866611#comment-13866611
]
Hadoop QA commented on HDFS-4922:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622145/HDFS-4922-004.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5853//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5853//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch,
> HDFS-4922-004.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866590#comment-13866590
]
Hadoop QA commented on HDFS-4922:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622145/HDFS-4922-004.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5852//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5852//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch,
> HDFS-4922-004.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866487#comment-13866487 ] Akira AJISAKA commented on HDFS-4922: - HDFS-4710 is already resolved, so the patch is ready to merge. However, the patch command failed to apply. I'll renew the patch. > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758393#comment-13758393 ] Colin Patrick McCabe commented on HDFS-4922: It seems like both this issue (HDFS-4922) and the dfs.client.read.shortcircuit.buffer.size fix, HDFS-4710, still haven't been committed. Am I missing something? > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750915#comment-13750915 ] Fengdong Yu commented on HDFS-4922: --- I've noticed this issue was commited in the trunk, [~cmccabe] can you close this issue? Thanks. > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13695209#comment-13695209 ] Fengdong Yu commented on HDFS-4922: --- bq.what I mean is, let's commit HDFS-4710 first. Okay, I linked to HDFS-4710. > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694906#comment-13694906 ] Colin Patrick McCabe commented on HDFS-4922: what I mean is, let's commit HDFS-4710 first. > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694451#comment-13694451
]
Hadoop QA commented on HDFS-4922:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12589825/HDFS-4922-002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4570//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4570//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694448#comment-13694448
]
Hadoop QA commented on HDFS-4922:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12589826/HDFS-4922-003.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4571//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4571//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694440#comment-13694440
]
Hadoop QA commented on HDFS-4922:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12589819/HDFS-4922.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4569//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4569//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922-002.patch, HDFS-4922-003.patch, HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694420#comment-13694420 ] Fengdong Yu commented on HDFS-4922: --- bq.The fact that dfs.client.read.shortcircuit.buffer.size is sometimes ignored is a bug. There's a JIRA to fix it, HDFS-4710. I looked at HDFS-4710, Thanks,I uploaded a new patch. > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922-002.patch, HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694395#comment-13694395
]
Colin Patrick McCabe commented on HDFS-4922:
{code}
+ * dfs.client.read.shortcircuit.buffer.size
+
+ If 'dfs.client.read.shortcircuit.skip.checkusm' is true, then this will be
ignored.
+ Local block reader maintains a chunk buffer, This controls the maximux
chunks
+ can be filled in the chunk buffer for each read.
+ It would be better to be integral multiple of "dfs.bytes-per-checksum"
{code}
The fact that {{dfs.client.read.shortcircuit.buffer.size}} is sometimes ignored
is a bug. There's a JIRA to fix it, HDFS-4710.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[ https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689331#comment-13689331 ] Fengdong Yu commented on HDFS-4922: --- can any body review the patch? > Improve the short-circuit document > -- > > Key: HDFS-4922 > URL: https://issues.apache.org/jira/browse/HDFS-4922 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation, hdfs-client >Affects Versions: 3.0.0, 2.1.0-beta >Reporter: Fengdong Yu >Assignee: Fengdong Yu >Priority: Minor > Attachments: HDFS-4922.patch > > > explain the default value and add one configure key, which doesn't show in > the document, but exists in the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4922) Improve the short-circuit document
[
https://issues.apache.org/jira/browse/HDFS-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688992#comment-13688992
]
Hadoop QA commented on HDFS-4922:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12588765/HDFS-4922.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/4548//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4548//console
This message is automatically generated.
> Improve the short-circuit document
> --
>
> Key: HDFS-4922
> URL: https://issues.apache.org/jira/browse/HDFS-4922
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, hdfs-client
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Fengdong Yu
>Assignee: Fengdong Yu
>Priority: Minor
> Attachments: HDFS-4922.patch
>
>
> explain the default value and add one configure key, which doesn't show in
> the document, but exists in the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
