[ https://issues.apache.org/jira/browse/HDFS-5095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739744#comment-13739744 ]
Suresh Srinivas commented on HDFS-5095: --------------------------------------- Before this change the metrics name is "NameNode" as you noted. With the patch the metrics name is IPCLoggerChannel-<address>-<port> and is collected at the namenode. Instead of this, we could use a name such "NameNode-qjournal-<Address>-<port>? Also please add a unit test. > Using JournalNode IP as name of IPCLoggerChannel metrics record > --------------------------------------------------------------- > > Key: HDFS-5095 > URL: https://issues.apache.org/jira/browse/HDFS-5095 > Project: Hadoop HDFS > Issue Type: Task > Components: qjm > Affects Versions: 2.0.5-alpha > Reporter: LiuLei > Attachments: IPCLoggerChannelMetrics.java.patch, metrics.jpg > > > I use QJM for HA, IPCLoggerChannelMetrics class use "NameNode" as metrics > record name, so metrics record of all JournalNode are displayed together in > ganglia. If every JournalNode display metrics record in difference name that > is better. I think use JournalNode IP as the name is better. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira