[jira] [Commented] (HDFS-5099) Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing
[ https://issues.apache.org/jira/browse/HDFS-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742277#comment-13742277 ] Hudson commented on HDFS-5099: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1520 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1520/]) HDFS-5099. Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing. Contributed by Chuan Liu. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1514481) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon > finishing > --- > > Key: HDFS-5099 > URL: https://issues.apache.org/jira/browse/HDFS-5099 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 3.0.0, 2.1.1-beta >Reporter: Chuan Liu >Assignee: Chuan Liu > Fix For: 3.0.0, 2.1.1-beta > > Attachments: HDFS-5099-trunk.patch > > > In {{Namenode#copyEditLogSegmentsToSharedDir()}} method, we open a collection > of EditLogInputStreams to read and apply to shareEditlog. In {{readOpt()}} > method, we will open the underlying log file on disk. After applying all the > opts, we do not close the collection of streams currently. This lead to a > file handle leak on Windows as later we would fail to delete those files. > This happens in TestInitializeSharedEdits test case, where we explicitly > called {{Namenode# initializeSharedEdits()}}, where > {{copyEditLogSegmentsToSharedDir()}} is used. Later we fail to create new > MiniDFSCluster with the following exception. > {noformat} > java.io.IOException: Could not fully delete > C:\hdc\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\name1 > at > org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:759) > at > org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:644) > at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:334) > at > org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:316) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits.setupCluster(TestInitializeSharedEdits.java:68) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > … > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5099) Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing
[ https://issues.apache.org/jira/browse/HDFS-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742205#comment-13742205 ] Hudson commented on HDFS-5099: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1493 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1493/]) HDFS-5099. Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing. Contributed by Chuan Liu. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1514481) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon > finishing > --- > > Key: HDFS-5099 > URL: https://issues.apache.org/jira/browse/HDFS-5099 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 3.0.0, 2.1.1-beta >Reporter: Chuan Liu >Assignee: Chuan Liu > Fix For: 3.0.0, 2.1.1-beta > > Attachments: HDFS-5099-trunk.patch > > > In {{Namenode#copyEditLogSegmentsToSharedDir()}} method, we open a collection > of EditLogInputStreams to read and apply to shareEditlog. In {{readOpt()}} > method, we will open the underlying log file on disk. After applying all the > opts, we do not close the collection of streams currently. This lead to a > file handle leak on Windows as later we would fail to delete those files. > This happens in TestInitializeSharedEdits test case, where we explicitly > called {{Namenode# initializeSharedEdits()}}, where > {{copyEditLogSegmentsToSharedDir()}} is used. Later we fail to create new > MiniDFSCluster with the following exception. > {noformat} > java.io.IOException: Could not fully delete > C:\hdc\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\name1 > at > org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:759) > at > org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:644) > at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:334) > at > org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:316) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits.setupCluster(TestInitializeSharedEdits.java:68) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > … > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5099) Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing
[ https://issues.apache.org/jira/browse/HDFS-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742090#comment-13742090 ] Hudson commented on HDFS-5099: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #303 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/303/]) HDFS-5099. Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing. Contributed by Chuan Liu. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1514481) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon > finishing > --- > > Key: HDFS-5099 > URL: https://issues.apache.org/jira/browse/HDFS-5099 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 3.0.0, 2.1.1-beta >Reporter: Chuan Liu >Assignee: Chuan Liu > Fix For: 3.0.0, 2.1.1-beta > > Attachments: HDFS-5099-trunk.patch > > > In {{Namenode#copyEditLogSegmentsToSharedDir()}} method, we open a collection > of EditLogInputStreams to read and apply to shareEditlog. In {{readOpt()}} > method, we will open the underlying log file on disk. After applying all the > opts, we do not close the collection of streams currently. This lead to a > file handle leak on Windows as later we would fail to delete those files. > This happens in TestInitializeSharedEdits test case, where we explicitly > called {{Namenode# initializeSharedEdits()}}, where > {{copyEditLogSegmentsToSharedDir()}} is used. Later we fail to create new > MiniDFSCluster with the following exception. > {noformat} > java.io.IOException: Could not fully delete > C:\hdc\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\name1 > at > org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:759) > at > org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:644) > at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:334) > at > org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:316) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits.setupCluster(TestInitializeSharedEdits.java:68) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > … > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5099) Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing
[ https://issues.apache.org/jira/browse/HDFS-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741463#comment-13741463 ] Hudson commented on HDFS-5099: -- SUCCESS: Integrated in Hadoop-trunk-Commit #4274 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4274/]) HDFS-5099. Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing. Contributed by Chuan Liu. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1514481) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon > finishing > --- > > Key: HDFS-5099 > URL: https://issues.apache.org/jira/browse/HDFS-5099 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode >Affects Versions: 3.0.0, 2.1.1-beta >Reporter: Chuan Liu >Assignee: Chuan Liu > Fix For: 3.0.0, 2.1.1-beta > > Attachments: HDFS-5099-trunk.patch > > > In {{Namenode#copyEditLogSegmentsToSharedDir()}} method, we open a collection > of EditLogInputStreams to read and apply to shareEditlog. In {{readOpt()}} > method, we will open the underlying log file on disk. After applying all the > opts, we do not close the collection of streams currently. This lead to a > file handle leak on Windows as later we would fail to delete those files. > This happens in TestInitializeSharedEdits test case, where we explicitly > called {{Namenode# initializeSharedEdits()}}, where > {{copyEditLogSegmentsToSharedDir()}} is used. Later we fail to create new > MiniDFSCluster with the following exception. > {noformat} > java.io.IOException: Could not fully delete > C:\hdc\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\name1 > at > org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:759) > at > org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:644) > at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:334) > at > org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:316) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits.setupCluster(TestInitializeSharedEdits.java:68) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > … > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5099) Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing
[ https://issues.apache.org/jira/browse/HDFS-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740649#comment-13740649 ] Chuan Liu commented on HDFS-5099: - bq. -1 tests included. The patch doesn't appear to include any new or modified tests. The existing unit test TestInitializeSharedEdits should be able to verify this behavior. > Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon > finishing > --- > > Key: HDFS-5099 > URL: https://issues.apache.org/jira/browse/HDFS-5099 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0, 2.3.0 >Reporter: Chuan Liu >Assignee: Chuan Liu > Attachments: HDFS-5099-trunk.patch > > > In {{Namenode#copyEditLogSegmentsToSharedDir()}} method, we open a collection > of EditLogInputStreams to read and apply to shareEditlog. In {{readOpt()}} > method, we will open the underlying log file on disk. After applying all the > opts, we do not close the collection of streams currently. This lead to a > file handle leak on Windows as later we would fail to delete those files. > This happens in TestInitializeSharedEdits test case, where we explicitly > called {{Namenode# initializeSharedEdits()}}, where > {{copyEditLogSegmentsToSharedDir()}} is used. Later we fail to create new > MiniDFSCluster with the following exception. > {noformat} > java.io.IOException: Could not fully delete > C:\hdc\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\name1 > at > org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:759) > at > org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:644) > at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:334) > at > org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:316) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits.setupCluster(TestInitializeSharedEdits.java:68) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > … > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5099) Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon finishing
[ https://issues.apache.org/jira/browse/HDFS-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740644#comment-13740644 ] Hadoop QA commented on HDFS-5099: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12598132/HDFS-5099-trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4829//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4829//console This message is automatically generated. > Namenode#copyEditLogSegmentsToSharedDir should close EditLogInputStreams upon > finishing > --- > > Key: HDFS-5099 > URL: https://issues.apache.org/jira/browse/HDFS-5099 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 3.0.0, 2.3.0 >Reporter: Chuan Liu >Assignee: Chuan Liu > Attachments: HDFS-5099-trunk.patch > > > In {{Namenode#copyEditLogSegmentsToSharedDir()}} method, we open a collection > of EditLogInputStreams to read and apply to shareEditlog. In {{readOpt()}} > method, we will open the underlying log file on disk. After applying all the > opts, we do not close the collection of streams currently. This lead to a > file handle leak on Windows as later we would fail to delete those files. > This happens in TestInitializeSharedEdits test case, where we explicitly > called {{Namenode# initializeSharedEdits()}}, where > {{copyEditLogSegmentsToSharedDir()}} is used. Later we fail to create new > MiniDFSCluster with the following exception. > {noformat} > java.io.IOException: Could not fully delete > C:\hdc\hadoop-hdfs-project\hadoop-hdfs\target\test\data\dfs\name1 > at > org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:759) > at > org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:644) > at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:334) > at > org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:316) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits.setupCluster(TestInitializeSharedEdits.java:68) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > … > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira