[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[ https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981023#comment-13981023 ] Hudson commented on HDFS-5213: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1742 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1742/]) HDFS-5213. TestDataNodeConfig failing on Jenkins runs due to DN web port in use. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1589474) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeConfig.java separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId -- Key: HDFS-5213 URL: https://issues.apache.org/jira/browse/HDFS-5213 Project: Hadoop HDFS Issue Type: Sub-task Components: datanode, namenode Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: HDFS-4949 Attachments: HDFS-5213-caching.001.patch, HDFS-5213-caching.003.patch Since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. Some other miscellaneous cleanups in the caching RPC stuff. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[ https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979596#comment-13979596 ] Hudson commented on HDFS-5213: -- ABORTED: Integrated in Hadoop-Yarn-trunk #550 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/550/]) HDFS-5213. TestDataNodeConfig failing on Jenkins runs due to DN web port in use. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1589474) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeConfig.java separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId -- Key: HDFS-5213 URL: https://issues.apache.org/jira/browse/HDFS-5213 Project: Hadoop HDFS Issue Type: Sub-task Components: datanode, namenode Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: HDFS-4949 Attachments: HDFS-5213-caching.001.patch, HDFS-5213-caching.003.patch Since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. Some other miscellaneous cleanups in the caching RPC stuff. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[ https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979714#comment-13979714 ] Hudson commented on HDFS-5213: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1767 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1767/]) HDFS-5213. TestDataNodeConfig failing on Jenkins runs due to DN web port in use. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1589474) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeConfig.java separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId -- Key: HDFS-5213 URL: https://issues.apache.org/jira/browse/HDFS-5213 Project: Hadoop HDFS Issue Type: Sub-task Components: datanode, namenode Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: HDFS-4949 Attachments: HDFS-5213-caching.001.patch, HDFS-5213-caching.003.patch Since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. Some other miscellaneous cleanups in the caching RPC stuff. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[ https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978795#comment-13978795 ] Hudson commented on HDFS-5213: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5554 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5554/]) HDFS-5213. TestDataNodeConfig failing on Jenkins runs due to DN web port in use. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1589474) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeConfig.java separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId -- Key: HDFS-5213 URL: https://issues.apache.org/jira/browse/HDFS-5213 Project: Hadoop HDFS Issue Type: Sub-task Components: datanode, namenode Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: HDFS-4949 Attachments: HDFS-5213-caching.001.patch, HDFS-5213-caching.003.patch Since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. Some other miscellaneous cleanups in the caching RPC stuff. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[ https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978811#comment-13978811 ] Andrew Wang commented on HDFS-5213: --- Looks like I spelled the JIRA for HDFS-6213 wrong in the commit message. Oops. separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId -- Key: HDFS-5213 URL: https://issues.apache.org/jira/browse/HDFS-5213 Project: Hadoop HDFS Issue Type: Sub-task Components: datanode, namenode Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: HDFS-4949 Attachments: HDFS-5213-caching.001.patch, HDFS-5213-caching.003.patch Since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. Some other miscellaneous cleanups in the caching RPC stuff. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[
https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770478#comment-13770478
]
Andrew Wang commented on HDFS-5213:
---
Hey Colin,
Naming:
* Can we rename {{PathBasedCacheDirectiveWithId}} to something more general,
like {{PathBasedCacheDescriptor}}? Reminiscent of file descriptor.
* If {{PathBasedCacheDirectiveWithId}} is a client-side class, the javadoc
shouldn't be saying that it's an entry in the NameNode's PathBasedCache. That
sounds like a {{PathBasedCacheEntry}}.
* The {{PathBasedCacheEntry}} javadoc also needs to be improved
* {{getDirective()}} should be named {{getDirectiveWithId()}} (or
{{getDescriptor()}} if you use my suggestion).
* Exception text shouldn't talk about a {{PathBasedCache entry}} when it's
supposed to be a private namenode class. There's also no {{PathBasedCache}}
class, so confusing.
Nits/other:
* For implementing equals, how about comparing {{getClass()}} rather than
casting? This means it won't take subclasses, which is normally a good thing
(safe symmetric equals).
* I don't think any of this should be marked {{InterfaceAudience.Stable}} yet.
* extra {{mortbay.log}} import
Unrelated-but-related:
* I still want to see Paths, not Strings, for the DFS methods involving cache
directives. It's non-standard and weird for the reasons I mentioned before, and
DFS has error checking for being passed a URI for a different FileSystem.
separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
--
Key: HDFS-5213
URL: https://issues.apache.org/jira/browse/HDFS-5213
Project: Hadoop HDFS
Issue Type: Sub-task
Components: datanode, namenode
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Attachments: HDFS-5213-caching.001.patch
Since PathBasedCacheEntry is intended to be a private (implementation) class,
return PathBasedCacheDirectiveWithId from all public APIs instead. Some
other miscellaneous cleanups in the caching RPC stuff.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[
https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771051#comment-13771051
]
Colin Patrick McCabe commented on HDFS-5213:
bq. Can we rename PathBasedCacheDirectiveWithId to something more general, like
PathBasedCacheDescriptor? Reminiscent of file descriptor.
That's a good idea. I renamed it
bq. [javadoc issues]
Fixed.
bq. getDirective() should be named getDirectiveWithId() (or getDescriptor() if
you use my suggestion).
OK.
bq. [exception text]
Replace all references to entry etc. with references to
{{PathBasedCacheDescriptor}}.
bq. For implementing equals, how about comparing getClass() rather than
casting? This means it won't take subclasses, which is normally a good thing
(safe symmetric equals).
good idea
bq. extra mortbay.log import
Another auto-add by eclipse. I wonder if I can blacklist this somehow.
separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
--
Key: HDFS-5213
URL: https://issues.apache.org/jira/browse/HDFS-5213
Project: Hadoop HDFS
Issue Type: Sub-task
Components: datanode, namenode
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Attachments: HDFS-5213-caching.001.patch
Since PathBasedCacheEntry is intended to be a private (implementation) class,
return PathBasedCacheDirectiveWithId from all public APIs instead. Some
other miscellaneous cleanups in the caching RPC stuff.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[ https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771137#comment-13771137 ] Colin Patrick McCabe commented on HDFS-5213: bq. I still want to see Paths, not Strings, for the DFS methods involving cache directives. It's non-standard and weird for the reasons I mentioned before, and DFS has error checking for being passed a URI for a different FileSystem. After considering this, I agree. we can have the paths normalized and absolutized in DistributedFileSystem. I started doing this, but it got to be too many changes for one patch. It's a little tricky how it interacts with directive validation. Let's do this in a future frontend patch. separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId -- Key: HDFS-5213 URL: https://issues.apache.org/jira/browse/HDFS-5213 Project: Hadoop HDFS Issue Type: Sub-task Components: datanode, namenode Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Attachments: HDFS-5213-caching.001.patch Since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. Some other miscellaneous cleanups in the caching RPC stuff. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[ https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771209#comment-13771209 ] Andrew Wang commented on HDFS-5213: --- +1 will commit shortly, thanks Colin! I'll file a follow-on JIRA for the String-to-Path change. separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId -- Key: HDFS-5213 URL: https://issues.apache.org/jira/browse/HDFS-5213 Project: Hadoop HDFS Issue Type: Sub-task Components: datanode, namenode Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Attachments: HDFS-5213-caching.001.patch, HDFS-5213-caching.003.patch Since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. Some other miscellaneous cleanups in the caching RPC stuff. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-5213) separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId
[ https://issues.apache.org/jira/browse/HDFS-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767986#comment-13767986 ] Colin Patrick McCabe commented on HDFS-5213: * fix exception translation error in cache directive add code path * add exception to represent a directive with the given path already existing in a cache pool * since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. * get rid of unnecessary CacheManager#entriesByDirective. PathBasedCacheDirective no longer needs to be Comparable. * fix unit test failures * fix bug where -listPaths didn't work without a -path argument separate PathBasedCacheEntry and PathBasedCacheDirectiveWithId -- Key: HDFS-5213 URL: https://issues.apache.org/jira/browse/HDFS-5213 Project: Hadoop HDFS Issue Type: Sub-task Components: datanode, namenode Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Since PathBasedCacheEntry is intended to be a private (implementation) class, return PathBasedCacheDirectiveWithId from all public APIs instead. Some other miscellaneous cleanups in the caching RPC stuff. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
