[jira] [Commented] (HDFS-5267) Modification field in LightWeightHashSet and LightWeightLinkedSet should't be volatile which cause wrong expectation on thread-safe visibility

2013-10-04 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786935#comment-13786935
 ] 

Hadoop QA commented on HDFS-5267:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12606960/HDFS-5267.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/5105//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5105//console

This message is automatically generated.

> Modification field in LightWeightHashSet and LightWeightLinkedSet should't be 
> volatile which cause wrong expectation on thread-safe visibility
> --
>
> Key: HDFS-5267
> URL: https://issues.apache.org/jira/browse/HDFS-5267
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Junping Du
>Assignee: Junping Du
> Fix For: 2.3.0
>
> Attachments: HADOOP-9980.patch, HDFS-5267.patch, HDFS-5276.patch
>
>
> LightWeightGSet should have a volatile modification field (like: 
> LightWeightHashSet or LightWeightLinkedSet) that is used to detect updates 
> while iterating so they can throw a ConcurrentModificationException.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HDFS-5267) Modification field in LightWeightHashSet and LightWeightLinkedSet should't be volatile which cause wrong expectation on thread-safe visibility

2013-10-09 Thread Luke Lu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790860#comment-13790860
 ] 

Luke Lu commented on HDFS-5267:
---

The patch lgtm. +1.

> Modification field in LightWeightHashSet and LightWeightLinkedSet should't be 
> volatile which cause wrong expectation on thread-safe visibility
> --
>
> Key: HDFS-5267
> URL: https://issues.apache.org/jira/browse/HDFS-5267
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Junping Du
>Assignee: Junping Du
>Priority: Minor
> Fix For: 2.3.0
>
> Attachments: HADOOP-9980.patch, HDFS-5267.patch, HDFS-5276.patch
>
>
> LightWeightGSet should have a volatile modification field (like: 
> LightWeightHashSet or LightWeightLinkedSet) that is used to detect updates 
> while iterating so they can throw a ConcurrentModificationException.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (HDFS-5267) Modification field in LightWeightHashSet and LightWeightLinkedSet should't be volatile which cause wrong expectation on thread-safe visibility

2013-09-26 Thread Junping Du (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779719#comment-13779719
 ] 

Junping Du commented on HDFS-5267:
--

Thanks Chris for confirmation. Already move to HDFS and deliver a quick patch 
for it. LightWeightLinkedSet inherit "modification" field from 
LightWeightHashSet, so only one tiny change here.

> Modification field in LightWeightHashSet and LightWeightLinkedSet should't be 
> volatile which cause wrong expectation on thread-safe visibility
> --
>
> Key: HDFS-5267
> URL: https://issues.apache.org/jira/browse/HDFS-5267
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Junping Du
>Assignee: Junping Du
> Fix For: 2.3.0
>
> Attachments: HADOOP-9980.patch, HDFS-5276.patch
>
>
> LightWeightGSet should have a volatile modification field (like: 
> LightWeightHashSet or LightWeightLinkedSet) that is used to detect updates 
> while iterating so they can throw a ConcurrentModificationException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-5267) Modification field in LightWeightHashSet and LightWeightLinkedSet should't be volatile which cause wrong expectation on thread-safe visibility

2013-09-27 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779788#comment-13779788
 ] 

Hadoop QA commented on HDFS-5267:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12605404/HDFS-5276.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/5056//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5056//console

This message is automatically generated.

> Modification field in LightWeightHashSet and LightWeightLinkedSet should't be 
> volatile which cause wrong expectation on thread-safe visibility
> --
>
> Key: HDFS-5267
> URL: https://issues.apache.org/jira/browse/HDFS-5267
> Project: Hadoop HDFS
>  Issue Type: Bug
>Reporter: Junping Du
>Assignee: Junping Du
> Fix For: 2.3.0
>
> Attachments: HADOOP-9980.patch, HDFS-5276.patch
>
>
> LightWeightGSet should have a volatile modification field (like: 
> LightWeightHashSet or LightWeightLinkedSet) that is used to detect updates 
> while iterating so they can throw a ConcurrentModificationException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira