[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787227#comment-13787227
]
Hudson commented on HDFS-5300:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1569 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1569/])
HDFS-5300. FSNameSystem#deleteSnapshot() should not check owner in case of
permissions disabled. Contributed by Vinay. (jing9:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1529294)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDeletion.java
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Fix For: 2.1.2-beta
>
> Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787211#comment-13787211
]
Hudson commented on HDFS-5300:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1543 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1543/])
HDFS-5300. FSNameSystem#deleteSnapshot() should not check owner in case of
permissions disabled. Contributed by Vinay. (jing9:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1529294)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDeletion.java
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Fix For: 2.1.2-beta
>
> Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787167#comment-13787167
]
Hudson commented on HDFS-5300:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #353 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/353/])
HDFS-5300. FSNameSystem#deleteSnapshot() should not check owner in case of
permissions disabled. Contributed by Vinay. (jing9:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1529294)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDeletion.java
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Fix For: 2.1.2-beta
>
> Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786932#comment-13786932
]
Vinay commented on HDFS-5300:
-
Thanks jing for review, updating the patch and commit.
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Fix For: 2.1.2-beta
>
> Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786654#comment-13786654
]
Hudson commented on HDFS-5300:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4540 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/4540/])
HDFS-5300. FSNameSystem#deleteSnapshot() should not check owner in case of
permissions disabled. Contributed by Vinay. (jing9:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1529294)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDeletion.java
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Fix For: 2.1.2-beta
>
> Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786557#comment-13786557
]
Hadoop QA commented on HDFS-5300:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12606843/HDFS-5300.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5096//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5096//console
This message is automatically generated.
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786418#comment-13786418
]
Jing Zhao commented on HDFS-5300:
-
Besides of the nit +1 for the patch.
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5300.patch, HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786397#comment-13786397
]
Jing Zhao commented on HDFS-5300:
-
The patch looks great. Only one nit: we can rename the new test from
"testDeleteSnapShotWithPermissionsDisabled" to
"testDeleteSnapshotWithPermissionsDisabled" to be consistent with all other
test cases.
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786045#comment-13786045
]
Hadoop QA commented on HDFS-5300:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12606745/HDFS-5300.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5095//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5095//console
This message is automatically generated.
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5300.patch, HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785957#comment-13785957
]
Vinay commented on HDFS-5300:
-
Oh.. Thanks Jing. I will move the unit test to TestSnapshotDeletion.java
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5300) FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled
[
https://issues.apache.org/jira/browse/HDFS-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785954#comment-13785954
]
Jing Zhao commented on HDFS-5300:
-
Thanks for the fix Vinay! So for the new unit test, I think maybe it's better
to put it in TestSnapshotDeletion.java?
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
>
>
> Key: HDFS-5300
> URL: https://issues.apache.org/jira/browse/HDFS-5300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
>Affects Versions: 3.0.0, 2.1.0-beta
>Reporter: Vinay
>Assignee: Vinay
> Attachments: HDFS-5300.patch
>
>
> FSNameSystem#deleteSnapshot() should not check owner in case of permissions
> disabled
> {code:java} checkOperation(OperationCategory.WRITE);
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot delete snapshot for " + snapshotRoot, safeMode);
> }
> FSPermissionChecker pc = getPermissionChecker();
> checkOwner(pc, snapshotRoot);
> BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
> List removedINodes = new ChunkedArrayList();
> dir.writeLock();{code}
> should check owner only in case of permissions enabled as its done for all
> other operations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
