[jira] [Commented] (HDFS-5562) TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
[
https://issues.apache.org/jira/browse/HDFS-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834404#comment-13834404
]
Andrew Wang commented on HDFS-5562:
---
+1 LGTM, thanks Akira and Colin. Will commit shortly.
> TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
>
>
> Key: HDFS-5562
> URL: https://issues.apache.org/jira/browse/HDFS-5562
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Akira AJISAKA
>Assignee: Colin Patrick McCabe
> Attachments: HDFS-5562.002.patch, HDFS-5562.3.patch,
> HDFS-5562.v1.patch,
> org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache-output.txt,
> org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache.txt
>
>
> Some tests fail on trunk.
> {code}
> Tests in error:
> TestCacheDirectives.testWaitForCachedReplicas:710 » Runtime Cannot start
> datan...
> TestCacheDirectives.testAddingCacheDirectiveInfosWhenCachingIsDisabled:767
> » Runtime
> TestCacheDirectives.testWaitForCachedReplicasInDirectory:813 » Runtime
> Cannot ...
> TestCacheDirectives.testReplicationFactor:897 » Runtime Cannot start
> datanode ...
> Tests run: 9, Failures: 0, Errors: 4, Skipped: 0
> {code}
> For more details, see https://builds.apache.org/job/Hadoop-Hdfs-trunk/1592/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5562) TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
[
https://issues.apache.org/jira/browse/HDFS-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833542#comment-13833542
]
Hadoop QA commented on HDFS-5562:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615999/HDFS-5562.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5587//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5587//console
This message is automatically generated.
> TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
>
>
> Key: HDFS-5562
> URL: https://issues.apache.org/jira/browse/HDFS-5562
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Akira AJISAKA
>Assignee: Colin Patrick McCabe
> Attachments: HDFS-5562.002.patch, HDFS-5562.3.patch,
> HDFS-5562.v1.patch,
> org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache-output.txt,
> org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache.txt
>
>
> Some tests fail on trunk.
> {code}
> Tests in error:
> TestCacheDirectives.testWaitForCachedReplicas:710 » Runtime Cannot start
> datan...
> TestCacheDirectives.testAddingCacheDirectiveInfosWhenCachingIsDisabled:767
> » Runtime
> TestCacheDirectives.testWaitForCachedReplicasInDirectory:813 » Runtime
> Cannot ...
> TestCacheDirectives.testReplicationFactor:897 » Runtime Cannot start
> datanode ...
> Tests run: 9, Failures: 0, Errors: 4, Skipped: 0
> {code}
> For more details, see https://builds.apache.org/job/Hadoop-Hdfs-trunk/1592/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5562) TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
[
https://issues.apache.org/jira/browse/HDFS-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833448#comment-13833448
]
Akira AJISAKA commented on HDFS-5562:
-
I think that the test failed because MiniDFSCluster was built before setting
NoMlockCacheManipulator() at setup method.
> TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
>
>
> Key: HDFS-5562
> URL: https://issues.apache.org/jira/browse/HDFS-5562
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Akira AJISAKA
>Assignee: Colin Patrick McCabe
> Attachments: HDFS-5562.002.patch, HDFS-5562.3.patch,
> HDFS-5562.v1.patch,
> org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache-output.txt,
> org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache.txt
>
>
> Some tests fail on trunk.
> {code}
> Tests in error:
> TestCacheDirectives.testWaitForCachedReplicas:710 » Runtime Cannot start
> datan...
> TestCacheDirectives.testAddingCacheDirectiveInfosWhenCachingIsDisabled:767
> » Runtime
> TestCacheDirectives.testWaitForCachedReplicasInDirectory:813 » Runtime
> Cannot ...
> TestCacheDirectives.testReplicationFactor:897 » Runtime Cannot start
> datanode ...
> Tests run: 9, Failures: 0, Errors: 4, Skipped: 0
> {code}
> For more details, see https://builds.apache.org/job/Hadoop-Hdfs-trunk/1592/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5562) TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
[
https://issues.apache.org/jira/browse/HDFS-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833437#comment-13833437
]
Akira AJISAKA commented on HDFS-5562:
-
[~cmccabe], thank you for your comment and updating the patch.
With the v2 patch, I confirmed TestCacheDirectives passed but
TestFsDatasetCache failed on my environment. I'll attach the log when I
executed "mvn test -Dtest=TestFsDatasetCache".
> TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
>
>
> Key: HDFS-5562
> URL: https://issues.apache.org/jira/browse/HDFS-5562
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Akira AJISAKA
>Assignee: Colin Patrick McCabe
> Attachments: HDFS-5562.002.patch, HDFS-5562.v1.patch
>
>
> Some tests fail on trunk.
> {code}
> Tests in error:
> TestCacheDirectives.testWaitForCachedReplicas:710 » Runtime Cannot start
> datan...
> TestCacheDirectives.testAddingCacheDirectiveInfosWhenCachingIsDisabled:767
> » Runtime
> TestCacheDirectives.testWaitForCachedReplicasInDirectory:813 » Runtime
> Cannot ...
> TestCacheDirectives.testReplicationFactor:897 » Runtime Cannot start
> datanode ...
> Tests run: 9, Failures: 0, Errors: 4, Skipped: 0
> {code}
> For more details, see https://builds.apache.org/job/Hadoop-Hdfs-trunk/1592/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HDFS-5562) TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
[
https://issues.apache.org/jira/browse/HDFS-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831941#comment-13831941
]
Hadoop QA commented on HDFS-5562:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615645/HDFS-5562.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5560//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5560//console
This message is automatically generated.
> TestCacheDirectives and TestFsDatasetCache should not depend on libhadoop.so
>
>
> Key: HDFS-5562
> URL: https://issues.apache.org/jira/browse/HDFS-5562
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Akira AJISAKA
>Assignee: Binglin Chang
> Attachments: HDFS-5562.002.patch, HDFS-5562.v1.patch
>
>
> Some tests fail on trunk.
> {code}
> Tests in error:
> TestCacheDirectives.testWaitForCachedReplicas:710 » Runtime Cannot start
> datan...
> TestCacheDirectives.testAddingCacheDirectiveInfosWhenCachingIsDisabled:767
> » Runtime
> TestCacheDirectives.testWaitForCachedReplicasInDirectory:813 » Runtime
> Cannot ...
> TestCacheDirectives.testReplicationFactor:897 » Runtime Cannot start
> datanode ...
> Tests run: 9, Failures: 0, Errors: 4, Skipped: 0
> {code}
> For more details, see https://builds.apache.org/job/Hadoop-Hdfs-trunk/1592/
--
This message was sent by Atlassian JIRA
(v6.1#6144)
