[jira] [Commented] (HDFS-5724) modifyCacheDirective logging audit log command wrongly as addCacheDirective
[ https://issues.apache.org/jira/browse/HDFS-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865314#comment-13865314 ] Hudson commented on HDFS-5724: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #446 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/446/]) HDFS-5724. modifyCacheDirective logging audit log command wrongly as addCacheDirective (Uma Maheswara Rao G via Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1556386) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java modifyCacheDirective logging audit log command wrongly as addCacheDirective --- Key: HDFS-5724 URL: https://issues.apache.org/jira/browse/HDFS-5724 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 3.0.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Priority: Minor Labels: caching Attachments: HDFS-5724.patch modifyCacheDirective: {code} if (isAuditEnabled() isExternalInvocation()) { logAuditEvent(success, addCacheDirective, null, null, null); } {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5724) modifyCacheDirective logging audit log command wrongly as addCacheDirective
[ https://issues.apache.org/jira/browse/HDFS-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865503#comment-13865503 ] Hudson commented on HDFS-5724: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1663 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1663/]) HDFS-5724. modifyCacheDirective logging audit log command wrongly as addCacheDirective (Uma Maheswara Rao G via Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1556386) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java modifyCacheDirective logging audit log command wrongly as addCacheDirective --- Key: HDFS-5724 URL: https://issues.apache.org/jira/browse/HDFS-5724 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 3.0.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Priority: Minor Labels: caching Attachments: HDFS-5724.patch modifyCacheDirective: {code} if (isAuditEnabled() isExternalInvocation()) { logAuditEvent(success, addCacheDirective, null, null, null); } {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5724) modifyCacheDirective logging audit log command wrongly as addCacheDirective
[ https://issues.apache.org/jira/browse/HDFS-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864451#comment-13864451 ] Andrew Wang commented on HDFS-5724: --- Thanks Uma, nice catch. +1 pending jenkins, no test is fine here. modifyCacheDirective logging audit log command wrongly as addCacheDirective --- Key: HDFS-5724 URL: https://issues.apache.org/jira/browse/HDFS-5724 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 3.0.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Priority: Minor Labels: caching Attachments: HDFS-5724.patch modifyCacheDirective: {code} if (isAuditEnabled() isExternalInvocation()) { logAuditEvent(success, addCacheDirective, null, null, null); } {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5724) modifyCacheDirective logging audit log command wrongly as addCacheDirective
[ https://issues.apache.org/jira/browse/HDFS-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864577#comment-13864577 ] Hadoop QA commented on HDFS-5724: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621814/HDFS-5724.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5836//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5836//console This message is automatically generated. modifyCacheDirective logging audit log command wrongly as addCacheDirective --- Key: HDFS-5724 URL: https://issues.apache.org/jira/browse/HDFS-5724 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 3.0.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Priority: Minor Labels: caching Attachments: HDFS-5724.patch modifyCacheDirective: {code} if (isAuditEnabled() isExternalInvocation()) { logAuditEvent(success, addCacheDirective, null, null, null); } {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5724) modifyCacheDirective logging audit log command wrongly as addCacheDirective
[ https://issues.apache.org/jira/browse/HDFS-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864800#comment-13864800 ] Hudson commented on HDFS-5724: -- SUCCESS: Integrated in Hadoop-trunk-Commit #4971 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4971/]) HDFS-5724. modifyCacheDirective logging audit log command wrongly as addCacheDirective (Uma Maheswara Rao G via Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1556386) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java modifyCacheDirective logging audit log command wrongly as addCacheDirective --- Key: HDFS-5724 URL: https://issues.apache.org/jira/browse/HDFS-5724 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 3.0.0 Reporter: Uma Maheswara Rao G Assignee: Uma Maheswara Rao G Priority: Minor Labels: caching Attachments: HDFS-5724.patch modifyCacheDirective: {code} if (isAuditEnabled() isExternalInvocation()) { logAuditEvent(success, addCacheDirective, null, null, null); } {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)