[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887654#comment-13887654 ] Hudson commented on HDFS-5856: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #467 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/467/]) HDFS-5856. DataNode.checkDiskError might throw NPE. Contributed by Josh Elser. (suresh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1563064) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java DataNode.checkDiskError might throw NPE --- Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug Components: datanode Affects Versions: 2.2.0 Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Fix For: 2.4.0 Attachments: HDFS-5856.diff, HDFS-5856.diff Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError. Looking at the code, if the Exception that is handed to checkDiskError contains a null message, the checks that try to identify if the Exception is network-related will throw a NPE. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887738#comment-13887738 ] Hudson commented on HDFS-5856: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1684 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1684/]) HDFS-5856. DataNode.checkDiskError might throw NPE. Contributed by Josh Elser. (suresh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1563064) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java DataNode.checkDiskError might throw NPE --- Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug Components: datanode Affects Versions: 2.2.0 Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Fix For: 2.4.0 Attachments: HDFS-5856.diff, HDFS-5856.diff Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError. Looking at the code, if the Exception that is handed to checkDiskError contains a null message, the checks that try to identify if the Exception is network-related will throw a NPE. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887752#comment-13887752 ] Hudson commented on HDFS-5856: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1659 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1659/]) HDFS-5856. DataNode.checkDiskError might throw NPE. Contributed by Josh Elser. (suresh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1563064) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java DataNode.checkDiskError might throw NPE --- Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug Components: datanode Affects Versions: 2.2.0 Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Fix For: 2.4.0 Attachments: HDFS-5856.diff, HDFS-5856.diff Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError. Looking at the code, if the Exception that is handed to checkDiskError contains a null message, the checks that try to identify if the Exception is network-related will throw a NPE. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887941#comment-13887941 ] Josh Elser commented on HDFS-5856: -- Thanks, [~sureshms]. DataNode.checkDiskError might throw NPE --- Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug Components: datanode Affects Versions: 2.2.0 Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Fix For: 2.4.0 Attachments: HDFS-5856.diff, HDFS-5856.diff Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError. Looking at the code, if the Exception that is handed to checkDiskError contains a null message, the checks that try to identify if the Exception is network-related will throw a NPE. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886893#comment-13886893 ] Josh Elser commented on HDFS-5856: -- Current patch also applies cleanly to branch-2. DataNode.checkDiskError might throw NPE --- Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug Components: datanode Affects Versions: 2.2.0 Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Attachments: HDFS-5856.diff Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError. Looking at the code, if the Exception that is handed to checkDiskError contains a null message, the checks that try to identify if the Exception is network-related will throw a NPE. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887324#comment-13887324 ] Suresh Srinivas commented on HDFS-5856: --- [~elserj], thanks for the patch. Minor nits: # Instead of repeating e.getMessage() many times, you could use String msg = e.getMessage(). Might make it is easy to format the code. # One of the lines goes beyond 80 chars. It might be more readable with a line limited to a single exception. Other than it looks good. DataNode.checkDiskError might throw NPE --- Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug Components: datanode Affects Versions: 2.2.0 Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Attachments: HDFS-5856.diff Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError. Looking at the code, if the Exception that is handed to checkDiskError contains a null message, the checks that try to identify if the Exception is network-related will throw a NPE. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887432#comment-13887432 ] Suresh Srinivas commented on HDFS-5856: --- +1 for the patch. I will commit it once Jenkins posts +1. DataNode.checkDiskError might throw NPE --- Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug Components: datanode Affects Versions: 2.2.0 Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Attachments: HDFS-5856.diff, HDFS-5856.diff Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError. Looking at the code, if the Exception that is handed to checkDiskError contains a null message, the checks that try to identify if the Exception is network-related will throw a NPE. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[
https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887477#comment-13887477
]
Hadoop QA commented on HDFS-5856:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12626248/HDFS-5856.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/5998//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5998//console
This message is automatically generated.
DataNode.checkDiskError might throw NPE
---
Key: HDFS-5856
URL: https://issues.apache.org/jira/browse/HDFS-5856
Project: Hadoop HDFS
Issue Type: Bug
Components: datanode
Affects Versions: 2.2.0
Reporter: Josh Elser
Assignee: Josh Elser
Priority: Minor
Attachments: HDFS-5856.diff, HDFS-5856.diff
Running a small 2.2.0 cluster with a heavy workload. I noticed in the
DataNode log that when faced with network exceptions, I would sometimes get a
NullPointerException from checkDiskError.
Looking at the code, if the Exception that is handed to checkDiskError
contains a null message, the checks that try to identify if the Exception is
network-related will throw a NPE.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5856) DataNode.checkDiskError might throw NPE
[ https://issues.apache.org/jira/browse/HDFS-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887498#comment-13887498 ] Hudson commented on HDFS-5856: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5081 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5081/]) HDFS-5856. DataNode.checkDiskError might throw NPE. Contributed by Josh Elser. (suresh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1563064) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java DataNode.checkDiskError might throw NPE --- Key: HDFS-5856 URL: https://issues.apache.org/jira/browse/HDFS-5856 Project: Hadoop HDFS Issue Type: Bug Components: datanode Affects Versions: 2.2.0 Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Fix For: 2.4.0 Attachments: HDFS-5856.diff, HDFS-5856.diff Running a small 2.2.0 cluster with a heavy workload. I noticed in the DataNode log that when faced with network exceptions, I would sometimes get a NullPointerException from checkDiskError. Looking at the code, if the Exception that is handed to checkDiskError contains a null message, the checks that try to identify if the Exception is network-related will throw a NPE. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
