[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908177#comment-13908177
]
Hudson commented on HDFS-5962:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #488 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/488/])
HDFS-5962. Mtime and atime are not persisted for symbolic links. Contributed by
Akira Ajisaka. (kihwal:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1570252)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/LsrPBImage.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImage.java
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Fix For: 3.0.0, 2.4.0
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908316#comment-13908316
]
Hudson commented on HDFS-5962:
--
SUCCESS: Integrated in Hadoop-Hdfs-trunk #1680 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1680/])
HDFS-5962. Mtime and atime are not persisted for symbolic links. Contributed by
Akira Ajisaka. (kihwal:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1570252)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/LsrPBImage.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImage.java
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Fix For: 3.0.0, 2.4.0
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908394#comment-13908394
]
Hudson commented on HDFS-5962:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1705 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1705/])
HDFS-5962. Mtime and atime are not persisted for symbolic links. Contributed by
Akira Ajisaka. (kihwal:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1570252)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/LsrPBImage.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImage.java
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Fix For: 3.0.0, 2.4.0
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907039#comment-13907039
]
Kihwal Lee commented on HDFS-5962:
--
Indeed the test failure does not seem like related. I filed HDFS-5983.
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907101#comment-13907101
]
Kihwal Lee commented on HDFS-5962:
--
+1 lgtm.
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907131#comment-13907131
]
Hudson commented on HDFS-5962:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5195 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5195/])
HDFS-5962. Mtime and atime are not persisted for symbolic links. Contributed by
Akira Ajisaka. (kihwal:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1570252)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/LsrPBImage.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/proto/fsimage.proto
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImage.java
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905547#comment-13905547
]
Kihwal Lee commented on HDFS-5962:
--
It should be easy to add a test case for this. Start a mini cluster, create a
symlink, do saveNamespace and restart the namenode. Compare the time stamp
before and after. Directory (mtime) and file inode (mtime and atime) can be
covered in the same test.
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905841#comment-13905841
]
Haohui Mai commented on HDFS-5962:
--
The old fsimage does not persist mtime and atime. The PB-based fsimage follows
the old behavior. I wonder whether this is a bug in the old code, or it's done
intentionally.
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905937#comment-13905937
]
Hadoop QA commented on HDFS-5962:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629868/HDFS-5962.3.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6176//console
This message is automatically generated.
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905945#comment-13905945
]
Akira AJISAKA commented on HDFS-5962:
-
[~wheat9], I suppose it's a bug because the output of {{ls}} shows wrong
information after restarting NameNode.
{code}
$ hdfs dfs -ls
-rwxrwxrwx - user supergroup 0 1970-01-01 00:00 symlink
{code}
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906382#comment-13906382
]
Hadoop QA commented on HDFS-5962:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629877/HDFS-5962.4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6180//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6180//console
This message is automatically generated.
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906507#comment-13906507
]
Hadoop QA commented on HDFS-5962:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629909/HDFS-5962.5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestSafeMode
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6183//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6183//console
This message is automatically generated.
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5962) Mtime and atime are not persisted for symbolic links
[
https://issues.apache.org/jira/browse/HDFS-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906565#comment-13906565
]
Akira AJISAKA commented on HDFS-5962:
-
The test failure looks unrelated to the patch.
Mtime and atime are not persisted for symbolic links
Key: HDFS-5962
URL: https://issues.apache.org/jira/browse/HDFS-5962
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Kihwal Lee
Assignee: Akira AJISAKA
Priority: Critical
Attachments: HDFS-5692.patch, HDFS-5962.2.patch, HDFS-5962.3.patch,
HDFS-5962.4.patch, HDFS-5962.5.patch
In {{FSImageSerialization}}, the mtime and atime of symbolic links are
hardcoded to be 0 when saving to fsimage, even though they are recorded in
memory and shown in the listing until restarting namenode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
