[ 
https://issues.apache.org/jira/browse/HDFS-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905501#comment-13905501
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-5966:
----------------------------------------------

Patch looks good.  A minor suggestion: add saveMD5File(File dataFile, String 
digestString) to MD5FileUtils then both renameMD5File and the original 
saveMD5File can use it.

> Fix rollback of rolling upgrade in NameNode HA setup
> ----------------------------------------------------
>
>                 Key: HDFS-5966
>                 URL: https://issues.apache.org/jira/browse/HDFS-5966
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, ha, hdfs-client, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-5966.000.patch
>
>
> This jira does the following:
> 1. When do rollback for rolling upgrade, we should call 
> FSEditLog#initJournalsForWrite when initializing editLog (just like Upgrade 
> in HA setup).
> 2. After the rollback, we also need to rename the md5 file and change its 
> reference file name.
> 3. Add a new unit test to cover rollback with HA+QJM



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to