[jira] [Commented] (HDFS-5977) FSImageFormatPBINode does not respect -renameReserved upgrade flag
[ https://issues.apache.org/jira/browse/HDFS-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907595#comment-13907595 ] Suresh Srinivas commented on HDFS-5977: --- bq. For future upgrades, I think that this mechanism is no longer required. I think this mechanism may be required, as not everything can start with /.reserved. I think we should address this issue. We should also do another code review to ensure all the previous relevant fsimage related mechanism is available in protobuf based fsimage solution as well. FSImageFormatPBINode does not respect -renameReserved upgrade flag Key: HDFS-5977 URL: https://issues.apache.org/jira/browse/HDFS-5977 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 2.4.0 Reporter: Andrew Wang Labels: protobuf HDFS-5709 added a new upgrade flag -renameReserved which can be used to automatically rename reserved paths like /.reserved encountered during upgrade. The new protobuf loading code does not have a similar facility, so future reserved paths cannot be automatically renamed via -renameReserved. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5977) FSImageFormatPBINode does not respect -renameReserved upgrade flag
[ https://issues.apache.org/jira/browse/HDFS-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907623#comment-13907623 ] Haohui Mai commented on HDFS-5977: -- Thanks [~andrew.wang] and [~sureshms] for the info. Let me resolve this jira as later and keep it around. We can reopen this jira if we need to add another reserved path. FSImageFormatPBINode does not respect -renameReserved upgrade flag Key: HDFS-5977 URL: https://issues.apache.org/jira/browse/HDFS-5977 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 2.4.0 Reporter: Andrew Wang Labels: protobuf HDFS-5709 added a new upgrade flag -renameReserved which can be used to automatically rename reserved paths like /.reserved encountered during upgrade. The new protobuf loading code does not have a similar facility, so future reserved paths cannot be automatically renamed via -renameReserved. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HDFS-5977) FSImageFormatPBINode does not respect -renameReserved upgrade flag
[
https://issues.apache.org/jira/browse/HDFS-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906258#comment-13906258
]
Haohui Mai commented on HDFS-5977:
--
There are two cases here:
# If the user is upgrading from a version that uses the old fsimage, NN will
use the old loader to load the fsimage, which has handled the flag already.
# For future upgrades, I think that this mechanism is no longer required. For
example, currently the NN has already reserved {{.reserved}} in the namespace.
What we need to do here is to regulate ourselves to put special names into
{{.reserved}}. Making this assumption explicit eliminates the needs of renaming
during upgrades, therefore the whole workflow for upgrades can be simplified.
FSImageFormatPBINode does not respect -renameReserved upgrade flag
Key: HDFS-5977
URL: https://issues.apache.org/jira/browse/HDFS-5977
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Affects Versions: 2.4.0
Reporter: Andrew Wang
Labels: protobuf
HDFS-5709 added a new upgrade flag -renameReserved which can be used to
automatically rename reserved paths like /.reserved encountered during
upgrade. The new protobuf loading code does not have a similar facility, so
future reserved paths cannot be automatically renamed via -renameReserved.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HDFS-5977) FSImageFormatPBINode does not respect -renameReserved upgrade flag
[ https://issues.apache.org/jira/browse/HDFS-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906261#comment-13906261 ] Andrew Wang commented on HDFS-5977: --- Hi Haohui, I had the same thought and agree in spirit, but if you look at the comment history on HDFS-5709, [~sureshms] had some concerns about adding more reserved paths beyond our current two. We agreed to implement a more general solution for this reason. I agree that we don't need to implement this for the PB loader until we add another reserved path, but I filed this JIRA so -renameReserved isn't forgotten about in the future. FSImageFormatPBINode does not respect -renameReserved upgrade flag Key: HDFS-5977 URL: https://issues.apache.org/jira/browse/HDFS-5977 Project: Hadoop HDFS Issue Type: Bug Components: namenode Affects Versions: 2.4.0 Reporter: Andrew Wang Labels: protobuf HDFS-5709 added a new upgrade flag -renameReserved which can be used to automatically rename reserved paths like /.reserved encountered during upgrade. The new protobuf loading code does not have a similar facility, so future reserved paths cannot be automatically renamed via -renameReserved. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
