[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[ https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944102#comment-13944102 ] Hudson commented on HDFS-6120: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1734 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1734/]) HDFS-6120. Fix and improve safe mode log messages. (Arpit Agarwal) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1580047) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java > Fix and improve safe mode log messages > -- > > Key: HDFS-6120 > URL: https://issues.apache.org/jira/browse/HDFS-6120 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Affects Versions: 2.3.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0, 2.4.0 > > Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch, > HDFS-6120.03.patch, HDFS-6120.04.patch, HDFS-6120.04.patch > > > In HA mode the SBN can enter safe-mode extension and stay there even after > the extension period has elapsed but continue to return the safemode message > stating that "The threshold has been reached" and "safe mode will be turned > off soon". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[ https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944065#comment-13944065 ] Hudson commented on HDFS-6120: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1709 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1709/]) HDFS-6120. Fix and improve safe mode log messages. (Arpit Agarwal) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1580047) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java > Fix and improve safe mode log messages > -- > > Key: HDFS-6120 > URL: https://issues.apache.org/jira/browse/HDFS-6120 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Affects Versions: 2.3.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0, 2.4.0 > > Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch, > HDFS-6120.03.patch, HDFS-6120.04.patch, HDFS-6120.04.patch > > > In HA mode the SBN can enter safe-mode extension and stay there even after > the extension period has elapsed but continue to return the safemode message > stating that "The threshold has been reached" and "safe mode will be turned > off soon". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[ https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944012#comment-13944012 ] Hudson commented on HDFS-6120: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #517 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/517/]) HDFS-6120. Fix and improve safe mode log messages. (Arpit Agarwal) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1580047) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java > Fix and improve safe mode log messages > -- > > Key: HDFS-6120 > URL: https://issues.apache.org/jira/browse/HDFS-6120 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Affects Versions: 2.3.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0, 2.4.0 > > Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch, > HDFS-6120.03.patch, HDFS-6120.04.patch, HDFS-6120.04.patch > > > In HA mode the SBN can enter safe-mode extension and stay there even after > the extension period has elapsed but continue to return the safemode message > stating that "The threshold has been reached" and "safe mode will be turned > off soon". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[ https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943553#comment-13943553 ] Hudson commented on HDFS-6120: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5373 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5373/]) HDFS-6120. Fix and improve safe mode log messages. (Arpit Agarwal) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1580047) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java > Fix and improve safe mode log messages > -- > > Key: HDFS-6120 > URL: https://issues.apache.org/jira/browse/HDFS-6120 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Affects Versions: 2.3.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Fix For: 3.0.0, 2.4.0 > > Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch, > HDFS-6120.03.patch, HDFS-6120.04.patch, HDFS-6120.04.patch > > > In HA mode the SBN can enter safe-mode extension and stay there even after > the extension period has elapsed but continue to return the safemode message > stating that "The threshold has been reached" and "safe mode will be turned > off soon". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[ https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943508#comment-13943508 ] Jing Zhao commented on HDFS-6120: - +1 for the latest patch. > Fix and improve safe mode log messages > -- > > Key: HDFS-6120 > URL: https://issues.apache.org/jira/browse/HDFS-6120 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Affects Versions: 2.3.0 >Reporter: Arpit Agarwal >Assignee: Arpit Agarwal > Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch, > HDFS-6120.03.patch, HDFS-6120.04.patch, HDFS-6120.04.patch > > > In HA mode the SBN can enter safe-mode extension and stay there even after > the extension period has elapsed but continue to return the safemode message > stating that "The threshold has been reached" and "safe mode will be turned > off soon". -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[
https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943415#comment-13943415
]
Arpit Agarwal commented on HDFS-6120:
-
The failure is in {{testMaxOutHedgedReadPool}} and looks unrelated to this fix.
> Fix and improve safe mode log messages
> --
>
> Key: HDFS-6120
> URL: https://issues.apache.org/jira/browse/HDFS-6120
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 2.3.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch,
> HDFS-6120.03.patch, HDFS-6120.04.patch, HDFS-6120.04.patch
>
>
> In HA mode the SBN can enter safe-mode extension and stay there even after
> the extension period has elapsed but continue to return the safemode message
> stating that "The threshold has been reached" and "safe mode will be turned
> off soon".
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[
https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943387#comment-13943387
]
Hadoop QA commented on HDFS-6120:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12636044/HDFS-6120.04.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestPread
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6463//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6463//console
This message is automatically generated.
> Fix and improve safe mode log messages
> --
>
> Key: HDFS-6120
> URL: https://issues.apache.org/jira/browse/HDFS-6120
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 2.3.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch,
> HDFS-6120.03.patch, HDFS-6120.04.patch, HDFS-6120.04.patch
>
>
> In HA mode the SBN can enter safe-mode extension and stay there even after
> the extension period has elapsed but continue to return the safemode message
> stating that "The threshold has been reached" and "safe mode will be turned
> off soon".
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[
https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942606#comment-13942606
]
Hadoop QA commented on HDFS-6120:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12635884/HDFS-6120.03.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestSafeMode
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6458//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6458//console
This message is automatically generated.
> Fix and improve safe mode log messages
> --
>
> Key: HDFS-6120
> URL: https://issues.apache.org/jira/browse/HDFS-6120
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 2.3.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch,
> HDFS-6120.03.patch, HDFS-6120.04.patch
>
>
> In HA mode the SBN can enter safe-mode extension and stay there even after
> the extension period has elapsed but continue to return the safemode message
> stating that "The threshold has been reached" and "safe mode will be turned
> off soon".
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6120) Fix and improve safe mode log messages
[
https://issues.apache.org/jira/browse/HDFS-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942502#comment-13942502
]
Jing Zhao commented on HDFS-6120:
-
{code}
+ msg += (reached == 0) ? "In safe mode extension. " : "";
{code}
I guess your mean "reached > 0" here? :)
Other than this +1.
> Fix and improve safe mode log messages
> --
>
> Key: HDFS-6120
> URL: https://issues.apache.org/jira/browse/HDFS-6120
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Affects Versions: 2.3.0
>Reporter: Arpit Agarwal
>Assignee: Arpit Agarwal
> Attachments: HDFS-6120.01.patch, HDFS-6120.02.patch,
> HDFS-6120.03.patch
>
>
> In HA mode the SBN can enter safe-mode extension and stay there even after
> the extension period has elapsed but continue to return the safemode message
> stating that "The threshold has been reached" and "safe mode will be turned
> off soon".
--
This message was sent by Atlassian JIRA
(v6.2#6252)
