[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[ https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949358#comment-13949358 ] Hudson commented on HDFS-6150: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1714 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1714/]) HDFS-6150. Add inode id information in the logs to make debugging easier. Contributed by Suresh Srinivas. (suresh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1581914) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery2.java > Add inode id information in the logs to make debugging easier > - > > Key: HDFS-6150 > URL: https://issues.apache.org/jira/browse/HDFS-6150 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas >Priority: Minor > Fix For: 2.4.0 > > Attachments: HDFS-6150.1.patch, HDFS-6150.2.patch, HDFS-6150.3.patch, > HDFS-6150.patch > > > Inode information and path information are missing in the logs and > exceptions. Adding this will help debug multi threading issues related to > using incode INode ID information. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[ https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949325#comment-13949325 ] Hudson commented on HDFS-6150: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1739 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1739/]) HDFS-6150. Add inode id information in the logs to make debugging easier. Contributed by Suresh Srinivas. (suresh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1581914) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery2.java > Add inode id information in the logs to make debugging easier > - > > Key: HDFS-6150 > URL: https://issues.apache.org/jira/browse/HDFS-6150 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas >Priority: Minor > Fix For: 2.4.0 > > Attachments: HDFS-6150.1.patch, HDFS-6150.2.patch, HDFS-6150.3.patch, > HDFS-6150.patch > > > Inode information and path information are missing in the logs and > exceptions. Adding this will help debug multi threading issues related to > using incode INode ID information. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[ https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949173#comment-13949173 ] Hudson commented on HDFS-6150: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #522 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/522/]) HDFS-6150. Add inode id information in the logs to make debugging easier. Contributed by Suresh Srinivas. (suresh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1581914) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery2.java > Add inode id information in the logs to make debugging easier > - > > Key: HDFS-6150 > URL: https://issues.apache.org/jira/browse/HDFS-6150 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas >Priority: Minor > Fix For: 2.4.0 > > Attachments: HDFS-6150.1.patch, HDFS-6150.2.patch, HDFS-6150.3.patch, > HDFS-6150.patch > > > Inode information and path information are missing in the logs and > exceptions. Adding this will help debug multi threading issues related to > using incode INode ID information. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[ https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948081#comment-13948081 ] Hudson commented on HDFS-6150: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5407 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5407/]) HDFS-6150. Add inode id information in the logs to make debugging easier. Contributed by Suresh Srinivas. (suresh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1581914) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecovery2.java > Add inode id information in the logs to make debugging easier > - > > Key: HDFS-6150 > URL: https://issues.apache.org/jira/browse/HDFS-6150 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas >Priority: Minor > Fix For: 2.4.0 > > Attachments: HDFS-6150.1.patch, HDFS-6150.2.patch, HDFS-6150.3.patch, > HDFS-6150.patch > > > Inode information and path information are missing in the logs and > exceptions. Adding this will help debug multi threading issues related to > using incode INode ID information. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[ https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947996#comment-13947996 ] Tsz Wo Nicholas Sze commented on HDFS-6150: --- +1 the latest patch looks good. > Add inode id information in the logs to make debugging easier > - > > Key: HDFS-6150 > URL: https://issues.apache.org/jira/browse/HDFS-6150 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Suresh Srinivas >Assignee: Suresh Srinivas >Priority: Minor > Attachments: HDFS-6150.1.patch, HDFS-6150.2.patch, HDFS-6150.3.patch, > HDFS-6150.patch > > > Inode information and path information are missing in the logs and > exceptions. Adding this will help debug multi threading issues related to > using incode INode ID information. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[
https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947668#comment-13947668
]
Hadoop QA commented on HDFS-6150:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12636531/HDFS-6150.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6509//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6509//console
This message is automatically generated.
> Add inode id information in the logs to make debugging easier
> -
>
> Key: HDFS-6150
> URL: https://issues.apache.org/jira/browse/HDFS-6150
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
>Priority: Minor
> Attachments: HDFS-6150.1.patch, HDFS-6150.2.patch, HDFS-6150.3.patch,
> HDFS-6150.patch
>
>
> Inode information and path information are missing in the logs and
> exceptions. Adding this will help debug multi threading issues related to
> using incode INode ID information.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[
https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946180#comment-13946180
]
Hadoop QA commented on HDFS-6150:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12636483/HDFS-6150.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestLeaseRecovery2
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6483//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6483//console
This message is automatically generated.
> Add inode id information in the logs to make debugging easier
> -
>
> Key: HDFS-6150
> URL: https://issues.apache.org/jira/browse/HDFS-6150
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
>Priority: Minor
> Attachments: HDFS-6150.1.patch, HDFS-6150.2.patch, HDFS-6150.patch
>
>
> Inode information and path information are missing in the logs and
> exceptions. Adding this will help debug multi threading issues related to
> using incode INode ID information.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[ https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945938#comment-13945938 ] Suresh Srinivas commented on HDFS-6150: --- New patch fixes the test failures and address the comments. > Add inode id information in the logs to make debugging easier > - > > Key: HDFS-6150 > URL: https://issues.apache.org/jira/browse/HDFS-6150 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Suresh Srinivas > Attachments: HDFS-6150.1.patch, HDFS-6150.patch > > > Inode information and path information are missing in the logs and > exceptions. Adding this will help debug multi threading issues related to > using incode INode ID information. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[
https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945840#comment-13945840
]
Hadoop QA commented on HDFS-6150:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12636419/HDFS-6150.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestFileCreation
org.apache.hadoop.hdfs.TestLeaseRecovery2
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6478//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/6478//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6478//console
This message is automatically generated.
> Add inode id information in the logs to make debugging easier
> -
>
> Key: HDFS-6150
> URL: https://issues.apache.org/jira/browse/HDFS-6150
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Suresh Srinivas
> Attachments: HDFS-6150.patch
>
>
> Inode information and path information are missing in the logs and
> exceptions. Adding this will help debug multi threading issues related to
> using incode INode ID information.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6150) Add inode id information in the logs to make debugging easier
[
https://issues.apache.org/jira/browse/HDFS-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945823#comment-13945823
]
Tsz Wo Nicholas Sze commented on HDFS-6150:
---
In the existing code, there are two places below that it says "Failed to ... "
+ src + " on client " + clientMachine. It seems saying the src is "on" the
client machine. It should be "for" the client. Could you also fix it as well?
{code}
@@ -2292,8 +2292,8 @@ private void startFileInternal(FSPermissionChecker pc,
String src,
try {
if (myFile == null) {
if (!create) {
- throw new FileNotFoundException("failed to overwrite non-existent
file "
-+ src + " on client " + clientMachine);
+ throw new FileNotFoundException("Can't overwrite non-existent " +
+ src + " on client " + clientMachine);
}
} else {
if (overwrite) {
@@ -2306,8 +2306,8 @@ private void startFileInternal(FSPermissionChecker pc,
String src,
} else {
// If lease soft limit time is expired, recover the lease
recoverLeaseInternal(myFile, src, holder, clientMachine, false);
- throw new FileAlreadyExistsException("failed to create file " + src
- + " on client " + clientMachine + " because the file exists");
+ throw new FileAlreadyExistsException(src + " on client " +
+ clientMachine + " already exists");
}
}
{code}
> Add inode id information in the logs to make debugging easier
> -
>
> Key: HDFS-6150
> URL: https://issues.apache.org/jira/browse/HDFS-6150
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Suresh Srinivas
> Attachments: HDFS-6150.patch
>
>
> Inode information and path information are missing in the logs and
> exceptions. Adding this will help debug multi threading issues related to
> using incode INode ID information.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
