[jira] [Commented] (HDFS-6176) Remove assignments to method arguments
[ https://issues.apache.org/jira/browse/HDFS-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986718#comment-13986718 ] Charles Lamb commented on HDFS-6176: [~sureshms]: It occurred to me that you're trying to close out HDFS-6118 and that this is the subtask that still remains open. I won't be able to get to this for a while so if you want, let's close this out. We can reopen it later if I get time for it. Charles Remove assignments to method arguments -- Key: HDFS-6176 URL: https://issues.apache.org/jira/browse/HDFS-6176 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Charles Lamb Priority: Minor There are many places in the code where assignments are made to method arguments. Eclipse is quite happy to flag this if the appropriate warning is enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6176) Remove assignments to method arguments
[ https://issues.apache.org/jira/browse/HDFS-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986755#comment-13986755 ] Suresh Srinivas commented on HDFS-6176: --- [~clamb], no I intend to keep HDFS-6118 open for a long time :) I have many patches sitting in my github branches that cleanup many other things. So this probably is going to be an ongoing work. BTW can you share details of what this warning means. For a lot of such warnings, IntelliJ provides fix it. So many of my large patches are generated using that (though many were also painful code review and editing). Remove assignments to method arguments -- Key: HDFS-6176 URL: https://issues.apache.org/jira/browse/HDFS-6176 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Charles Lamb Priority: Minor There are many places in the code where assignments are made to method arguments. Eclipse is quite happy to flag this if the appropriate warning is enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6176) Remove assignments to method arguments
[
https://issues.apache.org/jira/browse/HDFS-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986775#comment-13986775
]
Charles Lamb commented on HDFS-6176:
[~sureshms], the warning would be on something like the following
publc void f(Object o) {
o = new Object(); // assignment to a formal arg
}
You're right that I should see if Eclipse has a fix this function.
Remove assignments to method arguments
--
Key: HDFS-6176
URL: https://issues.apache.org/jira/browse/HDFS-6176
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Charles Lamb
Priority: Minor
There are many places in the code where assignments are made to method
arguments. Eclipse is quite happy to flag this if the appropriate warning is
enabled.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6176) Remove assignments to method arguments
[ https://issues.apache.org/jira/browse/HDFS-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13987003#comment-13987003 ] Charles Lamb commented on HDFS-6176: [~sureshms] I looked at this again in eclipse and all of the assignment to arguments errors are in the hadoop-common code, not hdfs. Remove assignments to method arguments -- Key: HDFS-6176 URL: https://issues.apache.org/jira/browse/HDFS-6176 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Charles Lamb Priority: Minor There are many places in the code where assignments are made to method arguments. Eclipse is quite happy to flag this if the appropriate warning is enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6176) Remove assignments to method arguments
[ https://issues.apache.org/jira/browse/HDFS-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983066#comment-13983066 ] Charles Lamb commented on HDFS-6176: Hi Suresh, Thanks. I've been tied up with other things. I'll try to generate a patch in a while. There are several hundred places where the code does this. Charles Remove assignments to method arguments -- Key: HDFS-6176 URL: https://issues.apache.org/jira/browse/HDFS-6176 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Charles Lamb Priority: Minor There are many places in the code where assignments are made to method arguments. Eclipse is quite happy to flag this if the appropriate warning is enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6176) Remove assignments to method arguments
[ https://issues.apache.org/jira/browse/HDFS-6176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978933#comment-13978933 ] Suresh Srinivas commented on HDFS-6176: --- [~clamb], if you post a patch, I can review and commit it. Remove assignments to method arguments -- Key: HDFS-6176 URL: https://issues.apache.org/jira/browse/HDFS-6176 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Charles Lamb Priority: Minor There are many places in the code where assignments are made to method arguments. Eclipse is quite happy to flag this if the appropriate warning is enabled. -- This message was sent by Atlassian JIRA (v6.2#6252)
