[jira] [Commented] (HDFS-6314) Test cases for XAttrs
[ https://issues.apache.org/jira/browse/HDFS-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13992894#comment-13992894 ] Uma Maheswara Rao G commented on HDFS-6314: --- Overall looks good. +1 on the latest patch on addressing a small nit. I am seeing many trailing space issues in FSXAttrBaseTest.java. Please correct them. Test cases for XAttrs - Key: HDFS-6314 URL: https://issues.apache.org/jira/browse/HDFS-6314 Project: Hadoop HDFS Issue Type: Sub-task Components: test Affects Versions: HDFS XAttrs (HDFS-2006) Reporter: Yi Liu Assignee: Yi Liu Fix For: HDFS XAttrs (HDFS-2006) Attachments: HDFS-6314.1.patch, HDFS-6314.2.patch, HDFS-6314.3.patch, HDFS-6314.patch Tests NameNode interaction for all XAttr APIs, covers restarting NN, saving new checkpoint. Tests XAttr for Snapshot, symlinks. Tests XAttr for HA failover. And more... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6314) Test cases for XAttrs
[ https://issues.apache.org/jira/browse/HDFS-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993592#comment-13993592 ] Uma Maheswara Rao G commented on HDFS-6314: --- Thanks a lot, Yi for the update on the patch. +1 Looks good to me. Test cases for XAttrs - Key: HDFS-6314 URL: https://issues.apache.org/jira/browse/HDFS-6314 Project: Hadoop HDFS Issue Type: Sub-task Components: test Affects Versions: HDFS XAttrs (HDFS-2006) Reporter: Yi Liu Assignee: Yi Liu Fix For: HDFS XAttrs (HDFS-2006) Attachments: HDFS-6314.1.patch, HDFS-6314.2.patch, HDFS-6314.3.patch, HDFS-6314.4.patch, HDFS-6314.patch Tests NameNode interaction for all XAttr APIs, covers restarting NN, saving new checkpoint. Tests XAttr for Snapshot, symlinks. Tests XAttr for HA failover. And more... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6314) Test cases for XAttrs
[ https://issues.apache.org/jira/browse/HDFS-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990394#comment-13990394 ] Yi Liu commented on HDFS-6314: -- Thanks Chris for review. I will add them :) Test cases for XAttrs - Key: HDFS-6314 URL: https://issues.apache.org/jira/browse/HDFS-6314 Project: Hadoop HDFS Issue Type: Sub-task Components: test Affects Versions: HDFS XAttrs (HDFS-2006) Reporter: Yi Liu Assignee: Yi Liu Fix For: HDFS XAttrs (HDFS-2006) Attachments: HDFS-6314.1.patch, HDFS-6314.patch Tests NameNode interaction for all XAttr APIs, covers restarting NN, saving new checkpoint. Tests XAttr for Snapshot, symlinks. Tests XAttr for HA failover. And more... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HDFS-6314) Test cases for XAttrs
[
https://issues.apache.org/jira/browse/HDFS-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990013#comment-13990013
]
Chris Nauroth commented on HDFS-6314:
-
Hi, Yi. Thanks for writing all of these tests. I'd like to suggest 2 more
test cases:
# 1) set xattrs on a file, 2) remove the xattrs from that file, 3) restart NN
and 4) set xattrs again on that same file. Do this test twice: once saving a
checkpoint before the restart and again without saving a checkpoint. The idea
here is to make sure that we don't accidentally leave behind a lingering empty
{{XAttrFeature}} attached to the inode after removal of the xattrs. That would
leave the inode in a bad state where future attempts to add xattrs would fail
due to the precondition check in {{INodeWithAdditionalFields#addXAttrFeature}}.
(We had a bug like this on the ACLs feature branch at one time.)
# In {{testXAttrSymlinks}}, let's also do a {{setXAttr}} on the link, and then
do a {{getXAttrs}} on the target and assert that the xattrs previously set
through the link are now visible when querying on the target.
Test cases for XAttrs
-
Key: HDFS-6314
URL: https://issues.apache.org/jira/browse/HDFS-6314
Project: Hadoop HDFS
Issue Type: Sub-task
Components: test
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Yi Liu
Assignee: Yi Liu
Fix For: HDFS XAttrs (HDFS-2006)
Attachments: HDFS-6314.1.patch, HDFS-6314.patch
Tests NameNode interaction for all XAttr APIs, covers restarting NN, saving
new checkpoint.
Tests XAttr for Snapshot, symlinks.
Tests XAttr for HA failover.
And more...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6314) Test cases for XAttrs
[ https://issues.apache.org/jira/browse/HDFS-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986015#comment-13986015 ] Charles Lamb commented on HDFS-6314: FSXAttrBaseTest.java: Add a newline before the package decl. s/restarting NN/restarting the NN/ s/saving new/saving a new/ + * Tests for creating xattr + * 1. create xattr using XAttrSetFlag.CREATE flag. + * 2. Assert exception of creating xattr which already exists. + * 3. Create multiple xattrs + * 4. Restart NN, save checkpoint scenarios. Tests for creating xattrs 1. Create an xattr using XAttrSetFlag.CREATE 2. Create it again and expect an exception 3. Create multiple xattrs 4. Restart the NN in save checkpoint scenarios. + * Tests for replacing xattr + * 1. Replace xattr using XAttrSetFlag.REPLACE flag. + * 2. Assert exception of replacing xattr which does not exist. + * 3. Create multiple xattrs, and replace some. + * 4. Restart NN, save checkpoint scenarios. * Tests for replacing xattrs * 1. Replace an xattr using XAttrSetFlag.REPLACE. * 2. Replace an xattr which doesn't exist and expect an exception * 3. Create multiple xattrs and replace some. * 4. Restart the NNsave in checkpoint scenarios. s/Tests for setting xattr/Tests for setting xattrs/ s/Tests for removing xattr/Tests for removing xattrs/ I noticed that the blank lines have whitespace in them. That should be removed. e.g. the blank line between +Assert.assertArrayEquals(value2, xattrs.get(name2)); +--- THERE'S WHITESPACE HERE +fs.removeXAttr(path, name1); Test cases for XAttrs - Key: HDFS-6314 URL: https://issues.apache.org/jira/browse/HDFS-6314 Project: Hadoop HDFS Issue Type: Sub-task Components: test Affects Versions: HDFS XAttrs (HDFS-2006) Reporter: Yi Liu Assignee: Yi Liu Fix For: HDFS XAttrs (HDFS-2006) Attachments: HDFS-6314.patch Tests NameNode interaction for all XAttr APIs, covers restarting NN, saving new checkpoint. Tests XAttr for Snapshot, symlinks. Tests XAttr for HA failover. And more... -- This message was sent by Atlassian JIRA (v6.2#6252)
