[jira] [Commented] (HDFS-6324) Shift XAttr helper code out for reuse.

2014-05-03 Thread Uma Maheswara Rao G (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988694#comment-13988694
 ] 

Uma Maheswara Rao G commented on HDFS-6324:
---

Latest patch looks good to me. Based on Andrew +1 above, I will commit the 
patch shortly. Thanks all for the reviews.

 Shift XAttr helper code out for reuse.
 --

 Key: HDFS-6324
 URL: https://issues.apache.org/jira/browse/HDFS-6324
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: hdfs-client
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Yi Liu
Assignee: Yi Liu
Priority: Minor
 Fix For: HDFS XAttrs (HDFS-2006)

 Attachments: HDFS-6324.1.patch, HDFS-6324.2.patch, HDFS-6324.patch


 Shift XAttr helper code out for reuse: in DFSClient and WebHDFS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (HDFS-6324) Shift XAttr helper code out for reuse.

2014-05-02 Thread Charles Lamb (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13987848#comment-13987848
 ] 

Charles Lamb commented on HDFS-6324:


I just have a handful of little things.

XAttrHelper.java:

Please add a newline after public class XAttrHelper {

+   * Name can not be null and value can be null, also name prefix 
+   * will be validated. 

Name can not be null. Value can be null. The name and prefix are validated.

int prefixIndex = name.indexOf(.);

Please add a final.

} else if (prefixIndex == name.length() -1) {

s/-1/- 1/

+  throw new HadoopIllegalArgumentException(XAttr name must be prefixed 
with +
+   user/trusted/security/system and '.');

An XAttr name must be prefixed with user/trusted/security/system, followed by 
a '.'
Same change further down in the same method.

 String prefix = name.substring(0, prefixIndex);

Please add a final.


 Shift XAttr helper code out for reuse.
 --

 Key: HDFS-6324
 URL: https://issues.apache.org/jira/browse/HDFS-6324
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: hdfs-client
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Yi Liu
Assignee: Yi Liu
Priority: Minor
 Fix For: HDFS XAttrs (HDFS-2006)

 Attachments: HDFS-6324.patch


 Shift XAttr helper code out for reuse: in DFSClient and WebHDFS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (HDFS-6324) Shift XAttr helper code out for reuse.

2014-05-02 Thread Andrew Wang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988520#comment-13988520
 ] 

Andrew Wang commented on HDFS-6324:
---

+1 once Charlie's comments are addressed. Another small nit, when writing 
single-line comments, the style is to put a space (e.g. {{// comment}} rather 
than {{//comment}}).

 Shift XAttr helper code out for reuse.
 --

 Key: HDFS-6324
 URL: https://issues.apache.org/jira/browse/HDFS-6324
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: hdfs-client
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Yi Liu
Assignee: Yi Liu
Priority: Minor
 Fix For: HDFS XAttrs (HDFS-2006)

 Attachments: HDFS-6324.patch


 Shift XAttr helper code out for reuse: in DFSClient and WebHDFS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)