[jira] [Commented] (HDFS-6345) DFS.listCacheDirectives() should allow filtering based on cache directive ID
[
https://issues.apache.org/jira/browse/HDFS-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002950#comment-14002950
]
Hudson commented on HDFS-6345:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5606 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5606/])
HDFS-6345. DFS.listCacheDirectives() should allow filtering based on cache
directive ID. (wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1595086)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/CacheDirectiveIterator.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CacheManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
DFS.listCacheDirectives() should allow filtering based on cache directive ID
Key: HDFS-6345
URL: https://issues.apache.org/jira/browse/HDFS-6345
Project: Hadoop HDFS
Issue Type: Bug
Components: caching
Affects Versions: 2.4.0
Reporter: Lenni Kuff
Assignee: Andrew Wang
Fix For: 2.5.0
Attachments: hdfs-6345-1.patch, hdfs-6345-2.patch
DFS.listCacheDirectives() should allow filtering based on cache directive ID.
Currently it throws an exception.
For example:
{code}
long directiveId = some id value;
CacheDirectiveInfo filter = new CacheDirectiveInfo.Builder()
.setId(directiveId)
.build();
RemoteIteratorCacheDirectiveEntry itr = dfs.listCacheDirectives(filter);
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6345) DFS.listCacheDirectives() should allow filtering based on cache directive ID
[
https://issues.apache.org/jira/browse/HDFS-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003266#comment-14003266
]
Hudson commented on HDFS-6345:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #562 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/562/])
HDFS-6345. DFS.listCacheDirectives() should allow filtering based on cache
directive ID. (wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1595086)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/CacheDirectiveIterator.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CacheManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
DFS.listCacheDirectives() should allow filtering based on cache directive ID
Key: HDFS-6345
URL: https://issues.apache.org/jira/browse/HDFS-6345
Project: Hadoop HDFS
Issue Type: Bug
Components: caching
Affects Versions: 2.4.0
Reporter: Lenni Kuff
Assignee: Andrew Wang
Fix For: 2.5.0
Attachments: hdfs-6345-1.patch, hdfs-6345-2.patch
DFS.listCacheDirectives() should allow filtering based on cache directive ID.
Currently it throws an exception.
For example:
{code}
long directiveId = some id value;
CacheDirectiveInfo filter = new CacheDirectiveInfo.Builder()
.setId(directiveId)
.build();
RemoteIteratorCacheDirectiveEntry itr = dfs.listCacheDirectives(filter);
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6345) DFS.listCacheDirectives() should allow filtering based on cache directive ID
[
https://issues.apache.org/jira/browse/HDFS-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003301#comment-14003301
]
Hudson commented on HDFS-6345:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1754 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1754/])
HDFS-6345. DFS.listCacheDirectives() should allow filtering based on cache
directive ID. (wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1595086)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/CacheDirectiveIterator.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CacheManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
DFS.listCacheDirectives() should allow filtering based on cache directive ID
Key: HDFS-6345
URL: https://issues.apache.org/jira/browse/HDFS-6345
Project: Hadoop HDFS
Issue Type: Bug
Components: caching
Affects Versions: 2.4.0
Reporter: Lenni Kuff
Assignee: Andrew Wang
Fix For: 2.5.0
Attachments: hdfs-6345-1.patch, hdfs-6345-2.patch
DFS.listCacheDirectives() should allow filtering based on cache directive ID.
Currently it throws an exception.
For example:
{code}
long directiveId = some id value;
CacheDirectiveInfo filter = new CacheDirectiveInfo.Builder()
.setId(directiveId)
.build();
RemoteIteratorCacheDirectiveEntry itr = dfs.listCacheDirectives(filter);
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6345) DFS.listCacheDirectives() should allow filtering based on cache directive ID
[
https://issues.apache.org/jira/browse/HDFS-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003478#comment-14003478
]
Hudson commented on HDFS-6345:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1780 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1780/])
HDFS-6345. DFS.listCacheDirectives() should allow filtering based on cache
directive ID. (wang) (wang:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1595086)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/CacheDirectiveIterator.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CacheManager.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testCacheAdminConf.xml
DFS.listCacheDirectives() should allow filtering based on cache directive ID
Key: HDFS-6345
URL: https://issues.apache.org/jira/browse/HDFS-6345
Project: Hadoop HDFS
Issue Type: Bug
Components: caching
Affects Versions: 2.4.0
Reporter: Lenni Kuff
Assignee: Andrew Wang
Fix For: 2.5.0
Attachments: hdfs-6345-1.patch, hdfs-6345-2.patch
DFS.listCacheDirectives() should allow filtering based on cache directive ID.
Currently it throws an exception.
For example:
{code}
long directiveId = some id value;
CacheDirectiveInfo filter = new CacheDirectiveInfo.Builder()
.setId(directiveId)
.build();
RemoteIteratorCacheDirectiveEntry itr = dfs.listCacheDirectives(filter);
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6345) DFS.listCacheDirectives() should allow filtering based on cache directive ID
[
https://issues.apache.org/jira/browse/HDFS-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999478#comment-13999478
]
Hadoop QA commented on HDFS-6345:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644917/hdfs-6345-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6909//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/6909//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6909//console
This message is automatically generated.
DFS.listCacheDirectives() should allow filtering based on cache directive ID
Key: HDFS-6345
URL: https://issues.apache.org/jira/browse/HDFS-6345
Project: Hadoop HDFS
Issue Type: Bug
Components: caching
Affects Versions: 2.4.0
Reporter: Lenni Kuff
Assignee: Andrew Wang
Fix For: 2.5.0
Attachments: hdfs-6345-1.patch, hdfs-6345-2.patch
DFS.listCacheDirectives() should allow filtering based on cache directive ID.
Currently it throws an exception.
For example:
{code}
long directiveId = some id value;
CacheDirectiveInfo filter = new CacheDirectiveInfo.Builder()
.setId(directiveId)
.build();
RemoteIteratorCacheDirectiveEntry itr = dfs.listCacheDirectives(filter);
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6345) DFS.listCacheDirectives() should allow filtering based on cache directive ID
[
https://issues.apache.org/jira/browse/HDFS-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998297#comment-13998297
]
Colin Patrick McCabe commented on HDFS-6345:
+1 pending jenkins
DFS.listCacheDirectives() should allow filtering based on cache directive ID
Key: HDFS-6345
URL: https://issues.apache.org/jira/browse/HDFS-6345
Project: Hadoop HDFS
Issue Type: Bug
Components: caching
Affects Versions: 2.4.0
Reporter: Lenni Kuff
Assignee: Andrew Wang
Attachments: hdfs-6345-1.patch, hdfs-6345-2.patch
DFS.listCacheDirectives() should allow filtering based on cache directive ID.
Currently it throws an exception.
For example:
{code}
long directiveId = some id value;
CacheDirectiveInfo filter = new CacheDirectiveInfo.Builder()
.setId(directiveId)
.build();
RemoteIteratorCacheDirectiveEntry itr = dfs.listCacheDirectives(filter);
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6345) DFS.listCacheDirectives() should allow filtering based on cache directive ID
[
https://issues.apache.org/jira/browse/HDFS-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996149#comment-13996149
]
Hadoop QA commented on HDFS-6345:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644544/hdfs-6345-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDistributedFileSystem
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6888//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6888//console
This message is automatically generated.
DFS.listCacheDirectives() should allow filtering based on cache directive ID
Key: HDFS-6345
URL: https://issues.apache.org/jira/browse/HDFS-6345
Project: Hadoop HDFS
Issue Type: Bug
Components: caching
Affects Versions: 2.4.0
Reporter: Lenni Kuff
Assignee: Andrew Wang
Attachments: hdfs-6345-1.patch
DFS.listCacheDirectives() should allow filtering based on cache directive ID.
Currently it throws an exception.
For example:
{code}
long directiveId = some id value;
CacheDirectiveInfo filter = new CacheDirectiveInfo.Builder()
.setId(directiveId)
.build();
RemoteIteratorCacheDirectiveEntry itr = dfs.listCacheDirectives(filter);
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6345) DFS.listCacheDirectives() should allow filtering based on cache directive ID
[
https://issues.apache.org/jira/browse/HDFS-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996783#comment-13996783
]
Colin Patrick McCabe commented on HDFS-6345:
{code}
+// Querying for a single ID
+final Long id = filter.getId();
+if (id != null) {
+ if (!directivesById.containsKey(id)) {
+throw new InvalidRequestException(Did not find requested id + id);
+ }
+ prevId = id - 1;
}
{code}
This is a bit tricky, so I think we should add a comment to the code explaining
why we're changing prevId.
{code}
+
ArrayListCacheDirectiveEntry replies =
new ArrayListCacheDirectiveEntry(NUM_PRE_ALLOCATED_ENTRIES);
int numReplies = 0;
@@ -710,6 +718,11 @@ public void removeDirective(long id, FSPermissionChecker
pc)
}
CacheDirective curDirective = cur.getValue();
CacheDirectiveInfo info = cur.getValue().toInfo();
+ if (id != null
+ !(info.getId().equals(id))) {
+// If we didn't find the requested ID, we're done
+break;
+ }
{code}
Maybe change the comment to if we didn't find, or filtered out the requested
ID. Filtering by ID is only one kind of filtering... if an additional filter
is set which eliminates the requested item, nothing will show up.
DFS.listCacheDirectives() should allow filtering based on cache directive ID
Key: HDFS-6345
URL: https://issues.apache.org/jira/browse/HDFS-6345
Project: Hadoop HDFS
Issue Type: Bug
Components: caching
Affects Versions: 2.4.0
Reporter: Lenni Kuff
Assignee: Andrew Wang
Attachments: hdfs-6345-1.patch
DFS.listCacheDirectives() should allow filtering based on cache directive ID.
Currently it throws an exception.
For example:
{code}
long directiveId = some id value;
CacheDirectiveInfo filter = new CacheDirectiveInfo.Builder()
.setId(directiveId)
.build();
RemoteIteratorCacheDirectiveEntry itr = dfs.listCacheDirectives(filter);
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
