[jira] [Commented] (HDFS-6374) setXAttr should require the user to be the owner of the file or directory
[
https://issues.apache.org/jira/browse/HDFS-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998719#comment-13998719
]
Charles Lamb commented on HDFS-6374:
Scratch that last comment. You are right. TestDFSShell.
setXAttr should require the user to be the owner of the file or directory
-
Key: HDFS-6374
URL: https://issues.apache.org/jira/browse/HDFS-6374
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Andrew Wang
Assignee: Charles Lamb
Attachments: HDFS-6374.1.patch, HDFS-6374.2.patch
From the attr(5) manpage:
{noformat}
For this reason, extended user attributes are only allowed for regular
files and directories, and access to extended user attributes is
restricted to the owner and to users with appropriate capabilities for
directories with the sticky bit set (see the chmod(1) manual page for
an explanation of Sticky Directories).
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6374) setXAttr should require the user to be the owner of the file or directory
[
https://issues.apache.org/jira/browse/HDFS-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998716#comment-13998716
]
Charles Lamb commented on HDFS-6374:
Perhaps TestDFSPermissions might be a better place for the new test.
setXAttr should require the user to be the owner of the file or directory
-
Key: HDFS-6374
URL: https://issues.apache.org/jira/browse/HDFS-6374
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Andrew Wang
Assignee: Charles Lamb
Attachments: HDFS-6374.1.patch, HDFS-6374.2.patch
From the attr(5) manpage:
{noformat}
For this reason, extended user attributes are only allowed for regular
files and directories, and access to extended user attributes is
restricted to the owner and to users with appropriate capabilities for
directories with the sticky bit set (see the chmod(1) manual page for
an explanation of Sticky Directories).
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6374) setXAttr should require the user to be the owner of the file or directory
[
https://issues.apache.org/jira/browse/HDFS-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999627#comment-13999627
]
Yi Liu commented on HDFS-6374:
--
Thanks Charles, +1, looks good to me.
setXAttr should require the user to be the owner of the file or directory
-
Key: HDFS-6374
URL: https://issues.apache.org/jira/browse/HDFS-6374
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Andrew Wang
Assignee: Charles Lamb
Attachments: HDFS-6374.1.patch, HDFS-6374.2.patch, HDFS-6374.3.patch
From the attr(5) manpage:
{noformat}
For this reason, extended user attributes are only allowed for regular
files and directories, and access to extended user attributes is
restricted to the owner and to users with appropriate capabilities for
directories with the sticky bit set (see the chmod(1) manual page for
an explanation of Sticky Directories).
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6374) setXAttr should require the user to be the owner of the file or directory
[
https://issues.apache.org/jira/browse/HDFS-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000495#comment-14000495
]
Andrew Wang commented on HDFS-6374:
---
+1 from me as well, though I would have preferred these tests to be against the
java API for brevity. Will commit shortly.
setXAttr should require the user to be the owner of the file or directory
-
Key: HDFS-6374
URL: https://issues.apache.org/jira/browse/HDFS-6374
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Andrew Wang
Assignee: Charles Lamb
Attachments: HDFS-6374.1.patch, HDFS-6374.2.patch, HDFS-6374.3.patch
From the attr(5) manpage:
{noformat}
For this reason, extended user attributes are only allowed for regular
files and directories, and access to extended user attributes is
restricted to the owner and to users with appropriate capabilities for
directories with the sticky bit set (see the chmod(1) manual page for
an explanation of Sticky Directories).
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6374) setXAttr should require the user to be the owner of the file or directory
[
https://issues.apache.org/jira/browse/HDFS-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998330#comment-13998330
]
Yi Liu commented on HDFS-6374:
--
Thanks Charles for the patch.
Agree with Andrew, maybe we can add permission test in {{TestDFSShell}}, we
already have some for xattr in that class.
setXAttr should require the user to be the owner of the file or directory
-
Key: HDFS-6374
URL: https://issues.apache.org/jira/browse/HDFS-6374
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Andrew Wang
Assignee: Charles Lamb
Attachments: HDFS-6374.1.patch, HDFS-6374.2.patch
From the attr(5) manpage:
{noformat}
For this reason, extended user attributes are only allowed for regular
files and directories, and access to extended user attributes is
restricted to the owner and to users with appropriate capabilities for
directories with the sticky bit set (see the chmod(1) manual page for
an explanation of Sticky Directories).
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6374) setXAttr should require the user to be the owner of the file or directory
[
https://issues.apache.org/jira/browse/HDFS-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997151#comment-13997151
]
Andrew Wang commented on HDFS-6374:
---
Could we add a unit test to verify this behavior? Check out some of the doAs
examples in other tests.
I'm also not sure what the sticky bit has to do with this. Making all modify
operations require the owner essentially does the sticky bit, and xattr
operations from what I understand should be checking the permissions of the
inode itself, not its parent directory. So, the intent of this patch seems
right to me.
setXAttr should require the user to be the owner of the file or directory
-
Key: HDFS-6374
URL: https://issues.apache.org/jira/browse/HDFS-6374
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Andrew Wang
Assignee: Charles Lamb
Attachments: HDFS-6374.1.patch, HDFS-6374.2.patch
From the attr(5) manpage:
{noformat}
For this reason, extended user attributes are only allowed for regular
files and directories, and access to extended user attributes is
restricted to the owner and to users with appropriate capabilities for
directories with the sticky bit set (see the chmod(1) manual page for
an explanation of Sticky Directories).
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6374) setXAttr should require the user to be the owner of the file or directory
[
https://issues.apache.org/jira/browse/HDFS-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996264#comment-13996264
]
Charles Lamb commented on HDFS-6374:
Good point Yi. We'll take that into account in the fix for this.
Charles
setXAttr should require the user to be the owner of the file or directory
-
Key: HDFS-6374
URL: https://issues.apache.org/jira/browse/HDFS-6374
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Andrew Wang
Assignee: Charles Lamb
From the attr(5) manpage:
{noformat}
For this reason, extended user attributes are only allowed for regular
files and directories, and access to extended user attributes is
restricted to the owner and to users with appropriate capabilities for
directories with the sticky bit set (see the chmod(1) manual page for
an explanation of Sticky Directories).
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HDFS-6374) setXAttr should require the user to be the owner of the file or directory
[
https://issues.apache.org/jira/browse/HDFS-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13995988#comment-13995988
]
Yi Liu commented on HDFS-6374:
--
setXAttr/removeXAttr are only for owner, and getXAttr are *not* only for Owner
and by r permission.
setXAttr should require the user to be the owner of the file or directory
-
Key: HDFS-6374
URL: https://issues.apache.org/jira/browse/HDFS-6374
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: HDFS XAttrs (HDFS-2006)
Reporter: Andrew Wang
Assignee: Charles Lamb
From the attr(5) manpage:
{noformat}
For this reason, extended user attributes are only allowed for regular
files and directories, and access to extended user attributes is
restricted to the owner and to users with appropriate capabilities for
directories with the sticky bit set (see the chmod(1) manual page for
an explanation of Sticky Directories).
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
